From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1416AC561E6 for ; Thu, 6 Aug 2026 09:24:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:From:Subject: Cc:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jeUoeoRwpKGLAnJ2FDQSjLYpvUnYamDt0cpPK51P2hI=; b=LXj5t30GPOWOa/ f8uEuqy0nhU+wN7LzNCyUK4yVb04rReVsXVRXHhQSoRbdcoaFJ79zEMIyY2C7HOXucmSrnfrIJE9m u7IF9Zf3Bg3fPbzNHG+B+tbR6Kag9qB4Pq1G+rP+qyt5eVoD/gIACROr81kn5tS/cknhpKhVs7YcE L/iLKjYHaU6zsstJ9yTZDqi8whrF39xJR8uRvjo8v+fgztlxImtjTHjUbhUF5yFTdbvWTyI0Mi9dt y65S6aqOTNgbfl7TyJbvEYtP4cXNcDBvCuLFGj2S98YXuykJJXpTB8LxpqVQsNaMA4YlMrvJT6CGg nLSmKCloCYjljimpVH2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wruKl-00000005NLa-2Ydy; Thu, 06 Aug 2026 09:24:15 +0000 Received: from out-171.mta0.migadu.com ([2001:41d0:1004:224b::ab]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wruKi-00000005NIn-2s3m for linux-rockchip@lists.infradead.org; Thu, 06 Aug 2026 09:24:14 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1786008236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dA4vidVbXhTuIp9QqxNa6zPIHYzqdAruYLG2CSq3Ubg=; b=aUsX59P/Rs0XtXz+pr6ZpDN3xLg2qhYYUcMwU5i5B/YJXki/xjKg/RXiIOPHD3m9wiyjvm jjtHnKM1QWosaYFlpMX5nDchtabNJlbdbH7CS3g+9D2C9VSszWthR0ltCUX05RcmR4QMZ/ Xi0EOCqNBIStnzsROASC+WnMZmvfFI1x/8NpxUBVi1nbEflvD/gkv8vGZvdE3TsPPWwZXS CjIV1ID7V6Fmx2Y3YC7X6gKgc9XTIS+8wMAGg2lykgDGb3mM1ENs3gD1WilT84k7Zw+lJc 7xdWzeqKxtFOe6gcU83DyeYCC7mrKZAkOp8H2qiDv6OHqQk0mQNkCccyFW6EDg== Date: Thu, 06 Aug 2026 11:23:39 +0200 Message-Id: Cc: , , , , , , , , , , Subject: Re: [RFC PATCH v6 3/9] dt-bindings: iommu: rockchip: allow the RK3576 NPU MMU clock set X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Jiaxing Hu" , , , , , , , , , , , , References: <20260806063413.350184-1-gahing@gahingwoo.com> <20260806063413.350184-4-gahing@gahingwoo.com> In-Reply-To: <20260806063413.350184-4-gahing@gahingwoo.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260806_022412_855407_39A9CFF7 X-CRM114-Status: GOOD ( 14.44 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Thu Aug 6, 2026 at 8:34 AM CEST, Jiaxing Hu wrote: > The RK3576 NPU MMUs need more than aclk and iface. With only those two > enabled the MMU accepts reads but silently drops register writes: a > DTE_ADDR value written from the power domain, while the domain clocks > are still on, reads back correctly, and the write rk_iommu_resume() does > microseconds later does not land at all. The vendor DT names the CBUF > clocks as that MMU's interface clocks and its driver keeps every NPU > clock on for as long as the device is powered. > > The driver side of this is already upstream, commit 841363ebb508 > ("iommu/rockchip: Take all DT clocks"), which switched rk_iommu to > devm_clk_bulk_get_all(). Widen the schema to match so those nodes can > be described. minItems stays at 2, so every existing devicetree, which > all carry exactly aclk and iface, is unaffected. I agree with all remarks Sashiko made wrt this patch: https://sashiko.dev/#/patchset/20260805063826.95682-1-gahing%40gahingwoo.com?part=3 Now every MMU with "rockchip,rk3568-iommu", "rockchip,rk3588-iommu" or "rockchip,rk3576-iommu" is allowed to have a minimum of 2 clocks, instead of having exactly 2 clocks. That does not sound desirable. Cheers, Diederik > > Signed-off-by: Jiaxing Hu > --- > .../devicetree/bindings/iommu/rockchip,iommu.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml > index 6ce41d11f..a3cedcaaa 100644 > --- a/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml > +++ b/Documentation/devicetree/bindings/iommu/rockchip,iommu.yaml > @@ -42,14 +42,22 @@ properties: > minItems: 1 > > clocks: > + minItems: 2 > items: > - description: Core clock > - description: Interface clock > + - description: Compute clock, RK3576 NPU MMUs only > + - description: Convolution buffer core clock, RK3576 NPU MMUs only > + - description: Convolution buffer interface clock, RK3576 NPU MMUs only > > clock-names: > + minItems: 2 > items: > - const: aclk > - const: iface > + - const: npu > + - const: aclk_cbuf > + - const: hclk_cbuf > > "#iommu-cells": > const: 0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip