From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86DFDC56208 for ; Thu, 6 Aug 2026 11:29:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:From:Subject: Cc:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9D/4KPX9W6mHvGbEAvs1Q04tErPRolE4fiPMylPEZCg=; b=stRsyXi/7Q+7rq FFv6F7frr+v5r2t0bVFFJI6KoFeHStTzVKswTwCr0m8jKq6sJDvNCqKamoAE6dd83hTccBOR5YvhO /Lyo5girWXgpkjuWSpX0ouPIHezJzvXqdZ9FOkvBTPsL+AAtYDzM23oznGaW1+VKF7WnhxWPHmRnT cGX0R+S22IBzJjKHEKQM4EKsQy2TT19AYFzo1DwOYqj+6Pbv4wpM1DLQlEdFZxdlodYplub+K0bfb d4M/GiGUbElPtPnMp0aLVfUOI+/jjpAV0IUGS2ZwE2Kz1fL3WVQsGA9NJa1yG1/EgqcyOKSFB51uJ SqG39cno/hyXhVik8bEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrwHz-00000005eX4-2vZx; Thu, 06 Aug 2026 11:29:31 +0000 Received: from out-179.mta0.migadu.com ([91.218.175.179]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wrwHw-00000005eWV-23AH for linux-rockchip@lists.infradead.org; Thu, 06 Aug 2026 11:29:30 +0000 Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow-tech.com; s=key1; t=1786015764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=felpSIkdk6QTqa6eAv8dEuh25mt0u+aADh0BF20qvVM=; b=n5qLcXtuXkYS0rpKRIbv02qJcUNngkhYcwZ+ntbyiLi6oT4MFMB/tSYI22gM1bCcPjLurC Zn6BgtaMWwJZFCw4KIuyeZo/8ASpSMkf2Z2ShjDCf6Hc0Om2dY2i7YWOI40p392WwQ9MiC SnXxX2r8bzVcxujq/SfpnXPHLyk8BdXtqxvVFu4XzDztHc3de/8uQTIafYp0cG3I581rsl 0U5XROAavYc4dyiTKLNT+89IdGZDTpd/sMfA+evf3NDV2/8zDae95uBwq8B4IYiCdioJ7a 5htupH3TR1kTzVm9e3SDexfmZmjnWRxEL2mcy3GKhSPQvwPayzPRUONxIJ7+Iw== Date: Thu, 06 Aug 2026 13:29:05 +0200 Message-Id: Cc: , , , , , , , , Subject: Re: [RFC PATCH v6 3/9] dt-bindings: iommu: rockchip: allow the RK3576 NPU MMU clock set X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Diederik de Haas" To: "Jiaxing Hu" , , , , , , , , , References: <20260806063413.350184-1-gahing@gahingwoo.com> <20260806063413.350184-4-gahing@gahingwoo.com> <20260806095551.368456-1-gahing@gahingwoo.com> In-Reply-To: <20260806095551.368456-1-gahing@gahingwoo.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260806_042928_920149_14B1BF0C X-CRM114-Status: GOOD ( 18.51 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Jiaxing, On Thu Aug 6, 2026 at 11:55 AM CEST, Jiaxing Hu wrote: > Hi Diederik, > >> Now every MMU with "rockchip,rk3568-iommu", "rockchip,rk3588-iommu" or >> "rockchip,rk3576-iommu" is allowed to have a minimum of 2 clocks, instead >> of having exactly 2 clocks. That does not sound desirable. > > You are right, and it is worse than sounding undesirable, it actually Yeah, it was a 'bit' of an understatement ;-) > happens. I gave an RK3588 NPU MMU a bogus third clock and v6's schema > accepted it without a word. That is a real loss of coverage for every > existing Rockchip IOMMU and I should not have sent it that way. > > Fixed for v7 the way you and the bot suggest, with a compatible of its > own: If you haven't already, it's probably worth checking whether Sashiko made other useful remarks. I don't feel qualified to judge those, so I didn't reference those. But they made be valid as well. Or hallucinations ;-) > compatible = "rockchip,rk3576-npu-iommu", "rockchip,rk3568-iommu"; > > and an allOf that pins each side: > > if compatible contains rockchip,rk3576-npu-iommu > then clocks/clock-names minItems: 5 > else clocks/clock-names maxItems: 2 > > so the NPU MMUs are required to carry all five and everything else is > back to exactly two. Checked in both directions: the three clock RK3588 > node is rejected again, an NPU MMU with only aclk and iface is rejected, > and every rockchip dtb in the tree validates clean. > > No driver change goes with it. rk_iommu matches only "rockchip,iommu" > and "rockchip,rk3568-iommu", and the fallback stays, so the new string > is documentation only. I'll leave it up to others to comment whether that's correct or not. Another thing you could consider is splitting this NPU iommu 'stuff' into a separate patch set and drop the RFC 'prefix' for that series. IIUC the RFC is (only) related to the working of the NPU on RK3576. Cheers, Diederik > The name is the part I am least sure of. Everything else in that binding > ends in -iommu, which is why I did not use -mmu to pair with the > rknn-core node it belongs to. Happy to change it if Heiko or Krzysztof > prefer something else. > > Thanks for catching it. > > Cheers, > Jiaxing > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip