From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0526C9830B for ; Wed, 23 Sep 2026 17:16:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:From:Subject: Cc:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7dy5RuJK3w1i28H0PNenN4GkD1W7Wkom86ymoWNwGH4=; b=cypCK3kDxe+HkY D63qVqIRAWWcI3iWEO0xd1IZ1F/foMikv6surYemeYZ0XMyn7V3b/dC9cDu1H2nv8jJGzfnlThWVe 2XdKYpenHa7q+AZVFKeZUJ7CkPON+YEFlRrb63dQz+LWrEGO6VfgjW/pCcOvYhM6UE3t04TzmdBns 459MKshvYrwtYk81h7tCtMEssOni9M4+6j9zHlUC3C6subGf8PFWyJXVEw7cxzLKo3uNj/WJQdrok yzbgNKjo9woNrI7qXZUQsFnSRUFhaiAgdhZ6lUnyej/0vIxLEReoOwMr4Giq1SdVWZ0l4uDw16xs9 KXobEUTcClYc07dxFxEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9QZR-00000008zC3-0a4r; Wed, 23 Sep 2026 17:15:49 +0000 Received: from out-7.mta1.migadu.com ([95.215.58.7] helo=mta1.migadu.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9QZJ-00000008zAJ-0V5x for linux-rockchip@lists.infradead.org; Wed, 23 Sep 2026 17:15:44 +0000 X-Envelope-To: linux-rockchip@lists.infradead.org DKIM-Signature: a=rsa-sha256; bh=jxGuprUYi106B5t11FFkgi+yqb+rQeyTVQAW+p12YwA=; c=simple/simple; d=cknow-tech.com; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1790183736; v=1; x=1790788536; b=ZVe0P3h1vL/8qbgOqkx72olxY4ujSROqjM5GA/cl7qJF6JFSNt2gDq2Pzo1UvKljCgDNsOkA u0rlqhNm2fR3+NuPptvnQV1bAWCpK6jEUOqfEW/oqZ95g9e/cmfCSQs1u7f8QfvAfT1b8Xsbjde B0BNy5tQfRQSRdFPaJ6bmH7++YW9IyvUL+eMHXgaBBbBUiqSey1YABoPxKuX03yKhxhypFrd1Xg Yn/ldhH/mCSv4TOFo+JpYYMZ1w7fFKLyEE25rzRj5s5RT6+eOt2QL2u8EUkEK6Gaae0GHzoJzbr 2ThwUJ0DqxwMQkKG6K5FDaxBmAskcbxYzBMGFbqUlrvTg== X-Envelope-To: linux-rockchip@lists.infradead.org Received: by smtp.migadu.com with ESMTPS id 6f9c8085352aaf04; Wed, 23 Sep 2026 17:15:17 +0000 X-Mizu-Trace-ID: 6f9c8085352aaf04 X-Migadu-Flow: FLOW_OUT Mime-Version: 1.0 Date: Wed, 23 Sep 2026 19:15:13 +0200 Message-Id: Cc: "Sebastian Reichel" , , , , , , "Jonas Karlman" Subject: Re: [PATCH v5 5/7] arm64: dts: rockchip: describe PCIe RTL8125 Ethernet on NanoPi R5S From: "Diederik de Haas" To: , "Heiner Kallweit" , , "Andrew Lunn" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Heiko Stuebner" X-Mailer: aerc 0.22.0-24-g39041fd9f179 References: <20260910-rk3588-dts-rtl-eth-describe-dt-alias-v5-0-c1b9e5f10cd6@pardini.net> <20260910-rk3588-dts-rtl-eth-describe-dt-alias-v5-5-c1b9e5f10cd6@pardini.net> In-Reply-To: <20260910-rk3588-dts-rtl-eth-describe-dt-alias-v5-5-c1b9e5f10cd6@pardini.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260923_101541_824262_EDB63FB2 X-CRM114-Status: GOOD ( 15.97 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi, On Thu Sep 10, 2026 at 10:07 PM CEST, Ricardo Pardini via B4 Relay wrote: > From: Ricardo Pardini > > The FriendlyElec NanoPi R5S (rk3568) carries two on-board Realtek > RTL8125 NICs behind pcie2x1 and pcie3x1, alongside the existing gmac0 > RGMII PHY. > > Describe the fixed function nodes and attach ethernet1/ethernet2 > aliases (ethernet0 stays mapped to gmac0), so that U-Boot's > fdt_fixup_ethernet() can inject mac-address properties from its > eth1addr/eth2addr env, for stable MACs across boots that both U-Boot > and the kernel agree on. > > Signed-off-by: Ricardo Pardini > --- > arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts | 30 ++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts b/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts > index 90ce6f0e1dcff..9ed11663c31c9 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts > @@ -15,6 +15,8 @@ / { > > aliases { > ethernet0 = &gmac0; > + ethernet1 = &rtl_eth1; > + ethernet2 = &rtl_eth2; > }; With my NanoPi-R5S I'm still getting the following warning: r8169 0001:11:00.0: can't read MAC address, setting random one ``` root@nanopi-r5s:~# ip link 1: lo: mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT group default qlen 1000 link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 2: end1: mtu 1500 qdisc fq_codel state DOWN mode DEFAULT group default qlen 1000 link/ether 4e:52:85:9e:22:f9 brd ff:ff:ff:ff:ff:ff altname enp1s0 altname enx4e52859e22f9 3: end2: mtu 1500 qdisc fq_codel state DOWN mode DEFAULT group default qlen 1000 link/ether 12:e5:47:9e:e2:f1 brd ff:ff:ff:ff:ff:ff altname enP1p17s0 4: end0: mtu 1500 qdisc mq state UP mode DEFAULT group default qlen 1000 link/ether 4e:52:85:9e:22:f8 brd ff:ff:ff:ff:ff:ff altname enx4e52859e22f8 ``` I did not do anything (explicitly) in U-Boot, but it seems it created a non-random MAC address for end0 and end1 ... and then stopped. AFAIK gmac0=end0 already had a non-random MAC address and I hoped/expected it would create non-random addresses for end1 and end2, which would've made the above warning go away too. Is this an issue with this patch, with U-Boot or me? Full details: https://paste.sr.ht/~diederik/8ae7d354985afcd1c3464e3a4ad81da1b4442364 Side note: I wonder how 'random' those addresses are as during testing ``ssh rock5b`` landed me on another device (NanoPC-T6 Plus), f.e. My router has DHCP reservations based on MAC addresses and it looks like it got confused ;-) Cheers, Diederik > gpio-keys { > @@ -107,6 +109,20 @@ &pcie2x1 { > num-lanes = <1>; > reset-gpios = <&gpio0 RK_PB6 GPIO_ACTIVE_HIGH>; > status = "okay"; > + > + pcie@0,0 { > + reg = <0x000000 0 0 0 0>; > + #address-cells = <3>; > + #size-cells = <2>; > + ranges; > + device_type = "pci"; > + bus-range = <0x00 0x0f>; > + > + rtl_eth1: ethernet@0,0 { > + compatible = "pci10ec,8125"; > + reg = <0x010000 0 0 0 0>; > + }; > + }; > }; > > &pcie30phy { > @@ -119,6 +135,20 @@ &pcie3x1 { > reset-gpios = <&gpio0 RK_PA0 GPIO_ACTIVE_HIGH>; > vpcie3v3-supply = <&vcc3v3_pcie>; > status = "okay"; > + > + pcie@0,0 { > + reg = <0x100000 0 0 0 0>; > + #address-cells = <3>; > + #size-cells = <2>; > + ranges; > + device_type = "pci"; > + bus-range = <0x10 0x1f>; > + > + rtl_eth2: ethernet@0,0 { > + compatible = "pci10ec,8125"; > + reg = <0x110000 0 0 0 0>; > + }; > + }; > }; > > &pcie3x2 { _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip