From: Tomasz Figa <tfiga@chromium.org>
To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Cc: linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com,
helen.koike@collabora.com, ezequiel@collabora.com,
hverkuil@xs4all.nl, kernel@collabora.com, dafna3@gmail.com,
sakari.ailus@linux.intel.com, linux-rockchip@lists.infradead.org,
mchehab@kernel.org
Subject: Re: [PATCH 0/2] rkisp1: Two small fixes
Date: Mon, 28 Jun 2021 14:46:57 +0900 [thread overview]
Message-ID: <YNliUasfxV3XpTKb@chromium.org> (raw)
In-Reply-To: <20210625082309.24944-1-dafna.hirschfeld@collabora.com>
On Fri, Jun 25, 2021 at 11:23:07AM +0300, Dafna Hirschfeld wrote:
> Two small fixes to rkisp1
> 1. remove useless vaddr field
> 2. set the dma address of the capture buffers only once in 'buf_init' callabck
> instead of each time the buffer is queued
>
> Dafna Hirschfeld (2):
> media: rkisp1: remove field 'vaddr' from 'rkisp1_buffer'
> media: rkisp1: cap: initialize dma buf address in 'buf_init' cb
>
> .../media/platform/rockchip/rkisp1/rkisp1-capture.c | 12 +++++++++++-
> .../media/platform/rockchip/rkisp1/rkisp1-common.h | 6 +-----
> .../media/platform/rockchip/rkisp1/rkisp1-params.c | 3 +--
> .../media/platform/rockchip/rkisp1/rkisp1-stats.c | 6 ++----
> 4 files changed, 15 insertions(+), 12 deletions(-)
For both patches:
Reviewed-by; Tomasz Figa <tfiga@chromium.org>
Best regards,
Tomasz
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
prev parent reply other threads:[~2021-06-28 5:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 8:23 [PATCH 0/2] rkisp1: Two small fixes Dafna Hirschfeld
2021-06-25 8:23 ` [PATCH 1/2] media: rkisp1: remove field 'vaddr' from 'rkisp1_buffer' Dafna Hirschfeld
2021-06-26 0:51 ` Ezequiel Garcia
2021-06-25 8:23 ` [PATCH 2/2] media: rkisp1: cap: initialize dma buf address in 'buf_init' cb Dafna Hirschfeld
2021-06-26 1:08 ` Ezequiel Garcia
2021-06-28 7:16 ` Laurent Pinchart
2021-06-28 12:13 ` Ezequiel Garcia
2021-07-12 13:21 ` Dafna Hirschfeld
2021-06-28 5:46 ` Tomasz Figa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNliUasfxV3XpTKb@chromium.org \
--to=tfiga@chromium.org \
--cc=dafna.hirschfeld@collabora.com \
--cc=dafna3@gmail.com \
--cc=ezequiel@collabora.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox