From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3249CC433F5 for ; Tue, 9 Nov 2021 12:12:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F14A061152 for ; Tue, 9 Nov 2021 12:12:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F14A061152 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EteKr8CugoLUPZDDHqBUqipCDLjmlbedfAEcvTNY/UQ=; b=wDVycS/OHGmY7d gI214+Yi+/koVDYyA9bXF6257FIsCpxc4jKCTsGRD/ErDrTCYQnYEbYJF4WeG5lOT1K0p4DYoGUuj E0TVYcn5Sm2yz0VGExLmu0XCXozOwN98HAYqmmPGvSmpu704oJWCFinKsOgDtCIUimbFHD0wblhwu 1REHj8ytlxJifx7ywXOC1PsEaQI2YihwwCtNMmZnQ0kDtHvo0NvswQukqQINpS1jfAwg3acsDOkv7 1dbC33TiOGYp/QOeZ8zXzvvGk1wfrvBpp2TV5QMHKxyFx6V+sGJ5cAoI06cU9lu2AjqVW/DAPjygr zPASTsMV5fClUi6BgBsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkPyv-001was-Ti; Tue, 09 Nov 2021 12:12:06 +0000 Received: from mga01.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkPwo-001vc3-1u; Tue, 09 Nov 2021 12:09:55 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10162"; a="256113788" X-IronPort-AV: E=Sophos;i="5.87,220,1631602800"; d="scan'208";a="256113788" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2021 04:07:35 -0800 X-IronPort-AV: E=Sophos;i="5.87,220,1631602800"; d="scan'208";a="469953482" Received: from smile.fi.intel.com ([10.237.72.184]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2021 04:07:30 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mkPuH-0054ja-3j; Tue, 09 Nov 2021 14:07:17 +0200 Date: Tue, 9 Nov 2021 14:07:16 +0200 From: Andy Shevchenko To: Linus Walleij Cc: Joe Perches , Bartosz Golaszewski , Jianqun Xu , Sai Krishna Potthuri , Andrew Morton , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-rockchip@lists.infradead.org" , Bamvor Jian Zhang , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Heiko Stuebner , Patrice Chotard , Michal Simek , Andy Shevchenko Subject: Re: [PATCH v1 14/19] pinctrl: st: Use temporary variable for struct device Message-ID: References: <20211105124242.27288-1-andriy.shevchenko@linux.intel.com> <20211105124242.27288-14-andriy.shevchenko@linux.intel.com> <4b3f1ee1179dd6d4b010cb110b38d26e7d91c19f.camel@perches.com> <103d7321a2d18e44fb8c01483b1197766aff645a.camel@perches.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211109_040954_154040_2362E2AD X-CRM114-Status: GOOD ( 20.36 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Tue, Nov 09, 2021 at 12:55:44PM +0100, Linus Walleij wrote: > On Mon, Nov 8, 2021 at 10:26 AM Andy Shevchenko > wrote: > > > > IMO: the strarray variants introduction and use should be a separate > > > patchset from the rest. > > > > It will add unnecessary churn. Yeah, I have planned to send just that, but then > > it took more and more cleanups and I have to stop at some point, the code there > > is bad (historically or by other reasons, dunno). > > I trust your judgement and taste to a large extent so this will not be > necessary. I can queue the whole series in pinctrl when you > think it's mature. > > The library bits I kind of feel uncertain about who maintains, but I might just > apply it. No worries, Andrew usually applies that in case it's _solely_ library code. Otherwise it's on certain maintainer shoulders to decide. Note, that I'm one of the designated reviewers for lib/string*. Thanks! -- With Best Regards, Andy Shevchenko _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip