From: Andrew Lunn <andrew@lunn.ch>
To: "jay.xu@rock-chips.com" <jay.xu@rock-chips.com>
Cc: kuba <kuba@kernel.org>, davem <davem@davemloft.net>,
joabreu <joabreu@synopsys.com>,
"alexandre.torgue" <alexandre.torgue@st.com>,
"peppe.cavallaro" <peppe.cavallaro@st.com>,
netdev <netdev@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Device Tree <devicetree@vger.kernel.org>
Subject: Re: Re: [PATCH V2] ethernet: stmmac: support driver work for DTs without child queue node
Date: Fri, 29 Apr 2022 14:14:56 +0200 [thread overview]
Message-ID: <YmvWwIgE71iwZhgp@lunn.ch> (raw)
In-Reply-To: <2022042909545741446644@rock-chips.com>
Adding device tree list.
This is mostly a device tree issue, so the device tree Maintainers
should be part of the discussion.
> >On Fri, Apr 29, 2022 at 08:46:05AM +0800, Jianqun Xu wrote:
> >> The driver use the value of property 'snps,rx-queues-to-use' to loop
> >> same numbers child nodes as queues, such as:
> >>
> >> gmac {
> >> rx-queues-config {
> >> snps,rx-queues-to-use = <1>;
> >> queue0 {
> >> // nothing need here.
> >> };
> >> };
> >> };
> >>
> >> Since a patch for dtc from rockchip will delete all node without any
> >> properties or child node, the queue0 node will be deleted, that caused
> >> the driver fail to probe:
> >
> >Is this the in tree dtc? Do you have a commit hash for it? That should
> >probably be used as a Fixes: tag. Or that change to dtc needs
> >reverting because it breaks stuff.
> >
> The patch is a hack patch for some products and have not in tree dtc, I said that to
> explain a possible case how things happed, it's only a case of no child queue node.
So this has nothing to do with the kernel dtc, or the upstream
dtc. This is only a 'vendor crap' dtc which has been hacked?
Why should mainline care? Is there anything in the DT standard which
says the compiler can optimise out empty properties?
Andrew
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2022-04-29 12:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220428010927.526310-1-jay.xu@rock-chips.com>
2022-04-29 0:46 ` [PATCH V2] ethernet: stmmac: support driver work for DTs without child queue node Jianqun Xu
2022-04-29 0:56 ` Andrew Lunn
2022-04-29 1:54 ` jay.xu
2022-04-29 12:14 ` Andrew Lunn [this message]
2022-05-01 1:40 ` jay.xu
2022-04-29 1:40 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmvWwIgE71iwZhgp@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jay.xu@rock-chips.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).