From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27EC0C433EF for ; Tue, 3 May 2022 14:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cMd5/O48UXQp3hFxQzUS/849+Qe49XDjveURSOPGUeI=; b=kEBBnvCKJZEcNF LMJJB5SkJ4+9UfRAO+RKNLbLM0Jn4UgTDYdF2p0VGWRijxlJ9k4lMgth61GqhZZqOPjMkf5IkXaFp nR0bqBPbpwwlItjMFs3ONhwCg110AM6L8pIlEMxJlgsFmVwaY418jkVG+ztT/SRL4VLMKGWGSPcr8 CIzNqprYWd3Wk7fAY6Tm5DXbV1O7Pm12fPMDuMPadxMfCnBf0hhTMUVznpmTo/+OJtmPD0aqjN/XG Eamd9yvx/XHcM7IDv1Ha3ZzDDkNgmwTJzUAnbjhxCZCrWE+K53JQxXcGzQkKI/Mw83BV+URe+como I4g0/hXE0WQpgWwVLtRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nltpd-006K3Q-JA; Tue, 03 May 2022 14:48:53 +0000 Received: from mail-oa1-x2d.google.com ([2001:4860:4864:20::2d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nltpZ-006K1X-S6 for linux-rockchip@lists.infradead.org; Tue, 03 May 2022 14:48:51 +0000 Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-e5ca5c580fso17389250fac.3 for ; Tue, 03 May 2022 07:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BV1kdgg88h2dApOYl3eT3CssciiSPlxmubonwKG/mW4=; b=Vx/Eytelo3ZiPPIy6BcMf32X6UZdSEmR2nLRg7aKVjYWa7pjN6x+UjOE23jnBGqj9p FfpfY/XBM2izLWMN0zBVjzfA1nOFDXyofVQlbQQJPYLs37IFoQgPFvTmSB5CDRmtClm1 pOUI23aiupAropgM3Gl6CubKEvmi+klBwX9WT/1/4FpSMSSeWyGTYO6Y335hCKOvxLWz Ez5GYoCEp90H2hIEn7+7gw1w8Dg9eqdYPK0LCWpq4IL2h7oK67NZMxxVCeLPWyvBBtmE L0+ootPlnamYUz5j9A//vbWoR2OGnh8whYJOFapzsjAQsN52HkmzMegDRaB4xKM6qZee 2uPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BV1kdgg88h2dApOYl3eT3CssciiSPlxmubonwKG/mW4=; b=GKb3Muxb7A0NoKZ2miu55U7o7beQvT7Y3pPOHhZkm+XicTkCLRe9D3mtJ22ende+OI EfN/V5qiWPwZJJVYgcGwxOu13oEKymU4+2/GlbVlM9FxYs79z+rEeqgpyXh7XUHLQJrA liGmWDiNN7XQujryggJE7xArKo/K3/teGEPLrtbVMgz/fs9lYuekxN+SggerqRowIZdM 4hiEzJ150ZHYemAKBiiYzv3gxD44Y335wWd3/Z8e7cPtJ/8vp3huQplzZ2vF+N/do50Y WjJOtE0mx0dnEnlsL+KI2FuQh63T4JRNP3DrKuw3/OaFjJIBgtuJVlu78KLvp/FQJ8J9 aNOA== X-Gm-Message-State: AOAM533+jEwI3oiX9g31O7m3ytGciSJpKavRDxGBBydF1yqthwBtPqXk Xyhj0k7xBaQZC4dsDLzAlAeAbw== X-Google-Smtp-Source: ABdhPJygheLeJdTY7mT0oFr+XZcbBbO/9r9tZYoCSHRNY4qLm/p0Vf9K92aaEDaOY9HSjhTd/4OnKA== X-Received: by 2002:a05:6870:d186:b0:ed:a737:8ae4 with SMTP id a6-20020a056870d18600b000eda7378ae4mr1832370oac.25.1651589324016; Tue, 03 May 2022 07:48:44 -0700 (PDT) Received: from eze-laptop ([2803:9800:98c2:8470:9f4:8e2a:88e5:ec01]) by smtp.gmail.com with ESMTPSA id d11-20020a0568301b6b00b0060603221265sm4045559ote.53.2022.05.03.07.48.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 May 2022 07:48:43 -0700 (PDT) Date: Tue, 3 May 2022 11:48:37 -0300 From: Ezequiel Garcia To: Benjamin Gaignard Cc: p.zabel@pengutronix.de, mchehab@kernel.org, gregkh@linuxfoundation.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, jon@nanocrew.net, aford173@gmail.com, kernel@collabora.com Subject: Re: [PATCH v3] media: hantro: HEVC: unconditionnaly set pps_{cb/cr}_qp_offset values Message-ID: References: <20220503135529.683474-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220503135529.683474-1-benjamin.gaignard@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220503_074849_951641_B460038A X-CRM114-Status: GOOD ( 19.26 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Tue, May 03, 2022 at 03:55:29PM +0200, Benjamin Gaignard wrote: > Always set pps_cb_qp_offset and pps_cr_qp_offset values in Hantro/G2 > register whatever is V4L2_HEVC_PPS_FLAG_PPS_SLICE_CHROMA_QP_OFFSETS_PRESENT > flag value. > The vendor code does the case to set these values. s/case/same > This fix conformance test CAINIT_G_SHARP_3. > > Fluster HEVC score is increase by one with this patch. > Saying "score is increased by one" is not all that useful. I still believe seeing the Fluster score would be adding real information. The score you have without this patch, and using upstream GStreamer is the "current" score. Then the score you get with the patch applied, is the score you get after the fix. And this is actually good as you would also give more information by clarifying the score is the result of GStreamer (commit $sha) plus Linux. > Signed-off-by: Benjamin Gaignard Patch looks fine, but I believe you still have some challenges on the commit descriptions, and so we iterate a lot on them. How about you proof-read them first (or you ask colleagues to proof-read them)? A useful tip I've profit from is to let patches sit for a few days, then re-read and amend the commit before sending them. Reviewed-by: Ezequiel Garcia Thanks! Ezequiel > --- > drivers/staging/media/hantro/hantro_g2_hevc_dec.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/media/hantro/hantro_g2_hevc_dec.c b/drivers/staging/media/hantro/hantro_g2_hevc_dec.c > index 6deb31b7b993..503f4b028bc5 100644 > --- a/drivers/staging/media/hantro/hantro_g2_hevc_dec.c > +++ b/drivers/staging/media/hantro/hantro_g2_hevc_dec.c > @@ -194,13 +194,8 @@ static void set_params(struct hantro_ctx *ctx) > hantro_reg_write(vpu, &g2_max_cu_qpd_depth, 0); > } > > - if (pps->flags & V4L2_HEVC_PPS_FLAG_PPS_SLICE_CHROMA_QP_OFFSETS_PRESENT) { > - hantro_reg_write(vpu, &g2_cb_qp_offset, pps->pps_cb_qp_offset); > - hantro_reg_write(vpu, &g2_cr_qp_offset, pps->pps_cr_qp_offset); > - } else { > - hantro_reg_write(vpu, &g2_cb_qp_offset, 0); > - hantro_reg_write(vpu, &g2_cr_qp_offset, 0); > - } > + hantro_reg_write(vpu, &g2_cb_qp_offset, pps->pps_cb_qp_offset); > + hantro_reg_write(vpu, &g2_cr_qp_offset, pps->pps_cr_qp_offset); > > hantro_reg_write(vpu, &g2_filt_offset_beta, pps->pps_beta_offset_div2); > hantro_reg_write(vpu, &g2_filt_offset_tc, pps->pps_tc_offset_div2); > -- > 2.32.0 > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip