Re: [PATCH 1/1] dt-bindings: pwm: rockchip: Add description for rk3588

Uwe Kleine-König
2022-09-14T07:33:27Z

[-- Attachment #1.1: Type: text/plain, Size: 1739 bytes --]

On Tue, Sep 13, 2022 at 04:16:01PM +0200, Sebastian Reichel wrote:
> Hi,
>
> On Tue, Sep 13, 2022 at 11:12:02AM +0200, Uwe Kleine-König wrote:
> > Hello Rob,
> >
> > On Thu, Sep 01, 2022 at 02:14:55PM -0500, Rob Herring wrote:
> > > On Thu, 01 Sep 2022 15:55:23 +0200, Sebastian Reichel wrote:
> > > > Add "rockchip,rk3588-pwm" compatible string for PWM nodes found
> > > > on a rk3588 platform.
> > > >
> > > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > > > ---
> > > > No driver changes required.
> > > > ---
> > > > Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > >
> > > Running 'make dtbs_check' with the schema in this patch gives the
> > > following warnings. Consider if they are expected or the schema is
> > > incorrect. These may not be new warnings.
> > >
> > > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > > This will change in the future.
> >
> > Is this a list of *new* warnings, or is the report (somewhat) orthogonal
> > to the actual change and you just used the opportunity that someone
> > touched the pwm-rockchip binding to point out that there is some cleanup
> > to do?
> >
> > > Full log is available here: https://patchwork.ozlabs.org/patch/
> >
> > Hm, that gives me a 404.
>
> This is an existing problem with the rv1108 binding.
> The rk3588 does not have pwm interrupts.

I thought so, so:

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]