From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB9FFE77188 for ; Fri, 3 Jan 2025 09:34:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rMGVr0wvGgVIXz1JHs6l1YdOhdcOvqIWfkNNnc90K74=; b=w7LMhr3FXebbpc 5FKqTv0zmRfa0zGdPFewWooPJX6tVHVElCyo0e+oH2oRI7rQff6IVgjx7HQrqp6+pbmkNJPj9MdOH QQ6p/x46QQYU7VkH1PMBt82DtlmSHqIQsXCIajKs6X+RU8B80EiwSg0i4VAKgfOD2spn9VbfM6WvG PgLzIAKGOafgZ2NJxtwajJQbqQWSbFkoFInL7W/xkNgvLPESz5Shoz+j4IfUH86eIOeOnOO68LtJj 0KeVAPweTTp/eWP9rv4fbMockntePygjYAhUMwt7xyVpWJJMX/AkYtl4+L7ABBcdDxpGXsiqYkIlE QsqjC1ASlvNYOtkesSDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tTe4U-0000000CdG5-3qfF; Fri, 03 Jan 2025 09:34:22 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tTe4S-0000000CdF0-3SeH for linux-rockchip@lists.infradead.org; Fri, 03 Jan 2025 09:34:22 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id CD385A4043B; Fri, 3 Jan 2025 09:32:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F036C4CECE; Fri, 3 Jan 2025 09:34:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1735896859; bh=XmUUGTD1NO6xjAkbn5wKLs1TZWqy6CMGAF0Ej5wpK0I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ReOm0PvAkVbol2MuV03nTcv/mAP65VO/44QdQSlzMnEwZh0EA81j2OG5KS2PeKVkW kstQYVDx06l6CWLfJ+J1kKXjV6Y2Qdak9/tDh23cYE+ye+j6QZGfY8pH7Ip8bb9jkl XRP4iHY+yNzVW1bxHebQXXaV1eFVsRkRgc/I/XENbz3KrtABahLsVNay4OcZvoiMo3 fzV0TWutjff0F4AuIxKIMe1h6okmlcAQv+h/UpO8EVS+Vcleys9wEhPcIx56uUs6t7 2kzsDYJyee5B9ZGS3FcPrWeJOYxWxmmaAQO9PiVL8i6dLwjTfFd8OFyY0Xm5L/swuO Vv/gpu25cJEnA== Date: Fri, 3 Jan 2025 10:34:16 +0100 From: Niklas Cassel To: Pei Xiao Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH] PCI: dw-rockchip: remove redundant dev_err Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250103_013420_925490_89AA7583 X-CRM114-Status: GOOD ( 15.62 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Fri, Jan 03, 2025 at 03:04:52PM +0800, Pei Xiao wrote: > dev_err is redundant because platform_get_irq_byname() already prints an > error. > > cocci warnings: > drivers/pci/controller/dwc/pcie-dw-rockchip.c:454:2-9:line 454 is > redundant because platform_get_irq() already prints an error > > so remove redundant dev_err. > > Fixes: 8719dbc54668 ("PCI: dw-rockchip: Enumerate endpoints based on dll_link_up irq in the combined sys irq") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202412312343.najrW1Db-lkp@intel.com/ > Signed-off-by: Pei Xiao > --- > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > index ce4b511bff9b..a9795866e915 100644 > --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c > +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > @@ -458,10 +458,8 @@ static int rockchip_pcie_configure_rc(struct platform_device *pdev, > return -ENODEV; > > irq = platform_get_irq_byname(pdev, "sys"); > - if (irq < 0) { > - dev_err(dev, "missing sys IRQ resource\n"); > + if (irq < 0) > return irq; > - } > > ret = devm_request_threaded_irq(dev, irq, NULL, > rockchip_pcie_rc_sys_irq_thread, > @@ -504,10 +502,8 @@ static int rockchip_pcie_configure_ep(struct platform_device *pdev, > return -ENODEV; > > irq = platform_get_irq_byname(pdev, "sys"); > - if (irq < 0) { > - dev_err(dev, "missing sys IRQ resource\n"); > + if (irq < 0) > return irq; > - } > > ret = devm_request_threaded_irq(dev, irq, NULL, > rockchip_pcie_ep_sys_irq_thread, > -- > 2.25.1 > Reviewed-by: Niklas Cassel _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip