From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BF33C6FD1D for ; Mon, 20 Mar 2023 11:38:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ArY/T6TQpGlXOUp3fSLpCNL/oGY/lhaPdLBUowzaHU0=; b=MDsj5fFgRXyZNq R2s0kppA6U+B2SGzJr90L/kzsJhOr4HMFE1D35F3JgLqVJYZUpAWYIoPHqwAfPY3XRO7srsNJSaUi Vep4qbFmD1iKUcA+BiOXkk1/QbfwtR26VqJIAdB23ERAuSyOQgw/ioQlCs3/ROr3/Yrvt2YqISSao w/SdrunFudJz6s9pvGWu3A9uPD454ZVMSjH6FzCWBTOgX7TrvqU0miN8L4Zvw3yLpa+LpPCV+oxQw QISwApf+na3Vm7F8r8h2rVAshpBPhOILuMsgeK4oKxhnBRx/1BivmpMoQ+CJPyd7k2qWxsfuatbxe r1QEVSEULHwJtWFvbodQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1peDqa-008qF1-0S; Mon, 20 Mar 2023 11:38:40 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1peDqV-008qDg-1B; Mon, 20 Mar 2023 11:38:36 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DF99FB80E56; Mon, 20 Mar 2023 11:38:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 714C1C433EF; Mon, 20 Mar 2023 11:38:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679312311; bh=YfQJfApGvnHfGU8gi0gNukjaGzsg84xu5lWbeqt0lnw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Eb0R3e1JjZqoZgzBIBGjddsyzF5oRvdKqX4zJzfcsM0/DnTdJPwvylLD+N+LKBRzx IUP4xObd68HKq8F/Qvpt1W8+ib5Odyumu8IK77yOV7UrOlBps49shv9e9/SC/xo2kz m0aAW+ll4AWGsB8I2maII0LRP6fC/xl2FJLRDWSewz86h49su8evjRUcjYOvGhEqEP OqxjJPCWzSjGCbGJ72Q91R07MKL6mi3EU3EI8GH5XvBh3WyMEz82QnPL2OuhZKfQhY kOBto01PJnNfY6OWt0wG8oiBvRdeyp56uvftv10KL3GXZXlc50hUNdkT6jkk/wjKoa ZZVIoO4TNk3KQ== Date: Mon, 20 Mar 2023 17:08:27 +0530 From: Vinod Koul To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Kishon Vijay Abraham I , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Andre Przywara , Wolfram Sang , Icenowy Zheng , Justin Chen , Al Cooper , Pratyush Yadav , Rahul T R , Swapnil Jakhade , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Liu Ying , Yuan Can , Chun-Kuang Hu , Philipp Zabel , Chunfeng Yun , Matthias Brugger , Thomas Gleixner , Allison Randal , Greg Kroah-Hartman , Miaoqian Lin , Andy Gross , Bjorn Andersson , Yoshihiro Shimoda , Heiko Stuebner , Maxime Coquelin , Alexandre Torgue , Amelie Delaunay , Dan Carpenter , Fabrice Gasnier , JC Kuo , Thierry Reding , Jonathan Hunter , Roger Quadros , Matt Ranostay , Sinthu Raja , Vignesh Raghavendra , Tanmay Patil , Siddharth Vadapalli , Lv Ruyi , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@pengutronix.de, Broadcom internal kernel review list , Fabio Estevam , NXP Linux Team , AngeloGioacchino Del Regno , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org Subject: Re: [PATCH 00/31] phy: Convert to platform remove callback returning void Message-ID: References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230320_043835_704856_23512E0B X-CRM114-Status: GOOD ( 16.48 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 07-03-23, 12:58, Uwe Kleine-K=F6nig wrote: > Hello, > = > this patch series adapts the platform drivers below drivers/phy to use the > .remove_new() callback. Compared to the traditional .remove() callback > .remove_new() returns no value. This is a good thing because the driver c= ore > doesn't (and cannot) cope for errors during remove. The only effect of a > non-zero return value in .remove() is that the driver core emits a warnin= g. The > device is removed anyhow and an early return from .remove() usually yield= s a > resource leak. > = > By changing the remove callback to return void driver authors cannot > reasonably assume any more that there is some kind of cleanup later. > = > All drivers in drivers/spmi returned zero unconditionally in their remove > callback, so they could all be converted trivially to .remove_new(). > = > Note that this series depends on commit 5c5a7680e67b ("platform: Provide > a remove callback that returns no value") which is included in v6.3-rc1. Applied, thanks -- = ~Vinod _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip