Re: [PATCH v2 22/23] soc: xilinx: Explicitly include correct DT includes

Michal Simek
2023-08-04T06:52:13Z

Hi Rob,

On 8/4/23 00:43, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> drivers/soc/xilinx/zynqmp_power.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c
> index 641dcc958911..913417506468 100644
> --- a/drivers/soc/xilinx/zynqmp_power.c
> +++ b/drivers/soc/xilinx/zynqmp_power.c
> @@ -11,6 +11,7 @@
>
> #include <linux/mailbox_client.h>
> #include <linux/module.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/reboot.h>
> #include <linux/suspend.h>
>

I was checking and I was on CC on the v1 but I didn't get this to my inbox.
Anyway let me apply this to my queue.

Arnd: If you want to take it directly I am fine with it too.

Thanks,
Michal