From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E2DCC4167B for ; Thu, 30 Nov 2023 09:47:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bV9B5tqLA8lHG2/viiAP7Gb9v9GvwhCkDCdiaMqNcfs=; b=bWeQNtyt0H6bzc hKJFYNl7772npo4uzxT6AzNzKFRk9cwvdbi68lcELxquQeyMPWRIGoVxZG1OA2mPLjJ6zkV7ZfSpA s0EpbYC7bXYMX6kC8sCHkCaF1rDlXCYHvJlO49y3tnwYovdiBV/uTmw3crprxX84lyKLC98qH6KX2 j9tH+XVIbdUj4b/rTKbSy5fi3JYxnqEK4EHhKo/3tg9z7OvmSjFdh7hSo0nV8vS5OgApBClfoF0xF eAYR+cJv+NNSDNRWXn/7Ec1K1diyloCo7Fz4PAPdINS1JOCYadFWbONXixonqwtE+t7MRY0fPM0I+ n9AaS2VXJzRjC1r4iw9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8ddb-00AM3m-0u; Thu, 30 Nov 2023 09:47:15 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8ddY-00AM3B-0c; Thu, 30 Nov 2023 09:47:13 +0000 Received: from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp [175.177.49.156]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 38D768C1; Thu, 30 Nov 2023 10:46:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1701337593; bh=A+ZecSE4hjPnaI3Hh8yXuuX/lFO1rYZCXT1nhjdZtw8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SwfEEZ7SpVU/OdE+/rfMspmM71hg225W3lQ8u4HuQL39vM0NYE9zqAUquXppYJ1be NY+hif7gIyqf+RhFCLYNnztvFeWmifdDfk4e/FH1t+ghvgkntskwB56Ce1ahGV9PxW heNlfR1N9ctz0WpO6qAZoYifdZJgc1k87IxCr3QI= Date: Thu, 30 Nov 2023 18:47:00 +0900 From: Paul Elder To: Kieran Bingham Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, Dafna Hirschfeld , Laurent Pinchart , Mauro Carvalho Chehab , Heiko Stuebner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] media: rkisp1: debug: Add register dump for IS Message-ID: References: <20231129092956.250129-1-paul.elder@ideasonboard.com> <20231129092956.250129-3-paul.elder@ideasonboard.com> <170128834260.3048548.11979514587961676400@ping.linuxembedded.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <170128834260.3048548.11979514587961676400@ping.linuxembedded.co.uk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231130_014712_374436_09C46D5C X-CRM114-Status: GOOD ( 21.59 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Wed, Nov 29, 2023 at 08:05:42PM +0000, Kieran Bingham wrote: > Quoting Paul Elder (2023-11-29 09:29:55) > > Add register dump for the image stabilizer module to debugfs. > > > > Is the Image Stabilizer on all variants of the ISP? > > I.e. is it valid register space on the RK3399 implementation? Yes, it is. > > If so then: > Reviewed-by: Kieran Bingham > > > Signed-off-by: Paul Elder > > --- > > .../platform/rockchip/rkisp1/rkisp1-debug.c | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c > > index 71df3dc95e6f..f66b9754472e 100644 > > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c > > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c > > @@ -139,6 +139,21 @@ static int rkisp1_debug_dump_mi_mp_show(struct seq_file *m, void *p) > > } > > DEFINE_SHOW_ATTRIBUTE(rkisp1_debug_dump_mi_mp); > > > > +static int rkisp1_debug_dump_is_show(struct seq_file *m, void *p) > > +{ > > + static const struct rkisp1_debug_register registers[] = { > > + RKISP1_DEBUG_SHD_REG(ISP_IS_H_OFFS), > > + RKISP1_DEBUG_SHD_REG(ISP_IS_V_OFFS), > > + RKISP1_DEBUG_SHD_REG(ISP_IS_H_SIZE), > > + RKISP1_DEBUG_SHD_REG(ISP_IS_V_SIZE), > > I expect so as you haven't added the register macros in this series so > they must already be there ... Yep :) Paul > > > > + { /* Sentinel */ }, > > + }; > > + struct rkisp1_device *rkisp1 = m->private; > > + > > + return rkisp1_debug_dump_regs(rkisp1, m, 0, registers); > > +} > > +DEFINE_SHOW_ATTRIBUTE(rkisp1_debug_dump_is); > > + > > #define RKISP1_DEBUG_DATA_COUNT_BINS 32 > > #define RKISP1_DEBUG_DATA_COUNT_STEP (4096 / RKISP1_DEBUG_DATA_COUNT_BINS) > > > > @@ -235,6 +250,9 @@ void rkisp1_debug_init(struct rkisp1_device *rkisp1) > > > > debugfs_create_file("mi_mp", 0444, regs_dir, rkisp1, > > &rkisp1_debug_dump_mi_mp_fops); > > + > > + debugfs_create_file("is", 0444, regs_dir, rkisp1, > > + &rkisp1_debug_dump_is_fops); > > } > > > > void rkisp1_debug_cleanup(struct rkisp1_device *rkisp1) > > -- > > 2.39.2 > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip