From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BF97C54E67 for ; Wed, 27 Mar 2024 12:40:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mIPpIfmosRukgEDLVwNvRVfvNIeN3lmHpmvka2oXKV0=; b=qBZp5ZiraTSQ01SYw5Qbac1C+8 +hpIAF4wy4pgqETl2hbgm7YP7qK7/X2EpnMLigmxZO/IrfRPuyCduaL1PzQ8Wb54wtaFboPlPosaP y4nEACI95lwkqxI1fjN6LA5F8fvtqiBSgP35XCp1Oguuu3bliwOF1sveeBANpUcuAH5foxpfIyF43 pbOFaNIA2tfeg4w3fHlPFsG6ZWbRlDcTzqr/WReQNV8JbHj7jP+MAtkp3YWcJiQJ1qfUfh7KnPW0G 3tLBS5PRjW9zYf+0zn4qaLrbnwENLjKUV3MWkLclQuypst2DLYGqLgNWOR60D/RAIj4WzTnEsKvQg xABTjWBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpSZv-00000008wKi-0fjo; Wed, 27 Mar 2024 12:40:27 +0000 Received: from luna.linkmauve.fr ([82.65.109.163]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpSZp-00000008wGZ-2ETw; Wed, 27 Mar 2024 12:40:23 +0000 Received: by luna.linkmauve.fr (Postfix, from userid 1000) id F19C3101A8A5; Wed, 27 Mar 2024 13:40:15 +0100 (CET) Date: Wed, 27 Mar 2024 13:40:15 +0100 From: Link Mauve To: Krzysztof Kozlowski Cc: Emmanuel Gil Peyrot , linux-kernel@vger.kernel.org, Ezequiel Garcia , Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Joerg Roedel , Will Deacon , Robin Murphy , Sebastian Reichel , Cristian Ciocaltea , Dragan Simic , Shreeya Patel , Chris Morgan , Andy Yan , Nicolas Frattaroli , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev Subject: Re: [PATCH 3/4] arm64: dts: rockchip: Add VEPU121 to rk3588 Message-ID: References: <20240320173736.2720778-1-linkmauve@linkmauve.fr> <20240320173736.2720778-4-linkmauve@linkmauve.fr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="vIGEYjDZeTRTEtgU" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Jabber-ID: linkmauve@linkmauve.fr X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240327_054021_893029_A9CBA9C7 X-CRM114-Status: GOOD ( 20.70 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org --vIGEYjDZeTRTEtgU Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Thu, Mar 21, 2024 at 09:15:38AM +0100, Krzysztof Kozlowski wrote: > On 20/03/2024 18:37, Emmanuel Gil Peyrot wrote: > > The TRM (version 1.0 page 385) lists five VEPU121 cores, but only four > > interrupts are listed (on page 24), so I’ve only enabled four of them > > for now. > > > > Signed-off-by: Emmanuel Gil Peyrot > > --- > > arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 80 +++++++++++++++++++++++ > > 1 file changed, 80 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > > index 2a23b4dc36e4..fe77b56ac9a0 100644 > > --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > > @@ -2488,6 +2488,86 @@ gpio4: gpio@fec50000 { > > }; > > }; > > > > + jpeg_enc0: video-codec@fdba0000 { > > + compatible = "rockchip,rk3588-vepu121"; > > + reg = <0x0 0xfdba0000 0x0 0x800>; > > + interrupts = ; > > + clocks = <&cru ACLK_JPEG_ENCODER0>, <&cru HCLK_JPEG_ENCODER0>; > > + clock-names = "aclk", "hclk"; > > + iommus = <&jpeg_enc0_mmu>; > > + power-domains = <&power RK3588_PD_VDPU>; > > + }; > > + > > + jpeg_enc0_mmu: iommu@fdba0800 { > > + compatible = "rockchip,rk3588-iommu"; > > It does not look like you tested the DTS against bindings. Please run > `make dtbs_check W=1` (see > Documentation/devicetree/bindings/writing-schema.rst or > https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ > for instructions). Even on master I get an exception about this unresolvable file: referencing.exceptions.Unresolvable: cache-controller.yaml# Yet it seems to be present in only three files, all of them unrelated to the rockchip board I’m interested in (it seems), so I’m not sure what to do about that. The full stack trace is attached. > > Best regards, > Krzysztof > -- Link Mauve --vIGEYjDZeTRTEtgU Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="CHECK_DTBS=y W=1" % make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y W=1 rockchip/rk3588-rock-5b.dtb make[1]: Entering directory '/home/linkmauve/dev/linux' DTC_CHK arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb Traceback (most recent call last): File "/usr/lib/python3.11/site-packages/referencing/_core.py", line 417, in get_or_retrieve resource = registry._retrieve(uri) ^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/site-packages/jsonschema/validators.py", line 111, in _warn_for_remote_retrieve request = Request(uri, headers=headers) # noqa: S310 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/urllib/request.py", line 322, in __init__ self.full_url = url ^^^^^^^^^^^^^ File "/usr/lib/python3.11/urllib/request.py", line 348, in full_url self._parse() File "/usr/lib/python3.11/urllib/request.py", line 377, in _parse raise ValueError("unknown url type: %r" % self.full_url) ValueError: unknown url type: 'cache-controller.yaml' The above exception was the direct cause of the following exception: Traceback (most recent call last): File "/usr/lib/python3.11/site-packages/referencing/_core.py", line 667, in lookup retrieved = self._registry.get_or_retrieve(uri) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/site-packages/referencing/_core.py", line 424, in get_or_retrieve raise exceptions.Unretrievable(ref=uri) from error referencing.exceptions.Unretrievable: 'cache-controller.yaml' The above exception was the direct cause of the following exception: Traceback (most recent call last): File "/usr/bin/dt-validate", line 8, in sys.exit(main()) ^^^^^^ File "/usr/lib/python3.11/site-packages/dtschema/dtb_validate.py", line 144, in main sg.check_dtb(filename) File "/usr/lib/python3.11/site-packages/dtschema/dtb_validate.py", line 89, in check_dtb self.check_subtree(dt, subtree, False, "/", "/", filename) File "/usr/lib/python3.11/site-packages/dtschema/dtb_validate.py", line 82, in check_subtree self.check_subtree(tree, value, disabled, name, fullname + name, filename) File "/usr/lib/python3.11/site-packages/dtschema/dtb_validate.py", line 82, in check_subtree self.check_subtree(tree, value, disabled, name, fullname + name, filename) File "/usr/lib/python3.11/site-packages/dtschema/dtb_validate.py", line 77, in check_subtree self.check_node(tree, subtree, disabled, nodename, fullname, filename) File "/usr/lib/python3.11/site-packages/dtschema/dtb_validate.py", line 33, in check_node for error in self.validator.iter_errors(node, filter=match_schema_file): File "/usr/lib/python3.11/site-packages/dtschema/validator.py", line 413, in iter_errors for error in self.DtValidator(sch, File "/usr/lib/python3.11/site-packages/jsonschema/validators.py", line 371, in iter_errors for error in errors: File "/usr/lib/python3.11/site-packages/jsonschema/_keywords.py", line 386, in if_ yield from validator.descend(instance, then, schema_path="then") File "/usr/lib/python3.11/site-packages/jsonschema/validators.py", line 419, in descend for error in errors: File "/usr/lib/python3.11/site-packages/jsonschema/_legacy_keywords.py", line 423, in unevaluatedProperties_draft2019 evaluated_keys = find_evaluated_property_keys_by_schema( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/site-packages/jsonschema/_legacy_keywords.py", line 399, in find_evaluated_property_keys_by_schema evaluated_keys += find_evaluated_property_keys_by_schema( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/site-packages/jsonschema/_legacy_keywords.py", line 342, in find_evaluated_property_keys_by_schema resolved = validator._resolver.lookup(ref) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.11/site-packages/referencing/_core.py", line 671, in lookup raise exceptions.Unresolvable(ref=ref) from error referencing.exceptions.Unresolvable: cache-controller.yaml# make[1]: Leaving directory '/home/linkmauve/dev/linux' --vIGEYjDZeTRTEtgU Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip --vIGEYjDZeTRTEtgU--