From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 817CCC4345F for ; Mon, 22 Apr 2024 12:35:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=acpWzVFec/fwokRcc8s1sXXdVv3KfcS6T9W963vtmnM=; b=g6mlG2czLf7yHB v3Fua2mXzW5IHgHcx8M2NjhMjP/Gi8cfO/fWp/7DmhmfLGj2eJZannMp409YPyZ/CqTq3a93EQdPC Rfw9m9/KVkc8XNhtxCAiSAKv2ZWO8wD/Hj0Czat+dea1zCsJUYJSFGM4ohafO/YeHI1r5aaIi4Oyz Ww5ABoIjtPHw2+ZFK3xx3Ic/xbvAex1Fmm7SaUF3cdtTPjQAK7UKo8wmupP5wHZFsSbWOJWesvNRK 648pNVi2aAC+7IvCKQlnr1nQGrgARI1aU7hc6EdJe54o9Xre+g19rlB/VFUJCZpgTgJUzij4js7Tq oHBOU+30toCTOkSbgYuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryst6-0000000DVrb-0lqx; Mon, 22 Apr 2024 12:35:12 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ryst2-0000000DVqZ-3KCF for linux-rockchip@lists.infradead.org; Mon, 22 Apr 2024 12:35:10 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ryssp-0005Bq-G4; Mon, 22 Apr 2024 14:34:55 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ryssl-00Dh4a-6t; Mon, 22 Apr 2024 14:34:51 +0200 Received: from sha by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1ryssl-0088Ib-0N; Mon, 22 Apr 2024 14:34:51 +0200 Date: Mon, 22 Apr 2024 14:34:51 +0200 From: Sascha Hauer To: Andy Yan Cc: heiko@sntech.de, tzimmermann@suse.de, mripard@kernel.org, hjc@rock-chips.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Andy Yan Subject: Re: [PATCH 1/1] drm/rockchip: vop2: Fix the port mux of VP2 Message-ID: References: <20240422101905.32703-1-andyshrk@163.com> <20240422101905.32703-2-andyshrk@163.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240422101905.32703-2-andyshrk@163.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240422_053508_842567_520D7D40 X-CRM114-Status: GOOD ( 20.50 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Mon, Apr 22, 2024 at 06:19:05PM +0800, Andy Yan wrote: > From: Andy Yan > > The port mux of VP2 should be RK3568_OVL_PORT_SET__PORT2_MUX. > > Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") > Signed-off-by: Andy Yan Acked-by: Sascha Hauer Sascha > > --- > > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > index 97b0ab4b6db8..1f4250de570f 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > @@ -2377,7 +2377,7 @@ static void vop2_setup_layer_mixer(struct vop2_video_port *vp) > port_sel |= FIELD_PREP(RK3568_OVL_PORT_SET__PORT2_MUX, > (vp2->nlayers + vp1->nlayers + vp0->nlayers - 1)); > else > - port_sel |= FIELD_PREP(RK3568_OVL_PORT_SET__PORT1_MUX, 8); > + port_sel |= FIELD_PREP(RK3568_OVL_PORT_SET__PORT2_MUX, 8); > > layer_sel = vop2_readl(vop2, RK3568_OVL_LAYER_SEL); > > -- > 2.34.1 > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip