From: Robin Murphy <robin.murphy@arm.com>
To: Ezequiel Garcia <ezequiel@collabora.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org
Cc: Rob Herring <robh+dt@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Philipp Zabel <p.zabel@pengutronix.de>,
Heiko Stuebner <heiko@sntech.de>, Alex Bee <knaerzche@gmail.com>,
maccraft123mc@gmail.com, Chris Healy <cphealy@gmail.com>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Jonas Karlman <jonas@kwiboo.se>,
Kever Yang <kever.yang@rock-chips.com>,
kernel@collabora.com
Subject: Re: [PATCH v3 10/10] arm64: dts: rockchip: Add VPU support for the PX30
Date: Tue, 20 Jul 2021 10:11:17 +0100 [thread overview]
Message-ID: <a3078b49-696a-1aa6-8f96-70573bd6441d@arm.com> (raw)
In-Reply-To: <20210719205242.18807-11-ezequiel@collabora.com>
On 2021-07-19 21:52, Ezequiel Garcia wrote:
> From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
>
> The PX30 has a VPU (both decoder and encoder) with a dedicated IOMMU.
> Describe these two entities in device-tree.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> ---
> arch/arm64/boot/dts/rockchip/px30.dtsi | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi
> index 248ebb61aa79..05ce8ce5e4be 100644
> --- a/arch/arm64/boot/dts/rockchip/px30.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi
> @@ -1024,6 +1024,29 @@ gpu: gpu@ff400000 {
> status = "disabled";
> };
>
> + vpu: video-codec@ff442000 {
> + compatible = "rockchip,px30-vpu";
> + reg = <0x0 0xff442000 0x0 0x800>;
> + interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 79 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "vepu", "vdpu";
> + clocks = <&cru ACLK_VPU>, <&cru HCLK_VPU>;
> + clock-names = "aclk", "hclk";
> + iommus = <&vpu_mmu>;
> + power-domains = <&power PX30_PD_VPU>;
> + };
> +
> + vpu_mmu: iommu@ff442800 {
> + compatible = "rockchip,iommu";
> + reg = <0x0 0xff442800 0x0 0x100>;
> + interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "vpu_mmu";
Nit: "interrupt-names" is not part of the IOMMU binding. Same for the
RK3568 patch too ;)
Robin.
> + clocks = <&cru ACLK_VPU>, <&cru HCLK_VPU>;
> + clock-names = "aclk", "iface";
> + #iommu-cells = <0>;
> + power-domains = <&power PX30_PD_VPU>;
> + };
> +
> dsi: dsi@ff450000 {
> compatible = "rockchip,px30-mipi-dsi";
> reg = <0x0 0xff450000 0x0 0x10000>;
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
prev parent reply other threads:[~2021-07-20 9:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 20:52 [PATCH v3 00/10] hantro: Enable H.264 VDPU2 Ezequiel Garcia
2021-07-19 20:52 ` [PATCH v3 01/10] hantro: vp8: Move noisy WARN_ON to vpu_debug Ezequiel Garcia
2021-07-19 20:52 ` [PATCH v3 02/10] hantro: Make struct hantro_variant.init() optional Ezequiel Garcia
2021-07-19 20:52 ` [PATCH v3 03/10] media: hantro: Avoid redundant hantro_get_{dst, src}_buf() calls Ezequiel Garcia
2021-07-19 20:52 ` [PATCH v3 04/10] media: hantro: h264: Move DPB valid and long-term bitmaps Ezequiel Garcia
2021-07-19 20:52 ` [PATCH v3 05/10] media: hantro: h264: Move reference picture number to a helper Ezequiel Garcia
2021-07-19 20:52 ` [PATCH v3 06/10] media: hantro: Add H.264 support for Rockchip VDPU2 Ezequiel Garcia
2021-07-19 20:52 ` [PATCH v3 07/10] media: hantro: Enable H.264 on " Ezequiel Garcia
2021-10-14 18:17 ` [BUG] " Nicolas Dufresne
2021-10-16 18:22 ` Alex Bee
2021-07-19 20:52 ` [PATCH v3 08/10] media: hantro: Add support for the Rockchip PX30 Ezequiel Garcia
2021-07-19 20:52 ` [PATCH v3 09/10] dt-bindings: media: rockchip-vpu: Add PX30 compatible Ezequiel Garcia
2021-07-19 20:52 ` [PATCH v3 10/10] arm64: dts: rockchip: Add VPU support for the PX30 Ezequiel Garcia
2021-07-20 9:11 ` Robin Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3078b49-696a-1aa6-8f96-70573bd6441d@arm.com \
--to=robin.murphy@arm.com \
--cc=cphealy@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=hverkuil@xs4all.nl \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=kever.yang@rock-chips.com \
--cc=knaerzche@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maccraft123mc@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=paul.kocialkowski@bootlin.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox