Linux-Rockchip Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
	Michael Turquette <mturquette@baylibre.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Elaine Zhang <zhangqing@rock-chips.com>,
	YouMin Chen <cym@rock-chips.com>,
	Detlev Casanova <detlev.casanova@collabora.com>,
	Sugar Zhang <sugar.zhang@rock-chips.com>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: rockchip: remove unused mclk_pdm0_p/pdm0_p definitions
Date: Mon, 09 Sep 2024 14:10:35 -0700	[thread overview]
Message-ID: <a487389540a0dd6c981257b4939c001a.sboyd@kernel.org> (raw)
In-Reply-To: <20240909121116.254036-1-arnd@kernel.org>

Quoting Arnd Bergmann (2024-09-09 05:11:05)
> From: Arnd Bergmann <arnd@arndb.de>
> 
> When -Wunused-const-variable is enabled (not the default),
> there is a warning about two definitions in this file:
> 
> In file included from drivers/clk/rockchip/clk-rk3576.c:14:
> drivers/clk/rockchip/clk-rk3576.c:334:7: error: 'mclk_pdm0_p' defined but not used [-Werror=unused-const-variable=]
>   334 | PNAME(mclk_pdm0_p)                      = { "mclk_pdm0_src_top", "xin24m" };
>       |       ^~~~~~~~~~~
> drivers/clk/rockchip/clk.h:564:43: note: in definition of macro 'PNAME'
>   564 | #define PNAME(x) static const char *const x[] __initconst
>       |                                           ^
> drivers/clk/rockchip/clk-rk3576.c:333:7: error: 'pdm0_p' defined but not used [-Werror=unused-const-variable=]
>   333 | PNAME(pdm0_p)                           = { "clk_pdm0_src_top", "xin24m" };
>       |       ^~~~~~
> drivers/clk/rockchip/clk.h:564:43: note: in definition of macro 'PNAME'
>   564 | #define PNAME(x) static const char *const x[] __initconst
>       |                                           ^
> 
> Remove them for the moment. If they are needed later, they can
> be added back at that point.
> 
> Fixes: cc40f5baa91b ("clk: rockchip: Add clock controller for the RK3576")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Applied to clk-next

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

      reply	other threads:[~2024-09-09 21:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-09 12:11 [PATCH] clk: rockchip: remove unused mclk_pdm0_p/pdm0_p definitions Arnd Bergmann
2024-09-09 21:10 ` Stephen Boyd [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a487389540a0dd6c981257b4939c001a.sboyd@kernel.org \
    --to=sboyd@kernel.org \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=cym@rock-chips.com \
    --cc=detlev.casanova@collabora.com \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=sugar.zhang@rock-chips.com \
    --cc=zhangqing@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox