From mboxrd@z Thu Jan 1 00:00:00 1970 From: Soeren Moch Subject: Re: [PATCH 0/4] mfd: RK8xx tidyup Date: Tue, 17 Dec 2019 01:31:44 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org To: Robin Murphy , lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, heiko@sntech.de, linux.amoon@gmail.com, linux-rockchip@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org On 10.12.19 14:24, Robin Murphy wrote: > Hi all, > > In trying to debug suspend issues on my RK3328 box, I was looking at > how the RK8xx driver handles the RK805 sleep pin, and frankly the whole > driver seemed untidy enough to warrant some cleanup and minor fixes > before going any further. I've based the series on top of Soeren's > "mfd: rk808: Always use poweroff when requested" patch[1]. > > Note that I've only had time to build-test these patches so far, but I > wanted to share them early for the sake of discussion in response to > the other thread[2]. > > Robin. > > [1] https://patchwork.kernel.org/patch/11279249/ > [2] https://patchwork.kernel.org/cover/11276945/ > > Robin Murphy (4): > mfd: rk808: Set global instance unconditionally > mfd: rk808: Always register syscore ops > mfd: rk808: Reduce shutdown duplication > mfd: rk808: Convert RK805 to syscore/PM ops > > drivers/mfd/rk808.c | 122 ++++++++++++++++---------------------- > include/linux/mfd/rk808.h | 2 - > 2 files changed, 50 insertions(+), 74 deletions(-) > The whole series, on top of [1]: Tested on RockPro64 board with RK808 PMIC. Tested-by: Soeren Moch Regards, Soeren