From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Peter Geis <pgwipeout@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
PCI <linux-pci@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
arm-mail-list <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 3/4] arm64: dts: rockchip: add rk3568 pcie2x1 controller
Date: Mon, 18 Apr 2022 01:23:28 +0300 [thread overview]
Message-ID: <a8bb3ef6-8f37-709f-adfe-3608e5c1e11f@collabora.com> (raw)
In-Reply-To: <CAMdYzYq=nQhwY_4+Y=PM9do_Dcrg1pD-jeD=q36D48ks=WDVgw@mail.gmail.com>
On 4/16/22 13:17, Peter Geis wrote:
> On Sat, Apr 16, 2022 at 6:08 AM Dmitry Osipenko
> <dmitry.osipenko@collabora.com> wrote:
>>
>> Hi Peter,
>>
>> On 4/16/22 13:05, Peter Geis wrote:
>>> + pcie2x1: pcie@fe260000 {
>>> + compatible = "rockchip,rk3568-pcie";
>>> + #address-cells = <3>;
>>> + #size-cells = <2>;
>>> + bus-range = <0x0 0xf>;
>>> + assigned-clocks = <&cru ACLK_PCIE20_MST>, <&cru ACLK_PCIE20_SLV>,
>>> + <&cru ACLK_PCIE20_DBI>, <&cru PCLK_PCIE20>,
>>> + <&cru CLK_PCIE20_AUX_NDFT>;
>>
>> Why these assigned-clocks are needed? I don't see anything assigned in
>> this patchset.
>
> Ah, those are remnants of early bringup when performance wasn't good
> and I was manually setting clock rates.
If it's not needed, should it be removed then? Otherwise it looks like
something is missing in the DT in regards to the assigned clocks.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2022-04-17 22:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-16 10:04 [PATCH v6 0/4] Enable rk356x PCIe controller Peter Geis
2022-04-16 10:04 ` [PATCH v6 1/4] dt-bindings: pci: remove fallback from Rockchip DesignWare binding Peter Geis
2022-04-16 10:05 ` [PATCH v6 2/4] PCI: dwc: rockchip: add legacy interrupt support Peter Geis
2022-04-16 10:05 ` [PATCH v6 3/4] arm64: dts: rockchip: add rk3568 pcie2x1 controller Peter Geis
2022-04-16 10:08 ` Dmitry Osipenko
2022-04-16 10:17 ` Peter Geis
2022-04-17 22:23 ` Dmitry Osipenko [this message]
2022-04-18 11:45 ` Peter Geis
2022-04-16 10:05 ` [PATCH v6 4/4] arm64: dts: rockchip: enable pcie controller on quartz64-a Peter Geis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8bb3ef6-8f37-709f-adfe-3608e5c1e11f@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox