Re: [PATCH 2/9] pmdomain: rockchip: Add support for RK3528

From: Yao Zi <ziyao@disroot.org>
To: "Heiko Stübner" <heiko@sntech.de>,
	"Jonas Karlman" <jonas@kwiboo.se>,
	"Ulf Hansson" <ulf.hansson@linaro.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Chukun Pan <amadeus@jmu.edu.cn>,
	linux-rockchip@lists.infradead.org, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/9] pmdomain: rockchip: Add support for RK3528
Date: Mon, 19 May 2025 17:11:32 +0000	[thread overview]
Message-ID: <aCtmREp_H6_K00jR@pie.lan> (raw)
In-Reply-To: <3416319.KgjxqYA5nG@diego>

On Mon, May 19, 2025 at 07:07:39PM +0200, Heiko Stübner wrote:
> Hi,
> 
> Am Montag, 19. Mai 2025, 18:52:04 Mitteleuropäische Sommerzeit schrieb Yao Zi:
> > On Sun, May 18, 2025 at 10:06:49PM +0000, Jonas Karlman wrote:
> > > Add configuration and power domains for RK3528 SoC.
> > > 
> > > Only PD_GPU can fully be powered down. PD_RKVDEC, PD_RKVENC, PD_VO and
> > > PD_VPU are used by miscellaneous devices in RK3528.
> > 
> > Thanks for your work!
> > 
> > > Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> > > ---
> > >  drivers/pmdomain/rockchip/pm-domains.c | 27 ++++++++++++++++++++++++++
> > >  1 file changed, 27 insertions(+)
> > > 
> > > diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/rockchip/pm-domains.c
> > > index 4cce407bb1eb..242570c505fb 100644
> > > --- a/drivers/pmdomain/rockchip/pm-domains.c
> > > +++ b/drivers/pmdomain/rockchip/pm-domains.c
> > > @@ -35,6 +35,7 @@
> > >  #include <dt-bindings/power/rk3366-power.h>
> > >  #include <dt-bindings/power/rk3368-power.h>
> > >  #include <dt-bindings/power/rk3399-power.h>
> > > +#include <dt-bindings/power/rockchip,rk3528-power.h>
> > >  #include <dt-bindings/power/rockchip,rk3562-power.h>
> > 
> > But I had some trouble applying this patch on either Rockchip SoC tree
> > or linux-pm. Looking through the context, seems the patch depends on
> > some RK3562 PMU driver changes, which I couldn't find with some brief
> > searching among the list.
> > 
> > Which branch is the series based on?
> 
> are you sure you looked at the right linux-pm tree?
> 
> In [0] I do see rk3562 powerdomains applied.

Oops, thanks for the link! I was digging through rafael/linux-pm.git
actually...

> Heiko
> 
> 
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/ulfh/linux-pm.git/commit/?h=next&id=f89c082d44914f24dfb5b0219eb140369de5b612
> 
> 

Best regards,
Yao Zi

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip