From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FEC0CAC599 for ; Tue, 16 Sep 2025 08:48:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+IHXQ/xMCsw9xO4xwTcKbtvB3kVoBg4LozTsfkUz0SQ=; b=xHNhx/XbHQMFlL ODnLX9K+QWhfW3Z37l9lFDH2xwtzG5D/JutLkMTmPhXYhhy2txdIfTJ6wV/Y1leIpWQaRyZJiLWNf IFWUH5wm8bX3eiryHJe9ZT5xK6awPEu4zdzhoyNCHRu9hRFIROvPiAG1OK0vNFyIiirLGDYnQPqhX NJFldiL9HwdIhlF3Yx33A3RUFH7z/wNix9eTWzFPILwtgSes7z2qS1J8TfBHme2kPbjrFox7VSpIu CQJAzsqGB4JtzIyJbFHuqVI7FO2qXxQnMPUxnJrWV5tA1+64P8cSvPtwnomWmQ2sNBdao26jPL0N4 T4qWtz3g/BB7o17uJFlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uyRMh-00000007Fr9-3MXs; Tue, 16 Sep 2025 08:48:43 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uyRMe-00000007FqP-31d1; Tue, 16 Sep 2025 08:48:42 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 00B9F44C2A; Tue, 16 Sep 2025 08:48:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A88BFC4CEEB; Tue, 16 Sep 2025 08:48:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1758012519; bh=gBC89acRt2ZWThI6GiBXUA4qAUTNm8vCd8qyDvzjiZE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m7LdLz0vXRu1QDRO3ZuQvA3+jqh3JxhTQHX8IW4VHNOE6jLAJTC8Gk87eluIh4jMT bli4cXARt8ZQ6n6iqCiYQqtVy69DTegtOxc8LKakwQKUEqA2ZHBE2k+mYufiJ3o/h7 qesqNhorL9QrNX78rRFFprSYoXlFml9tgAj1rkmlm6pyvZupIiXfDuOty7eTB9qDqo CouLVJhpNf8Pm+Q7rzYldmyitAeHqbukysVTR/mjP/u05hEnXKBbZCt/KRGpHXsHfJ +n8uUiWSVq10XIvunL3dTV/12Q4aEpBQsfBiiIxiFvqrecpRpSlZT0oZuc1Pk+VoTO +1DIAmhw7/dug== Date: Tue, 16 Sep 2025 09:48:33 +0100 From: Will Deacon To: Jason Gunthorpe Cc: =?iso-8859-1?Q?J=F6rg_R=F6del?= , Nicolas Dufresne , Benjamin Gaignard , robin.murphy@arm.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de, p.zabel@pengutronix.de, mchehab@kernel.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@collabora.com, linux-media@vger.kernel.org Subject: Re: [PATCH v9 3/7] iommu: Add verisilicon IOMMU driver Message-ID: References: <20250911155720.180465-1-benjamin.gaignard@collabora.com> <20250911155720.180465-4-benjamin.gaignard@collabora.com> <694b9ba15cd67f41a38f4a65a3811f035cf8e99d.camel@collabora.com> <20250915225806.GM882933@ziepe.ca> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250915225806.GM882933@ziepe.ca> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250916_014840_802841_C7D9D6B0 X-CRM114-Status: GOOD ( 24.75 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Mon, Sep 15, 2025 at 07:58:06PM -0300, Jason Gunthorpe wrote: > On Sat, Sep 13, 2025 at 07:58:04AM +0200, J=F6rg R=F6del wrote: > > [Adding Will back to Cc] > > = > > On Fri, Sep 12, 2025 at 01:37:11PM -0400, Nicolas Dufresne wrote: > > > To me this rejection isn't about Benjamin's driver, all iommu seems t= o look > > > alike, so anyone else that would have sent new driver would have face= the same > > > issue. > > = > > This is about ignoring comments from one of the IOMMU maintainers. I am= not > > going to merge a driver with open comments/objections[1] from Will (and= a few > > others), so resolve this with him and get his Ack. > = > I would strongly object to trying to share map_pages, unmap_pages, > iova_to_phys, free and other iommu pt related functions in some > limited way instead of helping on the much more complete iommu pt > work. Which is what I said to Will, but for some reason he suggested > it anyhow. If the answer is to convert this to iommu pt, then so be it. My understanding was that was still premature at this stage but you know better than me. When I bothered to look at this driver side-by-side with the rockchip driver which, despite apparently being totally different IP (honest!), is *remarkably* similar, I summarised the similarity in the default domain ops: https://lore.kernel.org/all/aH5yR9CkYSJ4PaZV@willie-the-truck/ But rather than respond to that, Benjamin just sent a new version. I was hoping for a bit more discussion... > Sorry, but it doesn't make sense to complain about duplication in > drivers and then not help advance one of the biggest projects to > actually concretely and comprehensively address that duplication. I don't think it needs to be one or the other. afaict, these drivers should share the default domain ops and if the page-table code is using iommu-pt then that's even better. Will _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip