From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 118DBCCFA03 for ; Fri, 31 Oct 2025 13:58:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UQ7bGv5ARaTBz2fcDFi2sXsbyPk0HEeWPj5lyyFoQLg=; b=edCC5VXmfWuA3a 3ZQnxmswUOcI0G3ID28zM6tIRy162kh20MmuiQxi4Przj6CpgOSsgBHEVy4V3KCUr47zxsx7JdXa5 WcCdojbtaDoSiN247yb0iKO7wZJGi9112aYqjh+aR/JIQd019Xaaedo+1U9MPZpCNEBB1FQyD9UIO AIqcSgNNuJmYoQ5ebcNrJa2ImXr+lb2NuYRgmFaSPWiRLS9GoL6NIekSpTzJg7gdyS8BwNapl+bsk LK3e1/0Bq0ybbwx9RUVZFrosbByDnztp/+ojmvf7bQaGK3Y92fkz74UlplmTxlTtmqejP6akb1G61 uVAABOtS9dV5sQtqSmvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vEpeG-00000006BuD-1Aci; Fri, 31 Oct 2025 13:58:36 +0000 Received: from mgamail.intel.com ([192.198.163.18]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vEpeC-00000006Bt9-3YPZ; Fri, 31 Oct 2025 13:58:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1761919112; x=1793455112; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=bayY/glbkyFlGSSY0jLX8k8RyrFSF/EZWDZ5KOPr+xg=; b=DPq21M34YxdBDaVqAAG8OCAWArNcb8r90NRNV1TdjYbW5V/L02KAyQ8N wezAE/4gqtpTG/LOjKaByVdY+DODGeOB4KTf4R8YX9qjeFamYFD15PEJM d1GM7qoS1f+niLYl2YZKefacIL3ImV5aXe05BGQC6ZGAHEq+aDitL0NZE S5Z+OglIxU/h9vIDvwO+sCIUp4285XOsTIWfP+8vdgqWE93AEs3zpkVDI kGoyV0HhGbBc8MVEdbwQkA4oGadT1yrYw5MAKrk5AwZNtHkdtFYHBVcFA JCDURDwS1ltOtYTAcVh9CcgqyS/QvfhBvEAtqcxeqsNiMkOT3XJusE/Uf w==; X-CSE-ConnectionGUID: PKgHiyCERx2U88eoYkzwwQ== X-CSE-MsgGUID: YAr91cddRt6v4lLCKIN8HQ== X-IronPort-AV: E=McAfee;i="6800,10657,11598"; a="63284488" X-IronPort-AV: E=Sophos;i="6.19,269,1754982000"; d="scan'208";a="63284488" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2025 06:58:31 -0700 X-CSE-ConnectionGUID: 0FL1TS1dQjWf+PAOirhHgg== X-CSE-MsgGUID: aAVBaDI1RMyRq5JrNtEbZg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,269,1754982000"; d="scan'208";a="191387593" Received: from jjgreens-desk20.amr.corp.intel.com (HELO kuha.fi.intel.com) ([10.124.220.81]) by orviesa005.jf.intel.com with SMTP; 31 Oct 2025 06:58:16 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Fri, 31 Oct 2025 15:58:13 +0200 Date: Fri, 31 Oct 2025 15:58:13 +0200 From: Heikki Krogerus To: Chaoyi Chen Cc: Greg Kroah-Hartman , Dmitry Baryshkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner , Sandy Huang , Andy Yan , Yubing Zhang , Frank Wang , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Amit Sunil Dhamne , Chaoyi Chen , Dragan Simic , Johan Jonker , Diederik de Haas , Peter Robinson , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v8 03/10] drm/bridge: Implement generic USB Type-C DP HPD bridge Message-ID: References: <20251029071435.88-1-kernel@airkyi.com> <20251029071435.88-4-kernel@airkyi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251029071435.88-4-kernel@airkyi.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251031_065832_948893_CFC164F9 X-CRM114-Status: GOOD ( 30.32 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Wed, Oct 29, 2025 at 03:14:28PM +0800, Chaoyi Chen kirjoitti: > From: Chaoyi Chen > > Several USB-C controller drivers have already implemented the DP HPD > bridge function provided by aux-hpd-bridge.c, but there are still > some USB-C controller driver that have not yet implemented it. > > This patch implements a generic DP HPD bridge based on aux-hpd-bridge.c, > so that other USB-C controller drivers don't need to implement it again. > > Signed-off-by: Chaoyi Chen > --- > > Changes in v8: > - Merge generic DP HPD bridge into one module. > > drivers/gpu/drm/bridge/Kconfig | 5 +- > drivers/gpu/drm/bridge/Makefile | 8 +++- > drivers/gpu/drm/bridge/aux-hpd-bridge.c | 23 ++++++++- > drivers/gpu/drm/bridge/aux-hpd-bridge.h | 13 +++++ > .../gpu/drm/bridge/aux-hpd-typec-dp-bridge.c | 47 +++++++++++++++++++ > 5 files changed, 93 insertions(+), 3 deletions(-) > create mode 100644 drivers/gpu/drm/bridge/aux-hpd-bridge.h > create mode 100644 drivers/gpu/drm/bridge/aux-hpd-typec-dp-bridge.c > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > index a250afd8d662..17257b223a28 100644 > --- a/drivers/gpu/drm/bridge/Kconfig > +++ b/drivers/gpu/drm/bridge/Kconfig > @@ -23,13 +23,16 @@ config DRM_AUX_BRIDGE > build bridges chain. > > config DRM_AUX_HPD_BRIDGE > - tristate > + tristate "AUX HPD bridge support" Don't you now need: depends on TYPEC || !TYPEC > depends on DRM_BRIDGE && OF > select AUXILIARY_BUS > help > Simple bridge that terminates the bridge chain and provides HPD > support. > > + Specifically, if you want a default Type-C DisplayPort HPD bridge for > + each port of the Type-C controller, say Y here. > + > menu "Display Interface Bridges" > depends on DRM && DRM_BRIDGE > > diff --git a/drivers/gpu/drm/bridge/Makefile b/drivers/gpu/drm/bridge/Makefile > index c7dc03182e59..2998937444bc 100644 > --- a/drivers/gpu/drm/bridge/Makefile > +++ b/drivers/gpu/drm/bridge/Makefile > @@ -1,6 +1,12 @@ > # SPDX-License-Identifier: GPL-2.0 > obj-$(CONFIG_DRM_AUX_BRIDGE) += aux-bridge.o > -obj-$(CONFIG_DRM_AUX_HPD_BRIDGE) += aux-hpd-bridge.o > + > +hpd-bridge-y := aux-hpd-bridge.o > +ifneq ($(CONFIG_TYPEC),) > +hpd-bridge-y += aux-hpd-typec-dp-bridge.o > +endif > +obj-$(CONFIG_DRM_AUX_HPD_BRIDGE) += hpd-bridge.o > + > obj-$(CONFIG_DRM_CHIPONE_ICN6211) += chipone-icn6211.o > obj-$(CONFIG_DRM_CHRONTEL_CH7033) += chrontel-ch7033.o > obj-$(CONFIG_DRM_CROS_EC_ANX7688) += cros-ec-anx7688.o > diff --git a/drivers/gpu/drm/bridge/aux-hpd-bridge.c b/drivers/gpu/drm/bridge/aux-hpd-bridge.c > index 2e9c702c7087..11ad6dc776c7 100644 > --- a/drivers/gpu/drm/bridge/aux-hpd-bridge.c > +++ b/drivers/gpu/drm/bridge/aux-hpd-bridge.c > @@ -12,6 +12,8 @@ > #include > #include > > +#include "aux-hpd-bridge.h" > + > static DEFINE_IDA(drm_aux_hpd_bridge_ida); > > struct drm_aux_hpd_bridge_data { > @@ -204,7 +206,26 @@ static struct auxiliary_driver drm_aux_hpd_bridge_drv = { > .id_table = drm_aux_hpd_bridge_table, > .probe = drm_aux_hpd_bridge_probe, > }; > -module_auxiliary_driver(drm_aux_hpd_bridge_drv); > + > +static int drm_aux_hpd_bridge_mod_init(void) > +{ > + int ret; > + > + ret = auxiliary_driver_register(&drm_aux_hpd_bridge_drv); > + if (ret) > + return ret; > + > + return drm_aux_hpd_typec_dp_bridge_init(); > +} > + > +static void drm_aux_hpd_bridge_mod_exit(void) > +{ > + drm_aux_hpd_typec_dp_bridge_exit(); > + auxiliary_driver_unregister(&drm_aux_hpd_bridge_drv); > +} > + > +module_init(drm_aux_hpd_bridge_mod_init); > +module_exit(drm_aux_hpd_bridge_mod_exit); > > MODULE_AUTHOR("Dmitry Baryshkov "); > MODULE_DESCRIPTION("DRM HPD bridge"); > diff --git a/drivers/gpu/drm/bridge/aux-hpd-bridge.h b/drivers/gpu/drm/bridge/aux-hpd-bridge.h > new file mode 100644 > index 000000000000..69364731c2f1 > --- /dev/null > +++ b/drivers/gpu/drm/bridge/aux-hpd-bridge.h > @@ -0,0 +1,13 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +#ifndef AUX_HPD_BRIDGE_H > +#define AUX_HPD_BRIDGE_H > + > +#if IS_REACHABLE(CONFIG_TYPEC) > +int drm_aux_hpd_typec_dp_bridge_init(void); > +void drm_aux_hpd_typec_dp_bridge_exit(void); > +#else > +static inline int drm_aux_hpd_typec_dp_bridge_init(void) { return 0; } > +static inline void drm_aux_hpd_typec_dp_bridge_exit(void) { } > +#endif /* IS_REACHABLE(CONFIG_TYPEC) */ > + > +#endif /* AUX_HPD_BRIDGE_H */ > diff --git a/drivers/gpu/drm/bridge/aux-hpd-typec-dp-bridge.c b/drivers/gpu/drm/bridge/aux-hpd-typec-dp-bridge.c > new file mode 100644 > index 000000000000..6f2a1fca0fc5 > --- /dev/null > +++ b/drivers/gpu/drm/bridge/aux-hpd-typec-dp-bridge.c > @@ -0,0 +1,47 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +#include > +#include > +#include > +#include > + > +#include > + > +#include "aux-hpd-bridge.h" > + > +#if IS_REACHABLE(CONFIG_TYPEC) You don't need that. You should not use ifdefs in .c files. > +static int drm_typec_bus_event(struct notifier_block *nb, > + unsigned long action, void *data) > +{ > + struct typec_altmode *alt = (struct typec_altmode *)data; > + > + if (action != TYPEC_ALTMODE_REGISTERED) > + goto done; > + > + if (is_typec_partner(&alt->dev) || alt->svid != USB_TYPEC_DP_SID) > + goto done; > + > + /* > + * alt->dev.parent->parent : USB-C controller device > + * alt->dev.parent : USB-C connector device > + */ > + drm_dp_hpd_bridge_register(alt->dev.parent->parent, > + to_of_node(alt->dev.parent->fwnode)); > + > +done: > + return NOTIFY_OK; > +} > + > +static struct notifier_block drm_typec_event_nb = { > + .notifier_call = drm_typec_bus_event, > +}; > + > +int drm_aux_hpd_typec_dp_bridge_init(void) > +{ > + return typec_altmode_register_notify(&drm_typec_event_nb); > +} > + > +void drm_aux_hpd_typec_dp_bridge_exit(void) > +{ > + typec_altmode_unregister_notify(&drm_typec_event_nb); > +} > +#endif > -- > 2.49.0 -- heikki _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip