From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1143FCCFA1A for ; Wed, 12 Nov 2025 08:29:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7V1yNy1G8Ja5q/PUHtZutBPYKk15ZjNESdVTnvB/V2E=; b=BNdETFOC6vppiD vM75qEW1M+7AQ8C+Hjws43l8A00+UE5+39qoyw4/vqXk1W7ofKFNXhfg8IHy4Z9Y0F3MJP8ZsS2xB Y/nVwcSplHINsfdQIla/+etnlTY1DI3ZXqydjBY393PRqDne6SKL94l7uqccB5wyuTt0Lkk78+7hz Wtu0WUC+nJMfH67eyZ6sCeOv+Oo56oLWMdRBdrjcqXDbiZBKqhsztF+jtTYFbGKZNv/c1LT7MtG7O V3vo//mgTJmL6JnazY+S/nlYXqABIuPVnFnkuvpF3PVxKnoew6DSw5xpRvhXz+Qy9iFLC4Gr3CD7A fHuLK6ZyAmpzOP9sJWZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJ6EP-00000008LRF-28A5; Wed, 12 Nov 2025 08:29:33 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJ6EM-00000008LNy-3SkQ; Wed, 12 Nov 2025 08:29:31 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 0ED69406D7; Wed, 12 Nov 2025 08:29:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36568C4AF0F; Wed, 12 Nov 2025 08:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762936169; bh=P/0U373DGH20CkAHJePNGHyKPPEzprJMAMaujhEWE3g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S6TTndyT/9VXKdEYPZNdVHH1e9mSNLLOM0nt2QNNuy2DF1zpJ7VX1W+XA8x8VBpFw 0q6reZVdpYS5+XUTeIlSFeRx/5l+TKy5+5Rh3Jtxytgs3/FTaIUG4PY7L+PNR7D4PF wXiTYDw8GjkAr6Eq8wyo5PlZ5FKT6nEP5lRpV8aqYzrH0DwRY/S2dqMJrFElqiVqMn RIDq1wZTZe7QbeVDI+1y+p6nbUc9YUwzB9djea+Ku5JeccJn6zwmtExUdHKGhMMIZC bN3Wj70GJa9eWKC0+3SeaJ3f5uIehr962xnTbck2guqY5qREURZ8Vegcrhv4M/VpBo +fZ8lRpBqYwzw== Date: Wed, 12 Nov 2025 09:29:20 +0100 From: Niklas Cassel To: Bjorn Helgaas Cc: Shawn Lin , Manivannan Sadhasivam , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Heiko Stuebner , Kever Yang , Simon Xue , Damien Le Moal , Dragan Simic , FUKAUMI Naoki , Diederik de Haas , Richard Zhu , Frank Li , Lucas Stach , Shawn Guo , Sascha Hauer , Fabio Estevam , Conor Dooley , Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter , Hans Zhang , linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@pengutronix.de, Bjorn Helgaas Subject: Re: [PATCH 2/4] PCI: tegra194: Remove unnecessary L1SS disable code Message-ID: References: <20251111221621.2208606-1-helgaas@kernel.org> <20251111221621.2208606-3-helgaas@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20251111221621.2208606-3-helgaas@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251112_002930_932592_281B2293 X-CRM114-Status: GOOD ( 12.82 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Tue, Nov 11, 2025 at 04:16:09PM -0600, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > The DWC core clears the L1 Substates Supported bits unless the driver sets > the "dw_pcie.l1ss_support" flag. > > The tegra194 init_host_aspm() sets "dw_pcie.l1ss_support" if the platform > has the "supports-clkreq" DT property. If "supports-clkreq" is absent, > "dw_pcie.l1ss_support" is not set, and the DWC core will clear the L1 > Substates Supported bits. > > The tegra194 code to clear the L1 Substates Supported bits is unnecessary, > so remove it. > > Signed-off-by: Bjorn Helgaas > --- Since init_host_aspm() is now the only place using struct tegra_pcie_dw struct member cfg_link_cap_l1sub, I think that you can remove this struct member, and instead make this a local variable in init_host_aspm(). Other than that, looks good to me: Reviewed-by: Niklas Cassel _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip