From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C9A1CF2562 for ; Tue, 18 Nov 2025 22:46:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LkdfT1Ri16NH31DJHCFJ0Lxm20b7OUlWKhLgrEyrGG0=; b=0VR4s2Tx+jjKsR 8JclT8rv+lWxb5PUPbiPLhKikzH3MNRHq3xU5sE7OtiwL28JGHjN5GzhBQnBnntBC3mnK6Fa0IwZU vYfcwAWlh2kXBi50m29Bi1c7XBY+c9d/SkeVdM3f+Y1xCOknGZB300f7OS1EZyxfjY6CvvHOx16g/ 3n/YdlyGMv5oyWo9hka6/1lCQ7fTc6mvYIjHvP6ZpoIdKmhBL5xvEZv/WxdpXZbg9SysPTu0vLuiG YFxcwIOMEgG/OgdQmZpxH57CMTMZKkFoF7luYd7RrNXMaUedRwso7dtiCpjyfp26fDJfQ54RPqb09 j92AlDLsoQ7Lgsufwalg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vLUSY-00000001CFG-0azH; Tue, 18 Nov 2025 22:46:03 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vLUSV-00000001CEb-2rAP; Tue, 18 Nov 2025 22:46:00 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id BDD1743EE4; Tue, 18 Nov 2025 22:45:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0FFE8C2BCB2; Tue, 18 Nov 2025 22:45:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763505958; bh=lPmYAC5UhGq5csm5w1kpo4lzZfCH3Y5ufvUShymSFxg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gf6l0GI2o2/EgE75LRuMBYxnQT61mUg8fexr0O/NLCVyFl0crqJh8ZyF60v86MbBV oRyn3uZVM0CBaL8BGFVh4+c74IYt02Yal5tJJ1D06rwYgtUqwst9j2z0COSsZ9jZk/ OpTjOdbthQxGucQOfJqVgQbQeHeep42OYY7t0jaoPOtJERc3uAkFuSdmmlSV8JS8Q6 dMIt2Gbe6UsjWWkJL1pHh2lO891xUxdcoqW0UwqOy44hvWKNawpVvKhm3LPOSF5qQc xsUfvQfQMN0mYU+FoMwH86p+YunCirxNYJbXMSsAckDLL8HITuWUhl823GeesM2N+M VQINgYUfjydsQ== Date: Tue, 18 Nov 2025 23:45:46 +0100 From: Niklas Cassel To: Frank Li Cc: Bjorn Helgaas , Shawn Lin , Manivannan Sadhasivam , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Heiko Stuebner , Kever Yang , Simon Xue , Damien Le Moal , Dragan Simic , FUKAUMI Naoki , Diederik de Haas , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Fabio Estevam , Conor Dooley , Krzysztof Kozlowski , Thierry Reding , Jonathan Hunter , Hans Zhang , linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@pengutronix.de, Bjorn Helgaas Subject: Re: [PATCH v2 1/4] PCI: dwc: Advertise L1 PM Substates only if driver requests it Message-ID: References: <20251118214312.2598220-1-helgaas@kernel.org> <20251118214312.2598220-2-helgaas@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251118_144559_740553_BCD81731 X-CRM114-Status: GOOD ( 11.47 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hello Frank, On Tue, Nov 18, 2025 at 05:20:36PM -0500, Frank Li wrote: > > > > + dw_pcie_hide_unsupported_l1ss(pci); > > + > > Need call dw_pcie_dbi_ro_wr_en(pci) to access PCI_L1SS_CAP. I disagree. At least when checking two different versions of the databook (one very old and one more recent), the register fields that we are touching are all marked as: Dbi: R/W (sticky) There are some other register fields in PCI_L1SS_CAP, e.g. NEXT_OFFSET, CAP_VERSION, and EXTENDED_CAP_ID that are marked as: Dbi: if (DBI_RO_WR_EN == 1) then R/W(sticky) else R(sticky) Note: This register field is sticky. But since we are not touching any of those register fields, the current code should be good as is. Perhaps your version of the databook says differently than the two versions I have, but considering that they seem to have intentionally made these R/W without the need for DBI_RO_WR_EN, I don't see a reason why they would want to change it even in the absolute newest IP version. Kind regards, Niklas _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip