Re: [PATCH RFC net-next 00/15] net: stmmac: rk: cleanups galore

Jacob Keller
2025-12-04T00:52:18Z

[-- Attachment #1.1.1: Type: text/plain, Size: 441 bytes --]

On 12/1/2025 8:44 AM, Russell King (Oracle) wrote:
> Again, I don't like this foo_enable() / foo_power_on() pattern with
> a true/false argument - when false, the function is not enabling
> nor "on"-ing, but disabling or "off"-ing. So, gmac_clk_enable() is
> going to get split up and renamed.
>

Agreed, removing this anti-pattern is good. It makes the logic more
difficult to follow and understand than well named functions.

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]