From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC913D1D494 for ; Thu, 8 Jan 2026 21:24:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vmsBIl5+dy8WmDoQx1fIltjLgDyB8UV7bjhWlvWdzt4=; b=Oh/qotU0L7kEzE a00efSSWIysUkAf4SiREDoOsEpbd8ykyrk9zcpkngmkj3BQ/akNdtu6gc97j1uD7F6L/bRgZFPWh4 j1hSH9SKLUWNxoUNXt/PYgJslIbT51R3DPpGumkG8Gi/ZGAW4aP6xZbezhOQu8qIdKgVzI7eCVipZ 9XGGfFfdYNpTLz30kpTXRbA7SWftoLmIwCPKW/GVeQAohEiTUkafJgInyWToYLKuQHRlEIa+YjZkx IW7kRvIicluPjO40zHb1dRPUClUvTVEs+OtyX2sSC9RFbxRAC39qqkqhtlZqYqLtQmPCFgq9z+mjF DBUEXLL38MnOekZrfAbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdxU4-00000000u7Z-1HPF; Thu, 08 Jan 2026 21:24:01 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vdxU0-00000000u5a-1yRP for linux-rockchip@lists.infradead.org; Thu, 08 Jan 2026 21:23:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767907431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aMZTdMgEwkPQanj/a0OAHfxOFan2ydElF0bb71YGl8A=; b=Uf7uzfNJ3+JSJCkeGBiusv/Kt7p1mxr2a1YeOLNrN0ZKArxnRyPkIes1TQa2m9iE2nTc/C FtR2nf/nN65TFVxroidR3GAK+iYvvB13tMCHsTz1LLABaX/oMMRxaV0u/DrVRLjLy9QTcb 9hJYP+016PKwfrm1ol4yQuFj2QV5Qrg= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-433-Wulaj-ilNrKTtUGq6dN19w-1; Thu, 08 Jan 2026 16:23:49 -0500 X-MC-Unique: Wulaj-ilNrKTtUGq6dN19w-1 X-Mimecast-MFC-AGG-ID: Wulaj-ilNrKTtUGq6dN19w_1767907429 Received: by mail-vk1-f199.google.com with SMTP id 71dfb90a1353d-55995c43832so6974682e0c.3 for ; Thu, 08 Jan 2026 13:23:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767907429; x=1768512229; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aMZTdMgEwkPQanj/a0OAHfxOFan2ydElF0bb71YGl8A=; b=mumywTLspSo98/BSjNBynt0x3P0vhlrYq3r45wV0f9pPysuO49B2ZRSdDyj+QMeDwL jS1MnebCWRHIMRl9a9zzbsNaCcF2FvjQKZXcsoiJURzfWp3qz/t2aAGtdYABstAD66Zp 2+m5Clgd3GUbjfDi1n5ON7/RIkvXadSiKUN8f7nK8gK0rmGOiaO9oxFRM9Bbfx09qFhS J1+Bfo67RevpTlAaFWE6hG0tT8f9FQo0HSdyvir0VVxHm722z7M95BJg6mITDzLtNOHn XDf/nhuxO/8RKtqxos77T0Itrev4odeUl7kt8EOYqZgXCwbyYAMFBgSjGLcZmQApr8sz bUfw== X-Forwarded-Encrypted: i=1; AJvYcCXRcxsuFK9TADI2gSb2cq9RXj23eMnrgpWRUa8heDBZjKNuCOzXxzbva4xRfzc7FvuM5kK6oTJhf0BaKz463Q==@lists.infradead.org X-Gm-Message-State: AOJu0YxaXvUuVsWtevI4z+HdeSw3bMpP8lihcwtHBGCDED+EIwIBRRuK SYxZYNwFeHISuIwDOnihzfkxKa0vYTKcDlaoiUQigRIn5ble06qgVNdHrGX0u2PXKZXrE4rlgvC 7jKW6SF4G8JPpFZTfbPGtYTFK909029/PcADtq7vTOCRC9j1xb0BAWxSYwbcsBKqsCoGlIf37Cw == X-Gm-Gg: AY/fxX6Dfjf5/+Hz25PjkET7+qVhB2TUJar7Gj/kxUe2Nlh9z9+/Uipp6/SzONRb+O0 v/gcPav266VkoqbGse4diR+Z4a5+o4QM2tY15SZJ+IjFIygQazbkQoRsfDzDUBivmMKFNdiwBux s1RBpFb7zb993fks4ew4uR5HyMbbYk53rjYrXn/3eGciDHk5rzDLqzUULln62kzLg8hb9LAfWdM n/ang3vqxxiNsO9jpAuvknuJCjsu1Os0yoTyM8XRMaXEO69ErF2+efhkAy+bcbViUymdBjb3LUk uJH1YjWUMaKM73Kr9ay0QZnNo7zzEI26faHmH9fZ+KEBBlYaavsF7jpKNrrnisxeAJqErWt2dM0 QntQGCvtR X-Received: by 2002:a05:6102:162a:b0:5ee:a76a:8513 with SMTP id ada2fe7eead31-5eea76a8724mr1006314137.33.1767907429156; Thu, 08 Jan 2026 13:23:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IE9+XK5E3OQPztXIo7GPKPfvpra0LA99i0XMQua/Tc/8Kj6tPqIGZY+3/QAUKTGxXE41kQHWQ== X-Received: by 2002:a05:6102:162a:b0:5ee:a76a:8513 with SMTP id ada2fe7eead31-5eea76a8724mr1006294137.33.1767907428708; Thu, 08 Jan 2026 13:23:48 -0800 (PST) Received: from redhat.com ([2600:382:811f:d757:daa5:b867:12a3:9d12]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ec772e322asm7790577137.13.2026.01.08.13.23.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 13:23:48 -0800 (PST) Date: Thu, 8 Jan 2026 16:23:34 -0500 From: Brian Masney To: Geert Uytterhoeven Cc: Vinod Koul , Kishon Vijay Abraham I , Chun-Kuang Hu , Philipp Zabel , Chunfeng Yun , Matthias Brugger , AngeloGioacchino Del Regno , Heiko Stuebner , Neil Armstrong , Stephen Boyd , Maxime Ripard , linux-clk@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3 9/9] phy: ti: phy-j721e-wiz: convert from round_rate() to determine_rate() Message-ID: References: <20251212-phy-clk-round-rate-v3-0-beae3962f767@redhat.com> <20251212-phy-clk-round-rate-v3-9-beae3962f767@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3Ebrv8r6bXNPnYWW5GSM7GI_SscQtxRZ9R8WEAtamfQ_1767907429 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260108_132352_593935_CF0ED7CA X-CRM114-Status: GOOD ( 27.76 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hi Geert, On Mon, Jan 05, 2026 at 07:14:43AM -0500, Brian Masney wrote: > On Mon, Dec 29, 2025 at 11:18:52AM +0100, Geert Uytterhoeven wrote: > > Hi Brian, > > > > On Fri, 12 Dec 2025 at 00:21, Brian Masney wrote: > > > The round_rate() clk ops is deprecated, so migrate this driver from > > > round_rate() to determine_rate() using the Coccinelle semantic patch > > > on the cover letter of this series. > > > > > > Signed-off-by: Brian Masney > > > > Thanks for your patch, which is now commit 27287e3b52b5954b ("phy: > > ti: phy-j721e-wiz: convert from round_rate() to determine_rate()") > > in phy/next > > > > > --- a/drivers/phy/ti/phy-j721e-wiz.c > > > +++ b/drivers/phy/ti/phy-j721e-wiz.c > > > @@ -934,12 +934,15 @@ static unsigned long wiz_clk_div_recalc_rate(struct clk_hw *hw, > > > return divider_recalc_rate(hw, parent_rate, val, div->table, 0x0, 2); > > > } > > > > > > -static long wiz_clk_div_round_rate(struct clk_hw *hw, unsigned long rate, > > > - unsigned long *prate) > > > +static int wiz_clk_div_determine_rate(struct clk_hw *hw, > > > + struct clk_rate_request *req) > > > { > > > struct wiz_clk_divider *div = to_wiz_clk_div(hw); > > > > > > - return divider_round_rate(hw, rate, prate, div->table, 2, 0x0); > > > + req->rate = divider_round_rate(hw, req->rate, &req->best_parent_rate, > > > + div->table, 2, 0x0); > > > > Is this correct? divider_round_rate() can return a negative error code > > (from divider_ro_determine_rate()), which is not handled here? > > > > Looks like several other users of divider_round_rate() use this > > same logic, and thus are affected, too. > > Thanks for the review! You are correct that this is a bug. > > I had planned once round_rate is removed from the clk core to post a > series to remove divider_round_rate() and divider_ro_round_rate() (plus > the _parent functions) since they call the corresponding determine_rate > functions. I'll bump that up on my todo list this week. I posted a series that fixes the issue you identified, plus removes those deprecated APIs all in one go. https://lore.kernel.org/linux-clk/20260108-clk-divider-round-rate-v1-0-535a3ed73bf3@redhat.com/T/#t Brian _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip