From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A718FD45FD for ; Thu, 26 Feb 2026 00:19:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n/75klVn8oKqkHkcBqSMEFfmKpDZT5Sxlh+pkpINJV8=; b=3JMBSxPmxAtJmf tvRKsTUX/waS5pH/c2iwTXwc7r4K1o3GULu1bIjZYjVtuTRl159HRD/ysTnuu0H661+PpgRU+K7sr nxsA7eZ263YJvWVw5lhYCBpAQmpSn7wpgHbkUwBOhOIG3IoUo1uOhhZTomEGoiu3gQOGq5uAVgjjc L4QtzyX42hH99nl7rpi5LUhyWMvfPMiDPAdh9Hnw/3T4TtI95lzqWlqxq18HrhccnJ66NoI0F9JnK ypBmpWtmv87FZ6n6Dw6PQySaYOGNrBg8+FyZCI5QgOwN+Twqp3h0uHqRbZgrokSfyfj28u3DZOd+z HYS8Ko9IdQGoaIgWypwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vvP5o-000000058YX-068A; Thu, 26 Feb 2026 00:19:00 +0000 Received: from mail-ua1-x92f.google.com ([2607:f8b0:4864:20::92f]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vvP5l-000000058SP-02zy for linux-rockchip@lists.infradead.org; Thu, 26 Feb 2026 00:18:58 +0000 Received: by mail-ua1-x92f.google.com with SMTP id a1e0cc1a2514c-94ddba39060so83251241.1 for ; Wed, 25 Feb 2026 16:18:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772065135; x=1772669935; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aT/CuULkbwm3ZtLWPS1iAQDnaaV5hiK+YKdLvwy3we0=; b=cMzls11UXm6614vpccNUxfEBGVurITrZ+llHyh/9E2p8hKuTv3KSpo8JOnq5a+wUXm rMWnhwhpQb6jpnp0RvH2XY58UzfCOVfTbf6IehIzT01L53/r1OKrDzLaCnx6qEpGklq2 xLDMnW2UObdxVgkvjFDyksC9kWTrSFhOLrKofuWl/QgaLfOkxBL1BH0gOMbQ6rDc/TvR b2b6hTBWsIYdTJPO0ftuJNDRaejQjqjjD1YVANaWvjyJAYZWQc46DjzfOZXGfZoztpuC dBEW/pO5DepLbCZAWlK8Ep5GEdv/pcDJRG3iebwrPWJiNQXU4Jtx5lGvlva9r3acBU6f mKHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772065135; x=1772669935; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aT/CuULkbwm3ZtLWPS1iAQDnaaV5hiK+YKdLvwy3we0=; b=Gn8+kG8XyaoD+xuVy4UbDBtLpdPDYng1nzYsAm0R2G5K4+P5JON/v5Cz7QLyiM0Ya5 TDO6kDqZgLNQBgkLC9Mf1EQkuksxbCn3Ra7DfZB5a7D6aUh7WNloVv0mp+st0xxQMt52 W4AOAVRqExKzPtVNpDmIGh3ykzAKbxQaKH3sDDbg2e7be+f+SWiZVjWMbUfCIlHMtm4s vK4s3XRy+DpJ1IxTLcb/v1r1b1s0BFUmMc1scHYLUgFqrcl6JKVEt9vpoJjpdZOWxCyg e3kJmF/KUlfTXPkeSFUi4kUjjkrcLTE7ziUTPvooMLsU55CDl7GHW/ZVTmDZHXPlaDq9 oKoQ== X-Forwarded-Encrypted: i=1; AJvYcCWB+qqWilmU20yOogEdWuJD+siVy4HRgc9JayW59HBojVA9xBZHtcZkisQlHRM5dCe7m6yvB+iSc3HNSrI5dw==@lists.infradead.org X-Gm-Message-State: AOJu0Yy0bubba/entOUx1y7BGd8+FDDaHwm+OBZ6NyJsYLvLFdkNnZ6H lZWdW1h4fPKCAy9mlDPOJI7gV3Phu+QrPkudVUxW03HN4jjk3+1WYDwC X-Gm-Gg: ATEYQzxPYTzjNa1kiwmjVUYxa+0yg4f4Qg3UYVEG/X4h7jncpLAfooK8L+EOnAPBIyf P2U5eC9pByIXV81bEHOEDSUjYjJJo3yaPIE1BJTNUnsQCJLP7kU2xT/08b4Fb48SD00wE3bCuBV jHjpkCVV4XLOpYGo0nuS5e6I8VSjzoWwvH9JoaElWZDNqk8lzy4OtkRro+bGztnpqhceAFCXrLi XClLbzoX1RELALMzz4rgE/BfbYlzw1q31vkxufgKrd5b/s3f2p7Sk7XxkOEcAGGh7xoO9uycnpn myT2fs9pYx6ts4NLtXSRGMc92fXySZwkYQ8QnUzjI9hRyDNIFDr3+xTvoUee7EyQjzu4GynfsQu vs/irp7jPS8lwIufjFwpIIewrQFIANA9KXT58WWgBEMA98eHptpNVe8kAC0sqS6zdmP2ATb0gL1 NGbf+AjLAg5g== X-Received: by 2002:a05:6102:358d:b0:5db:3bbf:8e62 with SMTP id ada2fe7eead31-5feb2e60d7dmr7045155137.1.1772065135433; Wed, 25 Feb 2026 16:18:55 -0800 (PST) Received: from geday ([2804:7f2:800b:f14d::dead:c001]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ff1ea6ea19sm612107137.12.2026.02.25.16.18.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Feb 2026 16:18:54 -0800 (PST) Date: Wed, 25 Feb 2026 21:18:48 -0300 From: Geraldo Nascimento To: Bjorn Helgaas Cc: Shawn Lin , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Dragan Simic , linux-rockchip@lists.infradead.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] PCI: rockchip-host: comment danger of 5.0 GT/s speed Message-ID: References: <8db835ffe384db63ee598a203751b298ad1cc267.1772057799.git.geraldogabriel@gmail.com> <20260226001229.GA3794668@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260226001229.GA3794668@bhelgaas> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260225_161857_085167_C0B0BA6F X-CRM114-Status: GOOD ( 27.37 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Wed, Feb 25, 2026 at 06:12:29PM -0600, Bjorn Helgaas wrote: > On Wed, Feb 25, 2026 at 07:27:44PM -0300, Geraldo Nascimento wrote: > > According to Rockchip sources, there is grave danger in enabling 5.0 > > GT/s speed for this core. Add a comment documenting this risk of > > "catastrophic failure" and discouraging end-users from forcing > > higher speed. > > A comment in the code might be useful but doesn't discourage end > users. Hi Bjorn, thanks for the quick review. > > > Link: https://lore.kernel.org/all/ffd05070-9879-4468-94e3-b88968b4c21b@rock-chips.com/ > > Cc: stable@vger.kernel.org > > Reported-by: Dragan Simic > > Reported-by: Shawn Lin > > Reviewed-by: Dragan Simic > > Signed-off-by: Geraldo Nascimento > > --- > > drivers/pci/controller/pcie-rockchip-host.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/controller/pcie-rockchip-host.c > > index ee1822ca01db..4faf3e29b7d5 100644 > > --- a/drivers/pci/controller/pcie-rockchip-host.c > > +++ b/drivers/pci/controller/pcie-rockchip-host.c > > @@ -332,6 +332,10 @@ static int rockchip_pcie_host_init_port(struct rockchip_pcie *rockchip) > > /* > > * Enable retrain for gen2. This should be configured only after > > * gen1 finished. > > + * > > + * Dangerous and may lead to "catastrophic failure", with data loss > > + * or worse! > > + * > > Wrap comment to fit in 80 columns like the rest of the file. > > Remove spurious blank line at end. > > This should probably be squashed with the first patch; I don't see the > benefit of having them separate. > > Why don't we just remove this whole "link_gen == 2" block? If we > don't want to use it, there's no point in keeping the code. Yes, I think I'll go with this second option and remove the code block outright. Thanks, Geraldo Nascimento > > > */ > > status = rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL2); > > status &= ~PCI_EXP_LNKCTL2_TLS; > > -- > > 2.52.0 > > > > > > _______________________________________________ > > Linux-rockchip mailing list > > Linux-rockchip@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-rockchip _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip