From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: Re: [PATCH 30/41] drm/bridge: analogix_dp: Fix incorrect operations with register ANALOGIX_DP_FUNC_EN_1 Date: Wed, 22 Mar 2017 10:29:24 +0100 Message-ID: References: <20170310043305.17216-1-seanpaul@chromium.org> <20170310043305.17216-31-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <20170310043305.17216-31-seanpaul@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul , linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org Cc: zain wang , Lin Huang , Tomeu Vizoso , Douglas Anderson , Tomasz Figa , Yakir Yang , Tomasz Figa List-Id: linux-rockchip.vger.kernel.org T24gMTAuMDMuMjAxNyAwNTozMiwgU2VhbiBQYXVsIHdyb3RlOgo+IEZyb206IHphaW4gd2FuZyA8 d3p6QHJvY2stY2hpcHMuY29tPgo+Cj4gUmVnaXN0ZXIgQU5BTE9HSVhfRFBfRlVOQ19FTl8xKG9m ZnNldCAweDE4KSwgUm9ja2NoaXAgaXMgZGlmZmVyZW50IHRvIEV4eW5vczoKPiBvbiBFeHlub3Mg ZWRwIHBoeSwKPiBCSVQgNwkJTUFTVEVSX1ZJRF9GVU5DX0VOX04KPiBCSVQgNgkJcmVzZXJ2ZWQK PiBCSVQgNQkJU0xBVkVfVklEX0ZVTkNfRU5fTgo+IG9uIFJvY2tjaGlwIGVkcCBwaHksCj4gQklU IDcJCXJlc2VydmVkCj4gQklUIDYJCVJLX1ZJRF9DQVBfRlVOQ19FTl9OCj4gQklUIDUJCVJLX1ZJ RF9GSUZPX0ZVTkNfRU5fTgo+IFNvLCB3ZSBzaG91bGQgZG8gc29tZSBwcml2YXRlIG9wZXJhdGlv bnMgdG8gUm9ja2NoaXAuCj4gQ2M6IFRvbWFzeiBGaWdhIDx0ZmlnYUBjaHJvbWl1bS5vcmc+Cj4g U2lnbmVkLW9mZi1ieTogemFpbiB3YW5nIDx3enpAcm9jay1jaGlwcy5jb20+Cj4gU2lnbmVkLW9m Zi1ieTogU2VhbiBQYXVsIDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+CgpSZXZpZXdlZC1ieTogQW5k cnplaiBIYWpkYSA8YS5oYWpkYUBzYW1zdW5nLmNvbT4KCkJUVywgdGhlIG51bWJlciBvZiByZWdp c3RyeSBkaWZmZXJlbmNlcyBiZWNvbWVzIHNpZ25pZmljYW50LCBtYXliZSBpdCBpcwp0aW1lIHRv IHJlcGxhY2UgdGhpcyB1Z2x5IGNvbmRpdGlvbmFsOgogICAgaWYgKGRwLT5wbGF0X2RhdGEgJiYg aXNfcm9ja2NoaXAoZHAtPnBsYXRfZGF0YS0+ZGV2X3R5cGUpKQp3aXRoIHNvbWV0aGluZyBtb3Jl IHJlYWRhYmxlLgoKLS0KUmVnYXJkcwpBbmRyemVqCgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v YnJpZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4X2RwX3JlZy5jIHwgMTkgKysrKysrKysrKysrKystLS0t LQo+ICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4X2RwX3JlZy5oIHwg IDIgKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygt KQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgvYW5hbG9n aXhfZHBfcmVnLmMgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4X2Rw X3JlZy5jCj4gaW5kZXggMmNhY2QxZTg0YjRkLi5kZGM4MTY1OTQ3YzEgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9kcF9yZWcuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9naXgvYW5hbG9naXhfZHBfcmVnLmMKPiBAQCAt MTI2LDkgKzEyNiwxNCBAQCB2b2lkIGFuYWxvZ2l4X2RwX3Jlc2V0KHN0cnVjdCBhbmFsb2dpeF9k cF9kZXZpY2UgKmRwKQo+ICAJYW5hbG9naXhfZHBfc3RvcF92aWRlbyhkcCk7Cj4gIAlhbmFsb2dp eF9kcF9lbmFibGVfdmlkZW9fbXV0ZShkcCwgMCk7Cj4gIAo+IC0JcmVnID0gTUFTVEVSX1ZJRF9G VU5DX0VOX04gfCBTTEFWRV9WSURfRlVOQ19FTl9OIHwKPiAtCQlBVURfRklGT19GVU5DX0VOX04g fCBBVURfRlVOQ19FTl9OIHwKPiAtCQlIRENQX0ZVTkNfRU5fTiB8IFNXX0ZVTkNfRU5fTjsKPiAr CWlmIChkcC0+cGxhdF9kYXRhICYmIGlzX3JvY2tjaGlwKGRwLT5wbGF0X2RhdGEtPmRldl90eXBl KSkKPiArCQlyZWcgPSBSS19WSURfQ0FQX0ZVTkNfRU5fTiB8IFJLX1ZJRF9GSUZPX0ZVTkNfRU5f TiB8Cj4gKwkJCVNXX0ZVTkNfRU5fTjsKPiArCWVsc2UKPiArCQlyZWcgPSBNQVNURVJfVklEX0ZV TkNfRU5fTiB8IFNMQVZFX1ZJRF9GVU5DX0VOX04gfAo+ICsJCQlBVURfRklGT19GVU5DX0VOX04g fCBBVURfRlVOQ19FTl9OIHwKPiArCQkJSERDUF9GVU5DX0VOX04gfCBTV19GVU5DX0VOX047Cj4g Kwo+ICAJd3JpdGVsKHJlZywgZHAtPnJlZ19iYXNlICsgQU5BTE9HSVhfRFBfRlVOQ19FTl8xKTsK PiAgCj4gIAlyZWcgPSBTU0NfRlVOQ19FTl9OIHwgQVVYX0ZVTkNfRU5fTiB8Cj4gQEAgLTk3MCw4 ICs5NzUsMTIgQEAgdm9pZCBhbmFsb2dpeF9kcF9jb25maWdfdmlkZW9fc2xhdmVfbW9kZShzdHJ1 Y3QgYW5hbG9naXhfZHBfZGV2aWNlICpkcCkKPiAgCXUzMiByZWc7Cj4gIAo+ICAJcmVnID0gcmVh ZGwoZHAtPnJlZ19iYXNlICsgQU5BTE9HSVhfRFBfRlVOQ19FTl8xKTsKPiAtCXJlZyAmPSB+KE1B U1RFUl9WSURfRlVOQ19FTl9OIHwgU0xBVkVfVklEX0ZVTkNfRU5fTik7Cj4gLQlyZWcgfD0gTUFT VEVSX1ZJRF9GVU5DX0VOX047Cj4gKwlpZiAoZHAtPnBsYXRfZGF0YSAmJiBpc19yb2NrY2hpcChk cC0+cGxhdF9kYXRhLT5kZXZfdHlwZSkpIHsKPiArCQlyZWcgJj0gfihSS19WSURfQ0FQX0ZVTkNf RU5fTiB8IFJLX1ZJRF9GSUZPX0ZVTkNfRU5fTik7Cj4gKwl9IGVsc2Ugewo+ICsJCXJlZyAmPSB+ KE1BU1RFUl9WSURfRlVOQ19FTl9OIHwgU0xBVkVfVklEX0ZVTkNfRU5fTik7Cj4gKwkJcmVnIHw9 IE1BU1RFUl9WSURfRlVOQ19FTl9OOwo+ICsJfQo+ICAJd3JpdGVsKHJlZywgZHAtPnJlZ19iYXNl ICsgQU5BTE9HSVhfRFBfRlVOQ19FTl8xKTsKPiAgCj4gIAlyZWcgPSByZWFkbChkcC0+cmVnX2Jh c2UgKyBBTkFMT0dJWF9EUF9WSURFT19DVExfMTApOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vYnJpZGdlL2FuYWxvZ2l4L2FuYWxvZ2l4X2RwX3JlZy5oIGIvZHJpdmVycy9ncHUvZHJt L2JyaWRnZS9hbmFsb2dpeC9hbmFsb2dpeF9kcF9yZWcuaAo+IGluZGV4IGI2MzNhNGE1MDgyYS4u MGNmMjdjNzMxNzI3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYW5hbG9n aXgvYW5hbG9naXhfZHBfcmVnLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2FuYWxv Z2l4L2FuYWxvZ2l4X2RwX3JlZy5oCj4gQEAgLTEyNyw3ICsxMjcsOSBAQAo+ICAKPiAgLyogQU5B TE9HSVhfRFBfRlVOQ19FTl8xICovCj4gICNkZWZpbmUgTUFTVEVSX1ZJRF9GVU5DX0VOX04JCQko MHgxIDw8IDcpCj4gKyNkZWZpbmUgUktfVklEX0NBUF9GVU5DX0VOX04JCQkoMHgxIDw8IDYpCj4g ICNkZWZpbmUgU0xBVkVfVklEX0ZVTkNfRU5fTgkJCSgweDEgPDwgNSkKPiArI2RlZmluZSBSS19W SURfRklGT19GVU5DX0VOX04JCQkoMHgxIDw8IDUpCj4gICNkZWZpbmUgQVVEX0ZJRk9fRlVOQ19F Tl9OCQkJKDB4MSA8PCA0KQo+ICAjZGVmaW5lIEFVRF9GVU5DX0VOX04JCQkJKDB4MSA8PCAzKQo+ ICAjZGVmaW5lIEhEQ1BfRlVOQ19FTl9OCQkJCSgweDEgPDwgMikKCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK