* [PATCH v2] drm: rockchip-dw-dp: add missing dependency on bridge_connector
@ 2026-03-19 15:50 Marius Dinu
2026-03-19 17:56 ` Diederik de Haas
0 siblings, 1 reply; 5+ messages in thread
From: Marius Dinu @ 2026-03-19 15:50 UTC (permalink / raw)
To: linux-rockchip; +Cc: Andy Yan, Marius Dinu
Avoids this error:
ld: drivers/gpu/drm/rockchip/dw_dp-rockchip.o: in function `dw_dp_rockchip_bind':
/usr/src/linux/drivers/gpu/drm/rockchip/dw_dp-rockchip.c:108:(.text+0x188): undefined reference to `drm_bridge_connector_init'
Signed-off-by: Marius Dinu <m95d+git@psihoexpert.ro>
---
drivers/gpu/drm/rockchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
index 1479b8c4ed40..39cd38375e8a 100644
--- a/drivers/gpu/drm/rockchip/Kconfig
+++ b/drivers/gpu/drm/rockchip/Kconfig
@@ -67,6 +67,7 @@ config ROCKCHIP_CDN_DP
config ROCKCHIP_DW_DP
bool "Rockchip specific extensions for Synopsys DW DP"
+ select DRM_BRIDGE_CONNECTOR
help
This selects support for Rockchip SoC specific extensions
to enable Synopsys DesignWare Cores based DisplayPort transmit
--
2.52.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] drm: rockchip-dw-dp: add missing dependency on bridge_connector
2026-03-19 15:50 [PATCH v2] drm: rockchip-dw-dp: add missing dependency on bridge_connector Marius Dinu
@ 2026-03-19 17:56 ` Diederik de Haas
2026-03-20 7:14 ` Marius Dinu
0 siblings, 1 reply; 5+ messages in thread
From: Diederik de Haas @ 2026-03-19 17:56 UTC (permalink / raw)
To: Marius Dinu, linux-rockchip; +Cc: Andy Yan
On Thu Mar 19, 2026 at 4:50 PM CET, Marius Dinu wrote:
> Avoids this error:
> ld: drivers/gpu/drm/rockchip/dw_dp-rockchip.o: in function `dw_dp_rockchip_bind':
> /usr/src/linux/drivers/gpu/drm/rockchip/dw_dp-rockchip.c:108:(.text+0x188): undefined reference to `drm_bridge_connector_init'
>
> Signed-off-by: Marius Dinu <m95d+git@psihoexpert.ro>
> ---
> drivers/gpu/drm/rockchip/Kconfig | 1 +
$ scripts/get_maintainer.pl drivers/gpu/drm/rockchip/Kconfig
Sandy Huang <hjc@rock-chips.com> (maintainer:DRM DRIVERS FOR ROCKCHIP)
"Heiko Stübner" <heiko@sntech.de> (maintainer:DRM DRIVERS FOR ROCKCHIP)
Andy Yan <andy.yan@rock-chips.com> (maintainer:DRM DRIVERS FOR ROCKCHIP)
Maarten Lankhorst <maarten.lankhorst@linux.intel.com> (maintainer:DRM DRIVERS AND MISC GPU PATCHES)
Maxime Ripard <mripard@kernel.org> (maintainer:DRM DRIVERS AND MISC GPU PATCHES)
Thomas Zimmermann <tzimmermann@suse.de> (maintainer:DRM DRIVERS AND MISC GPU PATCHES)
David Airlie <airlied@gmail.com> (maintainer:DRM DRIVERS)
Simona Vetter <simona@ffwll.ch> (maintainer:DRM DRIVERS)
dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR ROCKCHIP)
linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support)
linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC support)
linux-kernel@vger.kernel.org (open list)
I'm missing quite a few of these ...
Cheers,
Diederik
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
> index 1479b8c4ed40..39cd38375e8a 100644
> --- a/drivers/gpu/drm/rockchip/Kconfig
> +++ b/drivers/gpu/drm/rockchip/Kconfig
> @@ -67,6 +67,7 @@ config ROCKCHIP_CDN_DP
>
> config ROCKCHIP_DW_DP
> bool "Rockchip specific extensions for Synopsys DW DP"
> + select DRM_BRIDGE_CONNECTOR
> help
> This selects support for Rockchip SoC specific extensions
> to enable Synopsys DesignWare Cores based DisplayPort transmit
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] drm: rockchip-dw-dp: add missing dependency on bridge_connector
2026-03-19 17:56 ` Diederik de Haas
@ 2026-03-20 7:14 ` Marius Dinu
2026-03-20 12:57 ` Diederik de Haas
0 siblings, 1 reply; 5+ messages in thread
From: Marius Dinu @ 2026-03-20 7:14 UTC (permalink / raw)
To: Diederik de Haas; +Cc: Marius Dinu, linux-rockchip, Andy Yan
On Thu, 2026-03-19 18.56.59 ++0100, Diederik de Haas wrote:
> On Thu Mar 19, 2026 at 4:50 PM CET, Marius Dinu wrote:
> > Avoids this error:
> > ld: drivers/gpu/drm/rockchip/dw_dp-rockchip.o: in function `dw_dp_rockchip_bind':
> > /usr/src/linux/drivers/gpu/drm/rockchip/dw_dp-rockchip.c:108:(.text+0x188): undefined reference to `drm_bridge_connector_init'
> >
> > Signed-off-by: Marius Dinu <m95d+git@psihoexpert.ro>
> > ---
> > drivers/gpu/drm/rockchip/Kconfig | 1 +
>
> $ scripts/get_maintainer.pl drivers/gpu/drm/rockchip/Kconfig
> Sandy Huang <hjc@rock-chips.com> (maintainer:DRM DRIVERS FOR ROCKCHIP)
> "Heiko Stübner" <heiko@sntech.de> (maintainer:DRM DRIVERS FOR ROCKCHIP)
> Andy Yan <andy.yan@rock-chips.com> (maintainer:DRM DRIVERS FOR ROCKCHIP)
> Maarten Lankhorst <maarten.lankhorst@linux.intel.com> (maintainer:DRM DRIVERS AND MISC GPU PATCHES)
> Maxime Ripard <mripard@kernel.org> (maintainer:DRM DRIVERS AND MISC GPU PATCHES)
> Thomas Zimmermann <tzimmermann@suse.de> (maintainer:DRM DRIVERS AND MISC GPU PATCHES)
> David Airlie <airlied@gmail.com> (maintainer:DRM DRIVERS)
> Simona Vetter <simona@ffwll.ch> (maintainer:DRM DRIVERS)
> dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR ROCKCHIP)
> linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support)
> linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC support)
> linux-kernel@vger.kernel.org (open list)
>
> I'm missing quite a few of these ...
I don't understand. I should cc all those addreses? All of them? :o
Regards,
Marius
>
> Cheers,
> Diederik
>
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
> > index 1479b8c4ed40..39cd38375e8a 100644
> > --- a/drivers/gpu/drm/rockchip/Kconfig
> > +++ b/drivers/gpu/drm/rockchip/Kconfig
> > @@ -67,6 +67,7 @@ config ROCKCHIP_CDN_DP
> >
> > config ROCKCHIP_DW_DP
> > bool "Rockchip specific extensions for Synopsys DW DP"
> > + select DRM_BRIDGE_CONNECTOR
> > help
> > This selects support for Rockchip SoC specific extensions
> > to enable Synopsys DesignWare Cores based DisplayPort transmit
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] drm: rockchip-dw-dp: add missing dependency on bridge_connector
2026-03-20 7:14 ` Marius Dinu
@ 2026-03-20 12:57 ` Diederik de Haas
2026-03-21 21:47 ` Marius Dinu
0 siblings, 1 reply; 5+ messages in thread
From: Diederik de Haas @ 2026-03-20 12:57 UTC (permalink / raw)
To: Marius Dinu; +Cc: Marius Dinu, linux-rockchip, Andy Yan
On Fri Mar 20, 2026 at 8:14 AM CET, Marius Dinu wrote:
> On Thu, 2026-03-19 18.56.59 ++0100, Diederik de Haas wrote:
>> On Thu Mar 19, 2026 at 4:50 PM CET, Marius Dinu wrote:
>> > Avoids this error:
>> > ld: drivers/gpu/drm/rockchip/dw_dp-rockchip.o: in function `dw_dp_rockchip_bind':
>> > /usr/src/linux/drivers/gpu/drm/rockchip/dw_dp-rockchip.c:108:(.text+0x188): undefined reference to `drm_bridge_connector_init'
>> >
>> > Signed-off-by: Marius Dinu <m95d+git@psihoexpert.ro>
>> > ---
>> > drivers/gpu/drm/rockchip/Kconfig | 1 +
>>
>> $ scripts/get_maintainer.pl drivers/gpu/drm/rockchip/Kconfig
>> Sandy Huang <hjc@rock-chips.com> (maintainer:DRM DRIVERS FOR ROCKCHIP)
>> "Heiko Stübner" <heiko@sntech.de> (maintainer:DRM DRIVERS FOR ROCKCHIP)
>> Andy Yan <andy.yan@rock-chips.com> (maintainer:DRM DRIVERS FOR ROCKCHIP)
>> Maarten Lankhorst <maarten.lankhorst@linux.intel.com> (maintainer:DRM DRIVERS AND MISC GPU PATCHES)
>> Maxime Ripard <mripard@kernel.org> (maintainer:DRM DRIVERS AND MISC GPU PATCHES)
>> Thomas Zimmermann <tzimmermann@suse.de> (maintainer:DRM DRIVERS AND MISC GPU PATCHES)
>> David Airlie <airlied@gmail.com> (maintainer:DRM DRIVERS)
>> Simona Vetter <simona@ffwll.ch> (maintainer:DRM DRIVERS)
>> dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR ROCKCHIP)
>> linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support)
>> linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC support)
>> linux-kernel@vger.kernel.org (open list)
>>
>> I'm missing quite a few of these ...
>
> I don't understand. I should cc all those addreses? All of them? :o
I usually 'To' the maintainers and 'Cc' the rest. See also
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#select-the-recipients-for-your-patch
HTH,
Diederik
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
>> > index 1479b8c4ed40..39cd38375e8a 100644
>> > --- a/drivers/gpu/drm/rockchip/Kconfig
>> > +++ b/drivers/gpu/drm/rockchip/Kconfig
>> > @@ -67,6 +67,7 @@ config ROCKCHIP_CDN_DP
>> >
>> > config ROCKCHIP_DW_DP
>> > bool "Rockchip specific extensions for Synopsys DW DP"
>> > + select DRM_BRIDGE_CONNECTOR
>> > help
>> > This selects support for Rockchip SoC specific extensions
>> > to enable Synopsys DesignWare Cores based DisplayPort transmit
>>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] drm: rockchip-dw-dp: add missing dependency on bridge_connector
2026-03-20 12:57 ` Diederik de Haas
@ 2026-03-21 21:47 ` Marius Dinu
0 siblings, 0 replies; 5+ messages in thread
From: Marius Dinu @ 2026-03-21 21:47 UTC (permalink / raw)
To: Diederik de Haas; +Cc: Marius Dinu, linux-rockchip, Andy Yan
On Fri, 2026-03-20 13.57.38 ++0100, Diederik de Haas wrote:
> On Fri Mar 20, 2026 at 8:14 AM CET, Marius Dinu wrote:
> > On Thu, 2026-03-19 18.56.59 ++0100, Diederik de Haas wrote:
> >> On Thu Mar 19, 2026 at 4:50 PM CET, Marius Dinu wrote:
> >> > Avoids this error:
> >> > ld: drivers/gpu/drm/rockchip/dw_dp-rockchip.o: in function `dw_dp_rockchip_bind':
> >> > /usr/src/linux/drivers/gpu/drm/rockchip/dw_dp-rockchip.c:108:(.text+0x188): undefined reference to `drm_bridge_connector_init'
> >> >
> >> > Signed-off-by: Marius Dinu <m95d+git@psihoexpert.ro>
> >> > ---
> >> > drivers/gpu/drm/rockchip/Kconfig | 1 +
> >>
> >> $ scripts/get_maintainer.pl drivers/gpu/drm/rockchip/Kconfig
> >> Sandy Huang <hjc@rock-chips.com> (maintainer:DRM DRIVERS FOR ROCKCHIP)
> >> "Heiko Stübner" <heiko@sntech.de> (maintainer:DRM DRIVERS FOR ROCKCHIP)
> >> Andy Yan <andy.yan@rock-chips.com> (maintainer:DRM DRIVERS FOR ROCKCHIP)
> >> Maarten Lankhorst <maarten.lankhorst@linux.intel.com> (maintainer:DRM DRIVERS AND MISC GPU PATCHES)
> >> Maxime Ripard <mripard@kernel.org> (maintainer:DRM DRIVERS AND MISC GPU PATCHES)
> >> Thomas Zimmermann <tzimmermann@suse.de> (maintainer:DRM DRIVERS AND MISC GPU PATCHES)
> >> David Airlie <airlied@gmail.com> (maintainer:DRM DRIVERS)
> >> Simona Vetter <simona@ffwll.ch> (maintainer:DRM DRIVERS)
> >> dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR ROCKCHIP)
> >> linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support)
> >> linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC support)
> >> linux-kernel@vger.kernel.org (open list)
> >>
> >> I'm missing quite a few of these ...
> >
> > I don't understand. I should cc all those addreses? All of them? :o
>
> I usually 'To' the maintainers and 'Cc' the rest. See also
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#select-the-recipients-for-your-patch
>
> HTH,
> Diederik
Something changed in v7-rc4. The error is gone. It seems this is probably not needed anymore.
But thanks for info about the mailing lists. I'll keep that in mind next time.
Marius
>
> >> > 1 file changed, 1 insertion(+)
> >> >
> >> > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
> >> > index 1479b8c4ed40..39cd38375e8a 100644
> >> > --- a/drivers/gpu/drm/rockchip/Kconfig
> >> > +++ b/drivers/gpu/drm/rockchip/Kconfig
> >> > @@ -67,6 +67,7 @@ config ROCKCHIP_CDN_DP
> >> >
> >> > config ROCKCHIP_DW_DP
> >> > bool "Rockchip specific extensions for Synopsys DW DP"
> >> > + select DRM_BRIDGE_CONNECTOR
> >> > help
> >> > This selects support for Rockchip SoC specific extensions
> >> > to enable Synopsys DesignWare Cores based DisplayPort transmit
> >>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-03-21 21:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-19 15:50 [PATCH v2] drm: rockchip-dw-dp: add missing dependency on bridge_connector Marius Dinu
2026-03-19 17:56 ` Diederik de Haas
2026-03-20 7:14 ` Marius Dinu
2026-03-20 12:57 ` Diederik de Haas
2026-03-21 21:47 ` Marius Dinu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox