From: Krzysztof Kozlowski <krzk@kernel.org>
To: Joseph Chen <chenjh@rock-chips.com>,
lee@kernel.org, lgirdwood@gmail.com, broonie@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v1 1/2] dt-bindings: mfd: Add rk801 binding
Date: Wed, 31 Dec 2025 08:33:30 +0100 [thread overview]
Message-ID: <ab933944-6a5f-4418-92fd-e77997656861@kernel.org> (raw)
In-Reply-To: <20251231030951.818-2-chenjh@rock-chips.com>
On 31/12/2025 04:09, Joseph Chen wrote:
> Add DT binding document for Rockchip's RK801 PMIC
>
> Signed-off-by: Joseph Chen <chenjh@rock-chips.com>
> ---
1. Please use scripts/get_maintainers.pl to get a list of necessary
people and lists to CC. It might happen, that command when run on an
older kernel, gives you outdated entries. Therefore please be sure you
base your patches on recent Linux kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.
Please kindly resend and include all necessary To/Cc entries.
2. Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).
3. Underscore is not allowed in node names. Neither capital letters.
Please read DTS coding style.
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-12-31 7:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-31 3:09 [PATCH v1 0/2] Add RK801 PMIC support Joseph Chen
2025-12-31 3:09 ` [PATCH v1 1/2] dt-bindings: mfd: Add rk801 binding Joseph Chen
2025-12-31 7:33 ` Krzysztof Kozlowski [this message]
2026-01-12 8:26 ` Joseph Chen
2025-12-31 13:36 ` Diederik de Haas
2026-01-12 8:14 ` Joseph Chen
2025-12-31 3:09 ` [PATCH v1 2/2] mfd: rk808: Add RK801 support Joseph Chen
2026-01-09 16:43 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab933944-6a5f-4418-92fd-e77997656861@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=chenjh@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox