From: Krzysztof Kozlowski <krzk@kernel.org>
To: shao.mingyin@zte.com.cn
Cc: ulf.hansson@linaro.org, changhuang.liang@starfivetech.com,
geert+renesas@glider.be, magnus.damm@gmail.com, heiko@sntech.de,
alim.akhtar@samsung.com, walker.chen@starfivetech.com,
sebastian.reichel@collabora.com, detlev.casanova@collabora.com,
finley.xiao@rock-chips.com, shawn.lin@rock-chips.com,
pgwipeout@gmail.com, qiu.yutan@zte.com.cn,
linux-pm@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, yang.yang29@zte.com.cn,
xu.xin16@zte.com.cn, yang.tao172@zte.com.cn,
ye.xingchen@zte.com.cn
Subject: Re: [PATCH v2] pmdomain: Use str_enable_disable-like helpers
Date: Wed, 11 Jun 2025 08:37:16 +0200 [thread overview]
Message-ID: <ad367080-5863-4131-b395-b39e2d357fb9@kernel.org> (raw)
In-Reply-To: <202506111010521118VJaiO_pb0rD7b3daxqox@zte.com.cn>
On 11/06/2025 04:10, shao.mingyin@zte.com.cn wrote:
>>> From: Shao Mingyin <shao.mingyin@zte.com.cn>
>>>
>>> Replace ternary (condition ? "enable" : "disable") syntax and ternary
>>> (condition ? "on" : "off") syntax with helpers from
>>> string_choices.h because:
>>> 1. Simple function call with one argument is easier to read. Ternary
>>> operator has three arguments and with wrapping might lead to quite
>>> long code.
>>> 2. Is slightly shorter thus also easier to read.
>>> 3. It brings uniformity in the text - same string.
>>> 4. Allows deduping by the linker, which results in a smaller binary
>>> file.
>>
>> So you just taken everything from the same my patch - even entire commit
>> subject and commit description - and sent it as yours?
>>
>> https://lore.kernel.org/all/20250114203547.1013010-1-krzysztof.kozlowski@linaro.org/
>>
>> oh my, if doing EXACTLY the same keep original authorship - the From and
>> Sob fields.
>>
>> Best regards,
>> Krzysztof
> Dear Krzysztof,
> Thank you for your suggestions. I have carefully read your advice and
> made adjustments to the patches accordingly. I used your patch as a
> reference standard, not just taking everything from the same your patch.
>
> Based on your suggestion, I have consolidated the series of patches for
I did not suggest to take everything from my patch, add one missing
change and use as yours.
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-06-11 6:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 11:34 [PATCH v2] pmdomain: Use str_enable_disable-like helpers shao.mingyin
2025-06-10 12:32 ` Krzysztof Kozlowski
2025-06-11 2:10 ` shao.mingyin
2025-06-11 6:37 ` Krzysztof Kozlowski [this message]
2025-06-12 1:12 ` 回复: " Changhuang Liang
2025-06-12 15:53 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad367080-5863-4131-b395-b39e2d357fb9@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=changhuang.liang@starfivetech.com \
--cc=detlev.casanova@collabora.com \
--cc=finley.xiao@rock-chips.com \
--cc=geert+renesas@glider.be \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=pgwipeout@gmail.com \
--cc=qiu.yutan@zte.com.cn \
--cc=sebastian.reichel@collabora.com \
--cc=shao.mingyin@zte.com.cn \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=walker.chen@starfivetech.com \
--cc=xu.xin16@zte.com.cn \
--cc=yang.tao172@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox