From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48207C43458 for ; Mon, 6 Jul 2026 07:20:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vkuUxGQ0uFrxtOPinhR8L41LkvCWotjCfYcmskbbwnI=; b=dY0MZ7ZW+pFy2u+iKJ7W8sqGpK 47nlhcRRLMC/eNhMVujCJo5z0/Mzfap+qjR6O8jY7d0iR+/N6v+ctlRwJpw2d8ZUZ8mfCzhCJ99SR QPBlSwdVyJAst972DqG2DjCfwnfLJJppctDaYsOnSV+yH45EXKUCEHJ41CXPgHX/0SV5Fe0tGGyt2 k0M2/T2FA1w+Kwl6hC6/w6lW5aNtxBumNuN0Xo12iu0mCuYR3ctjsWBwFGEaN0npdY6mUwtR61nYk tUkmNZ4udPhjtw0uECmhavbjiSZF9xn+VkDPXva213zeEsXrqgNUss16FTiocHj7kmHH+Y2qo9jsc 4wBc1OuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgdcR-0000000BiN3-1HUv; Mon, 06 Jul 2026 07:19:55 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgdcO-0000000BiL0-1pRm for linux-rockchip@lists.infradead.org; Mon, 06 Jul 2026 07:19:54 +0000 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-4720d22c94aso2637502f8f.1 for ; Mon, 06 Jul 2026 00:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783322390; x=1783927190; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VIt88eh6zWv+oEhKK/Aw514C6mk0Vd1i5LusZK/Ssuc=; b=m9ANpRyHkZO0DNPZ5tpdKb0G3H+1KfZJD+iijO0+3zVOCMeat9lBhEHGTgN3E7M8XZ WXh7qCsaJBM+yO/5fkUF0Lu0pCcNCLbOWhCgrOszKtcULKYXcyc00lP3rZufIl7SwMrU ykyCW0/4gevAjru7WnD5k76uK5Wq2JAgykYL7h0CviZ7+wSV+8R6vL3bD8D10u5dTFJv 173DwNZa8s64Wr116PGM3q+fo3wm8zefAgLyq0KnGcc2oRlTxgNbwFocN7ECat6AH0hH lxeyz0kz3lsUWkeEISCGaAA/xVzvhTEhHXC44s0E0d27RjGEp7dGrPwUdFruXU2pV86A SGew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783322390; x=1783927190; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VIt88eh6zWv+oEhKK/Aw514C6mk0Vd1i5LusZK/Ssuc=; b=doR15iQWLNR2FB6dSMmO1VLT17UjywukzciLDNF91jWAVpNjtyi6UwAiPFq0buWWlf cCdlWoZk3licFEjsQDuG1UVThWd4GEDiNfnp6n0DtqlaW9PBsPoRTBh9p0yPordxGvR6 m7nraY2Q8szUijqj+m/GSoQmZWQcU/dPZOimw1VQsvEQGscEietuziI0EETHGfGYoLwO fCfFmy17b2ZrIhP2tPXvftIxUixv5QExx40/ErHdChqMPjDwbij6vDvZIl4ConmX+mp5 uS6MHKcci/dq4a0tGp5dpnJDC4s9gh05XyHEuu6IQbGlQ5OdF5+R7viSITZW+p16Qr6J cZ5g== X-Forwarded-Encrypted: i=1; AHgh+RqZPT1Y71/WyGXo0tsH+QIEZ3fOsLhvsga0BlcoEKCE88mVzsYfzO9UIVy3Gjq1ldJGM1U/7r89dJXDMPEqCg==@lists.infradead.org X-Gm-Message-State: AOJu0YyW8L2RxoQiNaxK5grknRP3PIcBIEZQ8gFw89jZHY7MVrOUEd5y NxWW48sbF4r1rVkGxvdSg8qlldne940ay7Gbw/Pr0NCBYjyQomkQsZObc+nM/lBmacY= X-Gm-Gg: AfdE7cnNaZFYX5BAKpH/6X3Mmo0pyB0kysFnzNLKNmX9QeDYVAWbxqgCMUEwhk7LKBB 7HUtKRRvto038SKKOlVVa5wdpiWedYvf4sDOsJU2+RBCkq7urZrQd1OO7QtMLn6CYeYC4ROqIce tz+Z52jNn9j7uz3qNb6xuNEdOFpHYCKozIYdUFR2TaodKYDLkq8C9UZR1hPCJSd31drUF1ycBr6 qfawFqfkQlF+LGGhRdSGzigtGdmyZ27/nCX1skNHMU8d6ZTcsT6NSDnuusrIxjyKFtVL5op04OL hPpi8JhJuVoe5645f56VJ0TS0fAqs443kkUDo4J656q9PlkK12vZfNKZ247fSGWWUr8ONG8GqmS +rSqkVoPUb/f64w+eTOa1gUcI0WhcuySN4Y87Eslmdk/rlZ+xl9aXC8EzJ3Zvjd/rp0I9yDmoDY 5ntqrlw9PlDqEFYsOiMatzyvm1Uy17qgGNbHbfzAfXsDHdMzN8GPXdXPr987urmp99/vPhajOlc psk X-Received: by 2002:a05:6000:d4f:b0:478:4de8:9b91 with SMTP id ffacd0b85a97d-47aac7d018dmr7577860f8f.41.1783322390409; Mon, 06 Jul 2026 00:19:50 -0700 (PDT) Received: from localhost (p200300f65f47db0426af56a07ec3b32d.dip0.t-ipconnect.de. [2003:f6:5f47:db04:26af:56a0:7ec3:b32d]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47aa039bcdasm23183058f8f.21.2026.07.06.00.19.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 00:19:49 -0700 (PDT) Date: Mon, 6 Jul 2026 09:19:47 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Chen Wang Cc: linux-pwm@vger.kernel.org, Sven Peter , Janne Grunau , Neal Gompa , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Florian Fainelli , Benson Leung , Guenter Roeck , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Vladimir Zapolskiy , Piotr Wojtaszczyk , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Paul Walmsley , Samuel Holland , Michael Walle , Inochi Amaoto , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Hammer Hsieh , Nobuhiro Iwamatsu , Alexey Charkov , Sean Anderson , Michal Simek , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, sophgo@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays Message-ID: References: <20de6cd60c2938aad2d21397b92742849418ab1b.1783263835.git.ukleinek@kernel.org> <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> MIME-Version: 1.0 In-Reply-To: <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260706_001952_525321_6AFB36A6 X-CRM114-Status: GOOD ( 19.55 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2866505570122658855==" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org --===============2866505570122658855== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="64vjgbl764osolti" Content-Disposition: inline --64vjgbl764osolti Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays MIME-Version: 1.0 Hello Chen, On Mon, Jul 06, 2026 at 08:33:47AM +0800, Chen Wang wrote: > On 7/5/2026 11:14 PM, Uwe Kleine-K=C3=B6nig (The Capable Hub) wrote: > > - Use a single space in a of_device_id array terminator; A single spa= ce > > after the opening { and before the closing } in non-empty > > initializers; > > - No comma after an array terminator; > > - Also no trailing comma after a named initializer iff the > iff -> if This is actually intended. iff =3D "if and only if", see e.g. https://en.wikipedia.org/wiki/If_and_only_if . > > closing } is on the same line; > >=20 > > Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) >=20 > [......] >=20 > > diff --git a/drivers/pwm/pwm-sophgo-sg2042.c b/drivers/pwm/pwm-sophgo-s= g2042.c > > index 7d07b0ca7d29..0b6461172e6a 100644 > > --- a/drivers/pwm/pwm-sophgo-sg2042.c > > +++ b/drivers/pwm/pwm-sophgo-sg2042.c > > @@ -225,11 +225,10 @@ static const struct sg2042_chip_data sg2044_chip_= data =3D { > > static const struct of_device_id sg2042_pwm_ids[] =3D { > > { > > .compatible =3D "sophgo,sg2042-pwm", > > - .data =3D &sg2042_chip_data > > - }, > > - { > > + .data =3D &sg2042_chip_data, > > + }, { > > .compatible =3D "sophgo,sg2044-pwm", > > - .data =3D &sg2044_chip_data > > + .data =3D &sg2044_chip_data, > > }, > > { } > > }; >=20 > Changes to sophgo related files=EF=BC=9A >=20 > Reviewed-by: Chen Wang Thanks Uwe --64vjgbl764osolti Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpLVxEACgkQj4D7WH0S /k6otAf+MDN98V1OLHB7JSvapxuE4DwDpddJFumdMe3z/vu/P/VdI1oEao4PKhGo 2fMsJUgJT4k/6wIfoB6C3asAQFoEg3UirigbTf0d26+LpcWXfr+MJ/e2tzlX/Yzn 2dH88yKAhOR4HFj73YAi1FscS6vtyPmk7w2A84lWRMvteeY+zJan75O9xwgRC7FX gEMJExnAEBHY9tEW8dgB3EK07MFFQWLlVpGQll6BbLHxOcMIz17Pj/sI6+7Sv0xW cahUhiwZ1m+Y0EElAHIwQFoWyyyg7KINbFYsCsnyL1ev/EbUFyGCMRuR270OEIJW bKMoVE2keTYc8IQjmKqk7x/VPRLsTw== =LX/u -----END PGP SIGNATURE----- --64vjgbl764osolti-- --===============2866505570122658855== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip --===============2866505570122658855==--