Re: [PATCH v16 04/10] iio: imu: inv_icm42607: Add inv_icm42607 Core Driver - Uwe Kleine-König

From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: linux-iio@vger.kernel.org, andy@kernel.org, nuno.sa@analog.com,
	 dlechner@baylibre.com, jic23@kernel.org,
	jean-baptiste.maneyrol@tdk.com,
	 linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	heiko@sntech.de, conor+dt@kernel.org,  krzk+dt@kernel.org,
	robh@kernel.org, andriy.shevchenko@intel.com,
	 Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH v16 04/10] iio: imu: inv_icm42607: Add inv_icm42607 Core Driver
Date: Tue, 14 Jul 2026 14:18:53 +0200	[thread overview]
Message-ID: <alYoUSf_jGegFP9E@monoceros> (raw)
In-Reply-To: <20260713215842.69097-5-macroalpha82@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 988 bytes --]

Hello,

On Mon, Jul 13, 2026 at 04:58:34PM -0500, Chris Morgan wrote:
> +#include <linux/i2c.h>
> +#include <linux/mod_devicetable.h>

Please don't use <linux/mod_devicetable.h>, to get i2c_device_id and
of_device_id it's enough to have <linux/i2c.h>.

> +static const struct i2c_device_id inv_icm42607_id[] = {
> +	{
> +		.name = "icm42607",
> +		.driver_data = (kernel_ulong_t)&inv_icm42607_hw_data,
> +	}, {
> +		.name = "icm42607p",
> +		.driver_data = (kernel_ulong_t)&inv_icm42607p_hw_data,
> +	},
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(i2c, inv_icm42607_id);
> +
> +static const struct of_device_id inv_icm42607_of_matches[] = {
> +	{
> +		.compatible = "invensense,icm42607",
> +		.data = &inv_icm42607_hw_data,
> +	}, {
> +		.compatible = "invensense,icm42607p",
> +		.data = &inv_icm42607p_hw_data,
> +	},
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, inv_icm42607_of_matches);

It would be enough to provide the driver_data pointers in the
i2c_device_id array only.

Best regards
Uwe

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip