Linux-Rockchip Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Caesar Wang <caesar.upstream@gmail.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Caesar Wang <wxt@rock-chips.com>,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] clocksource: rockchip: Make the driver more readability and compatible
Date: Thu, 17 Sep 2015 12:19:18 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.11.1509171217080.3951@nanos> (raw)
In-Reply-To: <55FA9099.7000903@linaro.org>

On Thu, 17 Sep 2015, Daniel Lezcano wrote:
> On 09/17/2015 11:28 AM, Caesar Wang wrote:
> > > I think the NO_IRQ definition is missing for ARM64.
> > 
> > Yep, Maybe better to compatible if we don't use the 'NO_IRQ',
> 
> Hmm, after digging into drivers/of/irq.c and kernel/irq/irqdomain.c
> 
> when there is an error it returns zero. So NO_IRQ and -1 are not correct and
> on the other side zero can be a valid irq. That sounds a little bit fuzzy to
> me.

IRQ0 is invalid for historical reasons. End of story.

Thanks,

	tglx

  reply	other threads:[~2015-09-17 10:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17  7:51 [PATCH 0/3] Support the timer on RK3368 SoC Caesar Wang
2015-09-17  7:51 ` [PATCH 1/3] clocksource: rockchip: Make the driver more readability and compatible Caesar Wang
2015-09-17  9:11   ` Daniel Lezcano
2015-09-17  9:28     ` Caesar Wang
2015-09-17  9:43       ` Heiko Stübner
2015-09-17 10:06       ` Daniel Lezcano
2015-09-17 10:19         ` Thomas Gleixner [this message]
2015-09-17 10:57           ` Daniel Lezcano
2015-09-17 21:13             ` Russell King - ARM Linux
2015-09-18  7:53               ` Daniel Lezcano
2015-09-17 10:19         ` Caesar Wang
2015-09-18  7:55           ` Daniel Lezcano
2015-09-18  8:22             ` Caesar Wang
2015-09-18  9:08             ` Russell King - ARM Linux
2015-09-17  7:51 ` [PATCH 3/3] arm64: dts: rockchip: Add the needed timer for rk3368 SoC Caesar Wang
     [not found]   ` <1442476272-31723-4-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-09-17 19:01     ` Heiko Stübner
2015-09-18  1:16       ` Caesar Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1509171217080.3951@nanos \
    --to=tglx@linutronix.de \
    --cc=caesar.upstream@gmail.com \
    --cc=catalin.marinas@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=will.deacon@arm.com \
    --cc=wxt@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox