From: Rudi Heitbaum <rudi@heitbaum.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Matthias Kaehlcke <mka@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: onboard_dev: add the Rockchip rk1808
Date: Fri, 28 Aug 2026 10:55:56 +0000 [thread overview]
Message-ID: <apFpPP1O45BWXDv5@5be1eda4e59e> (raw)
In-Reply-To: <5096877.GXAFRqVoOG@phil>
On Thu, Aug 27, 2026 at 03:25:23PM +0200, Heiko Stuebner wrote:
> Hi Rudi,
>
> Am Montag, 24. August 2026, 04:52:02 Mitteleuropäische Sommerzeit schrieb Rudi Heitbaum:
> > The rk1808 is the npu die in an rk3399pro package. It is wired to one
> > of the usb3 controllers rather than to an external port, and it needs
> > its reference clock running before it will boot, which is exactly what
> > this driver exists to do for onboard devices.
> >
> > It takes no supply from the driver: the rails are sequenced elsewhere.
> > Only the clock matters here, and that is already optional and handled
> > generically.
>
> the "elsewhere" might need a bit more explanation to verify it's the right
> implementation. Even if the regulators are always-on or something, we
> still want the supplies defined - for future uses.
Hi Heiko,
As follow up on the bringup of the Rock-Pi-N10, the proposed change to the dtsi
for the rk3399pro-vmarc-som is here, but needs the provision of the usb first.
https://github.com/heitbaum/linux/commit/6b114b6fff4022c330003d7f70ce09915ffd774f
Thanks
Rudi
> Thanks
> Heiko
>
>
> > Two ids, because the die changes identity as it boots: 180a while it is
> > in maskrom and then in the rockusb loader, 1808 once it is running.
> >
> > Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com>
> > ---
> > drivers/usb/misc/onboard_usb_dev.h | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/usb/misc/onboard_usb_dev.h b/drivers/usb/misc/onboard_usb_dev.h
> > index 3523f8f8a149..e07f509ac751 100644
> > --- a/drivers/usb/misc/onboard_usb_dev.h
> > +++ b/drivers/usb/misc/onboard_usb_dev.h
> > @@ -134,6 +134,12 @@ static const struct onboard_dev_pdata xmos_xvf3500_data = {
> > .is_hub = false,
> > };
> >
> > +static const struct onboard_dev_pdata rockchip_rk1808_data = {
> > + .reset_us = 0,
> > + .num_supplies = 0,
> > + .is_hub = false,
> > +};
> > +
> > static const struct of_device_id onboard_dev_match[] = {
> > { .compatible = "usb-a-connector", .data = &usb_a_conn_data, },
> > { .compatible = "usb424,2412", .data = µchip_usb424_data, },
> > @@ -167,6 +173,8 @@ static const struct of_device_id onboard_dev_match[] = {
> > { .compatible = "usb2109,817", .data = &vialab_vl817_data, },
> > { .compatible = "usb2109,2817", .data = &vialab_vl817_data, },
> > { .compatible = "usb20b1,0013", .data = &xmos_xvf3500_data, },
> > + { .compatible = "usb2207,1808", .data = &rockchip_rk1808_data, },
> > + { .compatible = "usb2207,180a", .data = &rockchip_rk1808_data, },
> > { .compatible = "usb3431,6241", .data = &corechips_sl6341_data, },
> > { .compatible = "usb3431,6341", .data = &corechips_sl6341_data, },
> > { .compatible = "usb5986,1198", .data = &bison_intcamera_data, },
> >
>
>
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-08-28 10:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 2:52 [PATCH] usb: onboard_dev: add the Rockchip rk1808 Rudi Heitbaum
2026-08-27 13:25 ` Heiko Stuebner
2026-08-28 10:55 ` Rudi Heitbaum [this message]
2026-08-28 12:14 ` Heiko Stübner
2026-08-28 13:24 ` Rudi Heitbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apFpPP1O45BWXDv5@5be1eda4e59e \
--to=rudi@heitbaum.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox