From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A0E9CA5FCE for ; Thu, 1 Oct 2026 21:34:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4pC/IE3JXmxTx2N/veByBTiPpADyJduvXYlejlaAecg=; b=egQxUJwoegSeH26WhcxcWPiW8C 1290b1aTtYy9SXSWBaAVRXgZvQj7GPtPEmACs2e1iP9iW3PmTxLzJJmUYrCSg+r0hlVEY+A8yPeh0 jTwqCPd5ditgTcXmEq+T/lZC9CIyWVEqvKlBaCMjmvV6u7lJh7IOroTZTMpMZ6Q/MVdgHao/wIKmn /8HgGrDz1F+nql8oHYo6p9Dld7d+0v2RaJV6VWKLb58zan1Jy/i3t1ESokcBcXe56psYBvyN8RCW7 fFT+I6dM9iHtAr2uSf8Ng8ZOBZoE7xd6wlTXg0fyuB7M3GjsHF0MY7zZczLk/PnwhTuSx6YkS2OtZ JxOsU1Yw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xCOQR-0000000AHPI-2S0e; Thu, 01 Oct 2026 21:34:47 +0000 Received: from sender5-op-o11.zoho.com ([165.173.182.11]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xCOQM-0000000AHMp-06Sz; Thu, 01 Oct 2026 21:34:45 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1790890471; cv=none; d=zohomail.com; s=zohoarc; b=EbKuzb52YVqERGRFJkrQaBnSvOMgmiko/rjly+R/Sk2zQ5x9E6DpEpqcZls9uZq5u3MTJjinb83h20FZpckl6zsv8TjjHaxrsd4Okso0q+tbfOQWfjDlV7lGtx2P4W+r9LPiX8AAGN1poFT8QwpdDPg9zcKmEAuQ1kiT7J4HDVo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1790890471; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=4EQaDthGXG//tsvqp7HRqH9/THSqJf0NMZqmFez268g=; b=aKYzI4kbX3mQfbzB4hrGMMsln1laSCIO8OQDAy9GTS84j743hJAU5YMt5C9DKux/xHu26VzbIw92TS1sIKCZoY/Eg2+C+pUGZj+BcoiUjvvKqe6vbLE7GCYecNv6MMyrjqLY7jUOUA4d2HZ+GL9m2yhHC4EWFziDPMTA/LjD5EE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=sebastian.reichel@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1790890471; s=zohomail; d=collabora.com; i=sebastian.reichel@collabora.com; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:MIME-Version:Content-Type:In-Reply-To:Message-Id:Reply-To; bh=4EQaDthGXG//tsvqp7HRqH9/THSqJf0NMZqmFez268g=; b=f3gET3cB025CNa0Qgg4+m5wT2IfXkKP98VLGUYb+hjHCTUEuxOTaxs3Z6TfjfFMB ew9xpGX+JeZ7DysneYao4jyddWLacnylzMsjMnilRZlw23s81qVggPegL+0+2CLkFHb PDFHb09nVf55UtRUbcmG63qdvTdMqWU9KtN1JdeA= Received: by smtp.zohomail.com with SMTPS id 1790890469129854.6980276600326; Thu, 1 Oct 2026 14:34:29 -0700 (PDT) Received: by venus (Postfix, from userid 1000) id 860C5180944; Thu, 01 Oct 2026 23:34:25 +0200 (CEST) Date: Thu, 1 Oct 2026 23:34:25 +0200 From: Sebastian Reichel To: Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Heiko Stuebner Cc: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Igor Paunovic , kernel@collabora.com Subject: Re: [PATCH v2 0/4] phy: rockchip: inno-usb2: ensure PHY is running when clock is requested Message-ID: References: <20261001-phy-rockchip-inno-usb2-clock-fix-v2-0-e01bf509359e@collabora.com> MIME-Version: 1.0 In-Reply-To: <20261001-phy-rockchip-inno-usb2-clock-fix-v2-0-e01bf509359e@collabora.com> X-Zoho-Virus-Status: 1 X-Zoho-AV-Stamp: zmail-av-0.2.13.1.5.4/290.865.66 X-ZohoMailClient: External X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261001_143442_150905_CEBF972C X-CRM114-Status: GOOD ( 25.78 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6061141581667428821==" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org --===============6061141581667428821== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hzbu3rdhu6gbb2rv" Content-Disposition: inline --hzbu3rdhu6gbb2rv Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v2 0/4] phy: rockchip: inno-usb2: ensure PHY is running when clock is requested MIME-Version: 1.0 Hi, On Thu, Oct 01, 2026 at 03:12:38PM +0200, Sebastian Reichel wrote: > This was noticed on RK3588 EVB1 when resuming from system suspend. This > is technically a fix, but its unclear when the bug was introduced and > system suspend is broken on RK3588 for quite a while and not just due > to this problem. So I think this fix can be merged the normal way via > linux-next. > > Changes in v2: > - Link to v1: https://patch.msgid.link/20260908-phy-rockchip-inno-usb2-cl= ock-fix-v1-1-f7d59c31b908@collabora.com > - Move suspend exit code from rockchip_usb2phy_power_on into a > separate patch and reuse it in the clock prepare function; > move is done in a separate patch > - Updated commit messages with proper rationale > - Added one more patch dropping useless assignment > of rport->suspended directly after calling > rockchip_usb2phy_power_on/off > - Add one more patch unifying and simplifying the debug > messages for phy init/power_on/power_off/exit I was too fast sending this out. While it fixes the problem on RK3588 EVB1 (used for testing this series), I just noticed it seems to introduce a new SError in DWC3 on RK3576 boards during boot. This is quite unexpected. I will investigate after LPC/OSSEU. For now please ignore this series. Sorry for the noise. Greetings, -- Sebastian >=20 > --- > To: Vinod Koul > To: Neil Armstrong > To: Manivannan Sadhasivam > To: Heiko Stuebner > Cc: linux-phy@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: Igor Paunovic > Cc: kernel@collabora.com > Signed-off-by: Sebastian Reichel >=20 > --- > Sebastian Reichel (4): > phy: rockchip: inno-usb2: simplify and unify PHY op debug messages > phy: rockchip: inno-usb2: drop duplicated update of rport->suspended > phy: rockchip: inno-usb2: move suspend handling into new function > phy: rockchip: inno-usb2: move suspend handling into clock prepare/= unprepare for RK3588/RK3576 >=20 > drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 85 +++++++++++++++++++--= ------ > 1 file changed, 59 insertions(+), 26 deletions(-) > --- > base-commit: cee9395acd8043be0644b25c34bfa86623f2b935 > change-id: 20260908-phy-rockchip-inno-usb2-clock-fix-edd65b57f884 >=20 > Best regards, > -- =20 > Sebastian Reichel >=20 >=20 --hzbu3rdhu6gbb2rv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmq+0doACgkQ2O7X88g7 +pqJ1Q/8D2Tm0nol7ppugtLlv6+/sdwq4bM5fAAPKW0jJ1tKChQ0rtF/DSXa8GR7 RbOLivmAi3u6osu+nV//YEB9FjnLaGZa2TEtUKCDB3EV6tuDMV3RnpVFMlxvQAvc 5YeS7oJaIf2OX/SErBlk86vhgMumSZAyB9UHMlNUhJB64WhLTfBMBpWGnqha7gmC CaajrdlNNXFOn5mDJ/dV1EeH448pLXjdKfqFUAJ0K1jBfv2VHQOishuCHJblHhEV GFseURltjpuPhBT3BrwW0d2D7Il/hNUgrGFbPv65HUc+lOMy6+O5TeARpeGmqj5f gn5FEJaPgohvSSs40+FJ6kzHnzJSTrGgG8FBtJRTllSs/v8o12vApJBYzkTzVSGT XP6xHWVepj8OOdoPpIH+8nWHg61O5lb2JPXrfCOHar8Mv+pDILTvepuiZhdwjrtD NnAECNdunKHNVx3u32HsLVLm1O+9lR8DgPhYkktVKwVaz74fK0mjcp9jueiT8Mqb cnV1GUtqVvRZHIDSirNElBcbo5neaEq5G3faKjvj7+gT4eS2gX6qiBrigkSGglbQ 58p/U+ELroD8RMPHtj0kr9wQYH8sHLU/0jVEbd/WecM0OEOVttxwwN+3Ee8uuDZ/ wFPK7EvIMK1ADW+xnlG24liyZCvOdHE4QBhpsCmuh9ob6CnjJzk= =4Wvh -----END PGP SIGNATURE----- --hzbu3rdhu6gbb2rv-- --===============6061141581667428821== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip --===============6061141581667428821==--