From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75B68C982FA for ; Tue, 22 Sep 2026 07:09:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=T/ZL6wo/9++WtglKjM37EIdFxbiGtCvaDiy4MenEJA4=; b=BOJAGWE/fUs4SmKwJYeGRbAS05 fa5SqxvMFi5RJqJsq76DOE9SHAUGuueQvI5NCSGvp169+vpOCSXlH1G66BZRl/oXztzmijM/6b8Ro lRv19garnB47jSGC4Lj+4F7bII0ubWY03M5M4JDA2+SlcSvr+pEVWkTCLVNdLVapxFwKG/gVEzaHA 4lQj/KOlSYbiHDYyIMwzZYJxy4DrD7WDYndjQ1bRzGuAGv+QUb/aWFN69DFBTmNmkt3u13pqzIAor DUxnXP6gjyPIVKqJu0t+J0tbgWNp2fbvKqOUA345hACXNeO6dF4WSIiazkn6lZx9Tkv8HEkCIA2HG nMSvB02g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8ud2-00000004SYd-03Wo; Tue, 22 Sep 2026 07:09:24 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x8ud0-00000004SY7-00O8; Tue, 22 Sep 2026 07:09:22 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 20633600CB; Tue, 22 Sep 2026 07:09:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DB211F000FF; Tue, 22 Sep 2026 07:09:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790060960; bh=DIWesvw9U8QZO9lMo1ZcRByJChbnPxGPEhvF31Eh9cc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=emxS0O2u3PqWdi1jxmKO79TQV2n0TKPHh+cGGQ9B9SKgyx6zrLI0Msuo4CTimSkOa kf0us14AGJsMEygCyMjqX4njWubYMOBLD/uEk0J1s9Gjt+grOwrOzF55EObQCKmXzH WES0gzewSNafYx5zurM1T56noD+gHuVwUdfFj1b5KSsWD9L0GetMdXsE+THl5/rEGZ xa+FfuetJ5ztYrMpbSpnWXurZMLEkYzsQahgVxb4b58AYGfOILObQnAOGHWv7vITTj sMbIJfy+WPl2WK/bw7sMOQYgq8wkmDodM3wE6YcFWXl4ywieKPy3zu2P6tCDiAiAIt z2YdS1e84J1Qw== Date: Tue, 22 Sep 2026 09:09:17 +0200 From: Maxime Ripard To: Luca Ceresoli Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Jessica Zhang , Laurentiu Palcu , Lucas Stach , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Paul Kocialkowski , Linus Walleij , Inki Dae , Jagan Teki , Marek Szyprowski , Sean Paul , Jonathan Corbet , Shuah Khan , Randy Dunlap , Albert Esteve , Anusha Srivatsa , Dmitry Baryshkov , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, asahi@lists.linux.dev, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-doc@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v3 12/19] drm/mcde: dsi: don't create a panel_bridge Message-ID: References: <20260916-drm-bridge-every-panel-v3-0-83afb4f1a707@bootlin.com> <20260916-drm-bridge-every-panel-v3-12-83afb4f1a707@bootlin.com> MIME-Version: 1.0 In-Reply-To: <20260916-drm-bridge-every-panel-v3-12-83afb4f1a707@bootlin.com> X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1390309533588065007==" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org --===============1390309533588065007== Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="ivxpm4gz74yd66ki" Content-Disposition: inline --ivxpm4gz74yd66ki Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v3 12/19] drm/mcde: dsi: don't create a panel_bridge MIME-Version: 1.0 On Wed, Sep 16, 2026 at 03:45:36PM +0200, Luca Ceresoli wrote: > Now a panel_bridge is automatically created for every drm_panel and the > panel-bridge API is just a deprecated wrapper to access it. >=20 > Update and simplify the code by just getting a reference to the > already-existing bridge using of_drm_find_and_get_bridge(). >=20 > Also keep the "connected to non-panel bridge (unsupported)\n" error logic > by using the drm_bridge_is_panel() function. >=20 > Signed-off-by: Luca Ceresoli > --- > drivers/gpu/drm/mcde/Kconfig | 1 - > drivers/gpu/drm/mcde/mcde_dsi.c | 41 +++++++++--------------------------= ------ > 2 files changed, 9 insertions(+), 33 deletions(-) >=20 > diff --git a/drivers/gpu/drm/mcde/Kconfig b/drivers/gpu/drm/mcde/Kconfig > index 6ebfb930cbfa..81e7d3796c06 100644 > --- a/drivers/gpu/drm/mcde/Kconfig > +++ b/drivers/gpu/drm/mcde/Kconfig > @@ -10,7 +10,6 @@ config DRM_MCDE > select DRM_MIPI_DSI > select DRM_BRIDGE > select DRM_PANEL > - select DRM_PANEL_BRIDGE > select DRM_KMS_HELPER > select DRM_GEM_DMA_HELPER > help > diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcde_= dsi.c > index 77cf253a2152..daac8d67913d 100644 > --- a/drivers/gpu/drm/mcde/mcde_dsi.c > +++ b/drivers/gpu/drm/mcde/mcde_dsi.c > @@ -37,7 +37,6 @@ struct mcde_dsi { > struct device *dev; > struct mcde *mcde; > struct drm_bridge bridge; > - struct drm_panel *panel; > struct mipi_dsi_host dsi_host; > struct mipi_dsi_device *mdsi; > const struct drm_display_mode *mode; > @@ -1074,7 +1073,6 @@ static int mcde_dsi_bind(struct device *dev, struct= device *master, > struct drm_device *drm =3D data; > struct mcde *mcde =3D to_mcde(drm); > struct mcde_dsi *d =3D dev_get_drvdata(dev); > - struct drm_panel *panel =3D NULL; > struct drm_bridge *bridge __free(drm_bridge_put) =3D NULL; > =20 > if (!of_get_available_child_count(dev->of_node)) { > @@ -1102,40 +1100,21 @@ static int mcde_dsi_bind(struct device *dev, stru= ct device *master, > =20 > /* Look for a panel as a child to this node */ > for_each_available_child_of_node_scoped(dev->of_node, child) { > - panel =3D of_drm_find_panel(child); > - if (IS_ERR(panel)) { > - dev_err(dev, "failed to find panel try bridge (%ld)\n", > - PTR_ERR(panel)); > - panel =3D NULL; > - > - bridge =3D of_drm_find_and_get_bridge(child); > - if (!bridge) { > - dev_err(dev, "failed to find bridge\n"); > - return -EINVAL; > - } > + bridge =3D of_drm_find_and_get_bridge(child); > + if (!bridge) { > + dev_err(dev, "failed to find bridge\n"); > + return -EINVAL; > } > =20 > - if (panel || bridge) > - break; > + break; > } > - if (panel) { > - bridge =3D drm_panel_bridge_add_typed(panel, > - DRM_MODE_CONNECTOR_DSI); > - drm_panel_put(panel); > - if (IS_ERR(bridge)) { > - dev_err(dev, "error adding panel bridge\n"); > - return PTR_ERR(bridge); > - } > - drm_bridge_get(bridge); > - dev_info(dev, "connected to panel\n"); > - d->panel =3D panel; > - } else if (bridge) { > + if (!bridge) { > + dev_err(dev, "no bridge\n"); > + return -ENODEV; > + } else if (!drm_bridge_is_panel(bridge)) { > /* TODO: AV8100 HDMI encoder goes here for example */ > dev_info(dev, "connected to non-panel bridge (unsupported)\n"); > return -ENODEV; I wonder if we still need that branch. Every panel is a bridge now, and it looks like we don't have any specific panel handling in this driver, so I guess it supports bridges already? Linus, do you know why this condition was here in the first place? Maxime --ivxpm4gz74yd66ki Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCarIpmAAKCRAnX84Zoj2+ dtjPAX4+J2ZR1yr2hmD3nVeJMvI8smwXK4y9hbFXhRPgKc1nywpXnsHpCTglFoIb qmbzuh0Bf1cHYt864QzBTzUfI+t/PJ9gbmGcYD7bX6+4GvcQhqZOW5GIw6Txx9Yy eOSqlKXvWg== =xo8g -----END PGP SIGNATURE----- --ivxpm4gz74yd66ki-- --===============1390309533588065007== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip --===============1390309533588065007==--