From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6950FC98302 for ; Wed, 23 Sep 2026 14:53:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b7FOB4ZDc/xrGl6TkiJ+L/ePAIu98FFch8PBtMoPImc=; b=2Y/iSZsAins3Uj kRUeipiwslTSr82u2ZUF53jPwLGTJpPwPCdGmMib1LvY3Jpng0wb/3ExNvg7aQuBh6napBOagifZz f8sXAT/Yx1mTVdORwzBtQHHtfbEeZm9PL7bbGG0Smo9grxmu8fQJslntG3zgapMLSfMPlAM6Vh9h2 mBbU4rzJT9H7/8aBRAIAIKH/LVcW8AGqf7WBGzCilUxcZC4xFMhG2ZD9rJ2lhsxl9qmbWjnnqWso9 JsCC2LD546ysS80iu61MKcl9Zm1LYLKBOpcbEGN8jLJWMujwxibA1H0leXLPnHODINhCetNDSm2P9 MYdfGF6VJlfGQbp4ggqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9OLr-00000008b5j-3db9; Wed, 23 Sep 2026 14:53:39 +0000 Received: from mgamail.intel.com ([192.198.163.9]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9OLo-00000008b52-1Trc; Wed, 23 Sep 2026 14:53:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1790175217; x=1821711217; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rtgRXOJibX/Ng8wRfBILO1C3FM5qnu9zYTXLpzgUldw=; b=brgbl4OFOitCQ/VGGww7u59VfBahH3vVT16+dXPN93JCLa70e+cUL843 L4P4/c71mRuokFTEE53AwhNAjTcgU3AguPq3j3KOaPcSEf7QFOEMcQKEE D/ZO8YUYi//yTZXCQmA9/FMe7H9FhSTAxsu0m4nmLm1JCpDB3KTcNmEBB Tp9TAjQJ2gCfrLm1JRazFab+noFWDssTC9LDW22DgYQY+DexbYNRqH88U GM9VFN3/e71FncNY/euUwK/o264NGNc78haw9pcGaGJmFnVOPtRJ9mCHO vj4JD0oXmuegi8uHnyzOvhlRkLwWU1LKXTXsZ7hWdsusScUcY4VxPhdCH A==; X-CSE-ConnectionGUID: XGhqeg+zRbasAYXiSpQgzw== X-CSE-MsgGUID: Hq6pR9E+SBueEpXM7avsfA== X-IronPort-AV: E=McAfee;i="6800,10657,11913"; a="101541365" X-IronPort-AV: E=Sophos;i="6.27,118,1787036400"; d="scan'208";a="101541365" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2026 07:53:36 -0700 X-CSE-ConnectionGUID: AICcPkvZQO+s+aSZ5YkSDw== X-CSE-MsgGUID: Twm0/f/ERxSynu2tD3NGbg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,118,1787036400"; d="scan'208";a="272251112" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl) ([10.245.244.54]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2026 07:53:33 -0700 Date: Wed, 23 Sep 2026 16:53:26 +0200 From: Mehdi Djait To: Amin Gattout Cc: Michael Riesch , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/5] media: rockchip: rkcif: add a callback for the MIPI ID_CTRL1 register Message-ID: References: <20260921-vicap-rk3576-v2-0-0a4582e20c72@gmail.com> <20260921-vicap-rk3576-v2-3-0a4582e20c72@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260921-vicap-rk3576-v2-3-0a4582e20c72@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260923_075336_782586_4D175CBF X-CRM114-Status: GOOD ( 12.56 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hello Amin, Thank you for the patch! On Mon, Sep 21, 2026 at 05:29:59PM +0200, Amin Gattout wrote: > The contents of the MIPI ID_CTRL1 register differ between variants. The > RK3568 and RK3588 hold the capture size there, while the RK3576 uses it > for the virtual channel and data type filter. > > Let each variant provide a callback that builds the register value, in > preparation for the RK3576 support. Variants that do not provide one > keep writing the capture size, so their behavior is unchanged. > Reviewed-by: Mehdi Djait > Signed-off-by: Amin Gattout -- Kind Regards Mehdi Djait _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip