From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58E95C9830B for ; Wed, 23 Sep 2026 14:57:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1UnbYQ83hxKRkb25qkyetx50JBWFmfivx8HRC8mQMZY=; b=e8g9teODF1m+Wz qNzo/bbUuSdh0q5vL1/UWnmiOmdz7CCOlnDmO/a93SRO+CjebMTik89l5wo9SFfrb6ezahezWauy4 2fuRFrs9CQ9Ghal81lUADWQWaS9DSAWm0MHdGrO9+Ah/LNSaXDnMdEmBKFF/2doSTs0CgkXcnL1aI B3FnCnz+AA2UlYLHjWdLEzr1skXMQqXfqCYbkx3aVZfqR+0uqA6OCqnUfCc2IUUtTDea5GYbuLf9z PU/TvqGNkY6TtnAk/5jgtEXxS29Of8lQB+zaE0iWCwKYASuN4Fabs6zIUgT8ILtRXI1Rn526sAToV aefkvgx3MNVhijq9n5iA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9OP4-00000008bWC-2HsB; Wed, 23 Sep 2026 14:56:58 +0000 Received: from mgamail.intel.com ([192.198.163.15]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x9OOy-00000008bUt-2J7K; Wed, 23 Sep 2026 14:56:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1790175412; x=1821711412; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+NoCwNQno1x3g8OGbl0mW+5uJcHCveny72+JeTY7Ez0=; b=XoollXcBmiNB2tb/4PVotc1uiAkUbWHHKxwE/y/F8xD28x1sH+2uRSNC qkC+4CAVrFuLsR0xq2yBylAPPO6zHxgrAZ3pLQ5jc5qeZqhqtzcfw2t0G pddtB+kOJb7oeSehdWWUYVPhOgrqq3Lo6FjyLoslv+EL5fiWAmY4Gvvur szWOW8j9nvPbcp6vngQqGB7ZL9HSpoHHvYKZu7IeYfce2+pE8WiK97NYc GqHSS8o8ULiuN/n0pY7IwHsX+AX3RGHEPAajIpqncOvRXuZN1qJOPSmhg J3B3yRqFW46/pCXL9Ou5jSyaIGyPtClPec/QecDmStwD5r2EMlzNY4ris A==; X-CSE-ConnectionGUID: +cypgvSkRUep44/PtZte1Q== X-CSE-MsgGUID: a6yvdw5MTFW+aFL3Yqxyfg== X-IronPort-AV: E=McAfee;i="6800,10657,11913"; a="90994725" X-IronPort-AV: E=Sophos;i="6.27,118,1787036400"; d="scan'208";a="90994725" Received: from fmviesa011.fm.intel.com ([10.60.135.151]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2026 07:56:51 -0700 X-CSE-ConnectionGUID: Ttchn/a4TTCaFMrPmeaoOQ== X-CSE-MsgGUID: olsR4xbuTqq4VohNXYcoVg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,118,1787036400"; d="scan'208";a="4730903" Received: from cpetruta-mobl1.ger.corp.intel.com (HELO mdjait-mobl) ([10.245.244.54]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2026 07:56:49 -0700 Date: Wed, 23 Sep 2026 16:56:41 +0200 From: Mehdi Djait To: Amin Gattout Cc: Michael Riesch , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] arm64: dts: rockchip: add vicap node to rk3576 Message-ID: References: <20260921-vicap-rk3576-v2-0-0a4582e20c72@gmail.com> <20260921-vicap-rk3576-v2-5-0a4582e20c72@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260921-vicap-rk3576-v2-5-0a4582e20c72@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260923_075652_786788_BAB980A2 X-CRM114-Status: GOOD ( 17.35 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hello Amin, Thank you for the patch! On Mon, Sep 21, 2026 at 05:30:01PM +0200, Amin Gattout wrote: > Add the device tree node for the Video Capture (VICAP) unit of the > RK3576 and its IOMMU, and connect the VICAP to the two MIPI CSI-2 > receivers that are usable with the MIPI D-PHYs in full mode. > Reviewed-by: Mehdi Djait > Reviewed-by: Michael Riesch > Signed-off-by: Amin Gattout > --- > arch/arm64/boot/dts/rockchip/rk3576.dtsi | 83 ++++++++++++++++++++++++++++++++ > 1 file changed, 83 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi > index cbf8b70cc15a..0c46accf5657 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi > @@ -1323,6 +1323,81 @@ vdec_mmu: iommu@27b00800 { > rockchip,disable-mmu-reset; > #iommu-cells = <0>; > }; small nit: Maybe add a blank line before vicap. > + vicap: video-capture@27c10000 { > + compatible = "rockchip,rk3576-vicap"; > + reg = <0x0 0x27c10000 0x0 0x800>; > + interrupts = ; > + clocks = <&cru ACLK_VICAP>, <&cru HCLK_VICAP>, > + <&cru DCLK_VICAP>, > + <&cru CLK_VICAP_I0CLK>, <&cru CLK_VICAP_I1CLK>, > + <&cru CLK_VICAP_I2CLK>, <&cru CLK_VICAP_I3CLK>, > + <&cru CLK_VICAP_I4CLK>; [..] -- Kind Regards Mehdi Djait _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip