From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AF1CC9830E for ; Fri, 25 Sep 2026 13:26:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ec3JxAEp5/SlSHF5vA8VF2phzwpRTUy2pnxU/Rm2Yik=; b=pHaSFAnCX6qocBPwekX1c0b/3n giEK3MtFPcGRKxk4BnbGYiWljppcCoKcm9Xv14xCr86K+TEoS/5nQj1Kjy/+z/Zu7A/+yxLm6Lfhx 1NJ0rLBH2r7BI3HLi0f+E/vIcX8PtBk1tJ2qZC51yJ7AsrD+Y0EF7IerkLx2A8bn/aJpY7Bhr+6oX 6Aavm+zZ9rMczOje1ZNl4AhmnzSj86Em1GZdj9CYxdeJAqZa2w/OWYVfSDR8gd9u/LsTmVGh53UCK 1/zXJEpa4pogc7dpNkxwseiD/36MbEf3/ohjVqmZs11nkrZ4kOFICbZ8OZj3StOsm1oGdYun8xYXD 8IjSX5Vw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xA5wM-0000000DQNH-2Aka; Fri, 25 Sep 2026 13:26:14 +0000 Received: from sender5-op-o11.zoho.com ([165.173.182.11]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xA5wK-0000000DQMQ-0Dwp; Fri, 25 Sep 2026 13:26:13 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1790342763; cv=none; d=zohomail.com; s=zohoarc; b=V5FLorA8Lb3aR+vcL5FBo9HDzvNr64Cf6wlrnB53DORVFlYjiOs35o0mAH9WXbcVJtuCN5+bKVz1vO569f6YLvWjRy7AmXuVr+CBZ9fkfR38T9XJsur6Se7qCODeKZxCyDCzXXmvAMmwIg3m5s8Xg8pRfDp84AwXsDTw/EyFs+Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1790342763; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=tbI7BY1/DMfC1o6Nu52xiZ2zV1iIXaUIFyG9Dk4Azbw=; b=gCWWqz1hZ6/B0eBdHBhvi63kX9mJEe9OrAuvd0w3nkMv4nM8H82ZJ6cWfkNpOomro6me3pa7KVLKdQFIeLo1e+7Q7xYGNCHmHXuIggMPF2xfGWapJdPp3N1L87OKAV8BcYiQf3WWKCc6o+6B3+wHHW5deabV/kZUqykWFxgdgqk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=sebastian.reichel@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1790342763; s=zohomail; d=collabora.com; i=sebastian.reichel@collabora.com; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:MIME-Version:Content-Type:In-Reply-To:Message-Id:Reply-To; bh=tbI7BY1/DMfC1o6Nu52xiZ2zV1iIXaUIFyG9Dk4Azbw=; b=jUSgJNOb5k/1s87wXZmGFXUJYpjBsFnNjpGjDRb7G8nxlk//Jj7ztMph0CXv85ue Q9dzAnDSlGxTMMPL5iam1h7Gun8hUcotu+7ZAjXsav0wmiS1/g7NyXogVxct6TdkvAU SdP79mNybPZxo3zmdQF9/MJ6Gp1JigCyINqy6IO0= Received: by smtp.zohomail.com with SMTPS id 1790342761292221.70362510434052; Fri, 25 Sep 2026 06:26:01 -0700 (PDT) Received: by venus (Postfix, from userid 1000) id 4DE3E180809; Fri, 25 Sep 2026 15:25:57 +0200 (CEST) Date: Fri, 25 Sep 2026 15:25:57 +0200 From: Sebastian Reichel To: Adam Wermuth Cc: Jonas Karlman , Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] arm64: dts: rockchip: Enable USB 2.0 host1 on Radxa ROCK 3B Message-ID: References: <20260924071445.441822-1-adam@wermuth.pl> <20260924071445.441822-2-adam@wermuth.pl> MIME-Version: 1.0 In-Reply-To: X-Zoho-Virus-Status: 1 X-Zoho-AV-Stamp: zmail-av-0.2.13.1.5.4/290.314.86 X-ZohoMailClient: External X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260925_062612_153211_5B211E9B X-CRM114-Status: GOOD ( 29.42 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7530371607395619768==" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org --===============7530371607395619768== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ezpnci3ypobxl7j4" Content-Disposition: inline --ezpnci3ypobxl7j4 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH 1/3] arm64: dts: rockchip: Enable USB 2.0 host1 on Radxa ROCK 3B MIME-Version: 1.0 Hi, On Thu, Sep 24, 2026 at 09:03:00PM +0200, Adam Wermuth wrote: > On Thu, 24 Sep 2026 6:12 PM, Jonas Karlman wrote: > > This and next patch is likely best suited as an dt-overlay. >=20 > Thanks for the review. That makes sense, as the B-key slot is not > always populated. >=20 > For v2 I will move the host1 enablement and the WWAN power, RESET# > and W_DISABLE1# handling into a new rk3568-rock-3b-wwan.dtso overlay, > and keep only the fan patch in the base DT. Why would this be better suited as an Overlay? Nothing describes the specific card plugged in as it is auto-discovered via USB. The overlays are mostly required for things that cannot easily be auto-detected. FWIW we don't have M.2 Key M as a DT overlay either. Something to consider is, that for Key E and Key M there is a proper DT binding now: Documentation/devicetree/bindings/connector/pcie-m2-*.yaml We probably want the same for Key B. Greetings, -- Sebastian >=20 >=20 > czw., 24 wrz 2026 o 18:12 Jonas Karlman napisa=C5=82(a): > > > > Hi Adam, > > > > On 9/24/2026 9:14 AM, Adam Wermuth wrote: > > > The USB 2.0 data lines of the M.2 B-key slot are routed to USB2_HOST3, > > > which is served by usb_host1_ehci/ohci through the host port of > > > usb2phy1. Enable the controllers and the PHY port so that modules in > > > the B-key slot, such as LTE modems, can enumerate. > > > > This and next patch is likely best suited as an dt-overlay. > > > > Regards, > > Jonas > > > > > > > > Signed-off-by: Adam Wermuth > > > --- > > > arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts | 13 +++++++++++++ > > > 1 file changed, 13 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts b/arch/a= rm64/boot/dts/rockchip/rk3568-rock-3b.dts > > > index 149a5306bb03..ad9a91c0d0d0 100644 > > > --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts > > > +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts > > > @@ -758,6 +758,14 @@ &usb_host0_xhci { > > > status =3D "okay"; > > > }; > > > > > > +&usb_host1_ehci { > > > + status =3D "okay"; > > > +}; > > > + > > > +&usb_host1_ohci { > > > + status =3D "okay"; > > > +}; > > > + > > > &usb_host1_xhci { > > > status =3D "okay"; > > > }; > > > @@ -780,6 +788,11 @@ &usb2phy1 { > > > status =3D "okay"; > > > }; > > > > > > +&usb2phy1_host { > > > + phy-supply =3D <&vcc5v0_usb_host>; > > > + status =3D "okay"; > > > +}; > > > + > > > &usb2phy1_otg { > > > phy-supply =3D <&vcc5v0_usb_host>; > > > status =3D "okay"; > > >=20 --ezpnci3ypobxl7j4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmq2dloACgkQ2O7X88g7 +pr/mg/7B+OoEEnFA754wyjYfRo8dxmBN2hNuzkDTAK9Nt3BsF9Isgc9nHMJ+u05 nnyo/WzdkZA1PxvQHfCdAvM0GvqiGfjMJGrHSdlY9Oe49aVSDqz9nKiHWg2CWmDu zbTryJ8NW+5V/xeDGBHdM6cyMijY163EbOGYjiADvp5s5BRuHAtjyBp7mR1ioIQv WvJH80zO5zKZ+HEBrEQb7Ubtu1nutrdi1+dv0gd6+lLwLclsAz02GOzORBC3m4QG wm5tKVHKvatK2qNvPvqwOzagDLzRboJRizUK9xpsl0cFo8vUUhTBzyqANTxDr1f/ ZnlntysqzIlUryj7lFxCUnR3faIMEZ/gNd19z87+JtMnyMpoMry5JSnaU+wcS9aO rLdK79wUux7VW3xMH35NWR7Tzh5OYXyizncw5TJ0l6vwlH8qGgS2M3wuisDtrzax lAkNhwXKCjokbemj2/JBGX632TZY/ZUHq+4mVQ27+6pjfx13efMiM6+FRfav2pfU BqONw6uZkbTi3RURfYMumfftnjczwQtqAd5sYV3cdVg9ufHRgs3yRgfVHbboKYPV dfJoj3w/UldTw4TB3VHzBdcQiQ7boCIVjIAJQkhTTil2nT2QqXk1ZATN+RDz3Q3n nILT8M3CGNu+7No4ijr1nksfo9Hev19qsbkVU4nORonCCwTvgUA= =rQLU -----END PGP SIGNATURE----- --ezpnci3ypobxl7j4-- --===============7530371607395619768== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip --===============7530371607395619768==--