From: "Maxime Ripard" <mripard@kernel.org>
To: "Cristian Ciocaltea" <cristian.ciocaltea@collabora.com>
Cc: dri-devel@lists.freedesktop.org, kernel@collabora.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-sunxi@lists.linux.dev,
"Algea Cao" <algea.cao@rock-chips.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Andy Yan" <andy.yan@rock-chips.com>,
"Chen-Yu Tsai" <wens@kernel.org>,
"Daniel Stone" <daniels@collabora.com>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"David Airlie" <airlied@gmail.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Liu Ying" <victor.liu@nxp.com>,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Maíra Canal" <mcanal@igalia.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Phong LE" <ple@baylibre.com>,
"Raspberry Pi Kernel Maintenance" <kernel-list@raspberrypi.com>,
"Robert Foss" <rfoss@kernel.org>,
"Samuel Holland" <samuel@sholland.org>,
"Sandy Huang" <hjc@rock-chips.com>,
Sashiko <sashiko-bot@kernel.org>,
"Simona Vetter" <simona@ffwll.ch>,
"Thomas Zimmermann" <tzimmermann@suse.de>
Subject: Re: [PATCH v10 02/69] drm/connector: hdmi: Handle reset() state allocation failure
Date: Thu, 13 Aug 2026 13:45:05 +0000 [thread overview]
Message-ID: <b4902134934e37aaa9b8c0c332324e2e@kernel.org> (raw)
In-Reply-To: <20260731-dw-hdmi-qp-scramb-v10-2-294364b2cf15@collabora.com>
On Fri, 31 Jul 2026 19:19:09 +0300, Cristian Ciocaltea wrote:
> In drmm_connector_hdmi_init(), if the reset callback fails to allocate
> memory, e.g. inside drm_atomic_helper_connector_reset(),
> connector->state will remain NULL. This is unconditionally passed to
> drm_connector_attach_max_bpc_property(), leading to a NULL pointer
> dereference.
>
> [ ... ]
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-08-13 13:45 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 16:19 [PATCH v10 00/69] Add HDMI 2.0 support to DW HDMI QP TX Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 01/69] video/hdmi: Introduce HDMI version enum Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 02/69] drm/connector: hdmi: Handle reset() state allocation failure Cristian Ciocaltea
2026-08-13 13:45 ` Maxime Ripard [this message]
2026-07-31 16:19 ` [PATCH v10 03/69] drm/display: hdmi: Rename drmm_connector_hdmi_init() to *_ini2() Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 04/69] drm/connector: Add drmm_connector_hdmi_init() with new signature Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 05/69] drm/display: bridge_connector: Convert to drmm_connector_hdmi_init() Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 06/69] drm/probe-helper: Introduce .force_ctx() connector callback Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 07/69] drm/connector: Add HDMI 2.0 scrambler infrastructure Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 08/69] drm/display: scdc-helper: Add macro for connector-prefixed debug messages Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 09/69] drm/display: scdc-helper: Add helper to set SCDC version information Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 10/69] drm/display: hdmi: Add HDMI 2.0 scrambling management helpers Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 11/69] drm/display: hdmi: Advertise SCDC source version when scrambling Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 12/69] drm/bridge: Fix unlocked list_del in drm_bridge_add() Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 13/69] drm/bridge: Fix unlocked list access in drm_bridge_attach() Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 14/69] drm/bridge: Remove redundant error check in drm_bridge_helper_reset_crtc() Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 15/69] drm/bridge: Add bridge ops for source-side HDMI 2.0 scrambling Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 16/69] drm/display: bridge_connector: Use cached connector status in .get_modes() Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 17/69] drm/display: bridge_connector: Switch to .detect_ctx() connector helper Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 18/69] drm/display: bridge_connector: Switch to .force_ctx() " Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 19/69] drm/display: bridge_connector: Wire up HDMI 2.0 scrambler callbacks Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 20/69] drm/display: hdmi-state-helper: Add source TMDS rate validation Cristian Ciocaltea
2026-08-13 13:35 ` Maxime Ripard
2026-07-31 16:19 ` [PATCH v10 21/69] drm/display: hdmi-state-helper: Pass acquire ctx to hotplug helpers Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 22/69] drm/display: hdmi-state-helper: Sync SCDC state on hotplug Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 23/69] drm/display: hdmi-state-helper: Set HDMI scrambling requirement Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 24/69] drm/bridge: dw-hdmi-qp: Rate limit i2c read error messages Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 25/69] drm/bridge: dw-hdmi-qp: Provide .{enable,disable}_hpd() PHY ops Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 26/69] drm/bridge: dw-hdmi-qp: Remove unused workqueue include and define Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 27/69] drm/bridge: dw-hdmi-qp: Add HDMI 2.0 scrambling support Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 28/69] drm/bridge: dw-hdmi-qp: Provide dw_hdmi_qp_hpd_notify() helper Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 29/69] drm/rockchip: dw_hdmi_qp: Fix invalid drvdata access in PM ops Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 30/69] drm/rockchip: dw_hdmi_qp: Cancel pending HPD work on suspend Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 31/69] drm/rockchip: dw_hdmi_qp: Add missing newlines in dev_err_probe() messages Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 32/69] drm/rockchip: dw_hdmi_qp: Use local dev variable consistently in bind() Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 33/69] drm/rockchip: dw_hdmi_qp: Avoid spurious HPD IRQ thread wakeups Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 34/69] drm/rockchip: dw_hdmi_qp: Mask RK3576 HPD IRQ in io_init Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 35/69] drm/rockchip: dw_hdmi_qp: Implement .{enable,disable}_hpd() PHY ops Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 36/69] drm/rockchip: dw_hdmi_qp: Factor out HPD interrupt (un)mask helpers Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 37/69] drm/rockchip: dw_hdmi_qp: Control the HPD IRQ line via the bridge HPD ops Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 38/69] drm/rockchip: dw_hdmi_qp: Use dw_hdmi_qp_hpd_notify() for HPD reports Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 39/69] drm/bridge: dw-hdmi-qp: Drop unused .setup_hpd() phy op Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 40/69] drm/vc4: hdmi: Use common TMDS char rate constants Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 41/69] drm/vc4: hdmi: Switch to drm_hdmi_mode_needs_scrambling() Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 42/69] drm/vc4: hdmi: Switch to .force_ctx() connector helper Cristian Ciocaltea
2026-08-13 13:28 ` Maxime Ripard
2026-07-31 16:19 ` [PATCH v10 43/69] drm/vc4: hdmi: Propagate -EDEADLK to the top level Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 44/69] drm/vc4: hdmi: Convert to drmm_connector_hdmi_init() Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 45/69] drm/vc4: hdmi: Convert to common HDMI 2.0 scrambling infrastructure Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 46/69] drm/vc4: hdmi: Defer pixel clock validation to HDMI helpers Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 47/69] drm/display: hdmi-state-helper: Drop drm_atomic_helper_connector_hdmi_force() Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 48/69] drm/bridge: adv7511: Advertise HDMI 1.2 capabilities Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 49/69] drm/bridge: inno-hdmi: " Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 50/69] drm/bridge: ite-it6263: Drop redundant .mode_valid hook Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 51/69] drm/bridge: ite-it6263: Advertise HDMI 1.3 capabilities Cristian Ciocaltea
2026-07-31 16:19 ` [PATCH v10 52/69] drm/bridge: ite-it66121: Advertise HDMI 1.2 capabilities Cristian Ciocaltea
2026-07-31 16:20 ` [PATCH v10 53/69] drm/bridge: lontium-lt9611: Advertise HDMI 1.4 capabilities Cristian Ciocaltea
2026-07-31 16:20 ` [PATCH v10 54/69] drm/rockchip: rk3066_hdmi: " Cristian Ciocaltea
2026-07-31 16:20 ` [PATCH v10 55/69] drm/sun4i: hdmi: Convert to drmm_connector_hdmi_init() Cristian Ciocaltea
2026-08-13 13:29 ` Maxime Ripard
2026-07-31 16:20 ` [PATCH v10 56/69] drm/tests: edid: Add 4K@60Hz EDID with 600MHz TMDS Cristian Ciocaltea
2026-07-31 16:20 ` [PATCH v10 57/69] drm/tests: edid: Fix conformity for 1080p+4K YUV420 200MHz EDID Cristian Ciocaltea
2026-07-31 16:20 ` [PATCH v10 58/69] drm/tests: edid: Fix conformity for 4K RGB/YUV 340MHz EDID Cristian Ciocaltea
2026-07-31 16:20 ` [PATCH v10 59/69] drm/tests: bridge: Set supported HDMI version Cristian Ciocaltea
2026-07-31 16:20 ` [PATCH v10 60/69] drm/tests: connector: Convert to drmm_connector_hdmi_init() Cristian Ciocaltea
2026-07-31 16:20 ` [PATCH v10 61/69] drm/tests: connector: Add HDMI max_tmds_char_rate init coverage Cristian Ciocaltea
2026-07-31 16:20 ` [PATCH v10 62/69] drm/tests: connector: Add HDMI source-side scrambler coverage Cristian Ciocaltea
2026-07-31 16:20 ` [PATCH v10 63/69] drm/tests: hdmi_state_helper: Convert to drmm_connector_hdmi_init() Cristian Ciocaltea
2026-07-31 16:20 ` [PATCH v10 64/69] drm/tests: hdmi_state_helper: Add connector-provided max_tmds_char_rate coverage Cristian Ciocaltea
2026-07-31 16:20 ` [PATCH v10 65/69] drm/tests: hdmi_state_helper: Cover source-side scrambling decision Cristian Ciocaltea
2026-07-31 16:20 ` [PATCH v10 66/69] drm/connector: Remove drmm_connector_hdmi_ini2() Cristian Ciocaltea
2026-07-31 16:20 ` [PATCH v10 67/69] drm/connector: Drop redundant hdmi vendor/product fields Cristian Ciocaltea
2026-07-31 16:20 ` [PATCH v10 68/69] drm/connector: Drop redundant hdmi supported_formats field Cristian Ciocaltea
2026-07-31 16:20 ` [PATCH v10 69/69] drm/connector: Drop redundant max_bpc field Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4902134934e37aaa9b8c0c332324e2e@kernel.org \
--to=mripard@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=algea.cao@rock-chips.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=cristian.ciocaltea@collabora.com \
--cc=daniels@collabora.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel-list@raspberrypi.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=luca.ceresoli@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mcanal@igalia.com \
--cc=neil.armstrong@linaro.org \
--cc=ple@baylibre.com \
--cc=rfoss@kernel.org \
--cc=samuel@sholland.org \
--cc=sashiko-bot@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=victor.liu@nxp.com \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox