From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 504AFC0218D for ; Tue, 28 Jan 2025 09:26:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1A285ho4b9UGPkyRfbFR3ZdsYJGNpTiNvhxwCQE/Gos=; b=La8h9+Plcd31bv75Tdwt/vWG7C 2kKD5cFC1fGjK6gbt3oZkr4Qj5Ho/ifs5etGt4cTMaqSLTaSVBqAx9r1GR5orKQJisVhaBJPrFJqa hxCP9TS29qPfvV9b1R+BGRR+zV2Sy2yd8X2lmsQ7nC+mj8lQcys3ut4uKMM3eQoKJZHJ1o7z98C5N 0btt4ejBLXSsJkeGlZLWnHNnroCRvcRrVwbseRlZ91MlZgR7I37lyasBuYcsTq7NI12bPycx3l7SS TH/0eoEUIL07N+Ul3/Fw/7+jOuej2T7Ee7Kai1FuP7nh+WmwJCQk5p0KaYl1co+fEOtptjCB9dioQ ohJ1719A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tchr9-00000004X2S-1LZn; Tue, 28 Jan 2025 09:26:03 +0000 Received: from mail.manjaro.org ([2a01:4f8:c0c:51f3::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tchpm-00000004WoQ-0Bck; Tue, 28 Jan 2025 09:24:39 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1738056274; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CD6aGMkGgUesAlsT3HDG5pObkWdXtnRJmAMs5WiLGeg=; b=RwBEXPtNpHhxIK0t1mNdkDQc4WmPYgNvEIrU0KFOUGiJhLvU1tUPFOFS4REGW1ckPFLfrQ H8qzihaB1kt/C2NzPQ/gy4Qr+9qvnivYaw8kx0sBiXNVyc25ul18bOiE9rVxx2JQ9Nmlp4 aQ6nuSf5CI3yuCt29gsJGFDLnKKCRB6gP8KiR0Jraq/MFqpysbGp1GXosdIUa2tZLWEBGV QDRtFGGuTuVPxOftgmEuUdOUPXG7cxigRIg3sXFAXQc2+ZbghIhOmlJ2xNXusGwapbPj8s ugEVWMbUsodqcY6N/wV/t0Optb2qVQebaMc+aQFHPP7w4zQwdxkMDfYexkJong== Date: Tue, 28 Jan 2025 10:24:33 +0100 From: Dragan Simic To: Alexander Shiyan Cc: Alexey Charkov , Rob Herring , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, Sebastian Reichel , stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: dts: rockchip: Fix broken tsadc pinctrl binding for rk3588 In-Reply-To: References: <20250124052611.3705-1-eagle.alexander923@gmail.com> <61b494b209d7360d0f36adbf6d5443a4@manjaro.org> Message-ID: X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250128_012438_245090_A91BA408 X-CRM114-Status: GOOD ( 13.78 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hello Alexander, On 2025-01-26 15:25, Alexander Shiyan wrote: >> > > I think it's actually better to accept the approach in Alexander's >> > > patch, because the whole thing applies to other Rockchip SoCs as well, >> > > not just to the RK3588(S). >> > >> > Anyway, I've just tried it after including the changes below, and >> > while /sys/kernel/debug/pinctrl/pinctrl-handles shows the expected >> > pinctrls under tsadc, the driver still doesn't seem to be triggering a >> > PMIC reset. Weird. Any thoughts welcome. >> >> I found the culprit. "otpout" (or "default" if we follow Alexander's >> suggested approach) pinctrl state should refer to the &tsadc_shut_org >> config instead of &tsadc_shut - then the PMIC reset works. > > Great, I'll use this in v2. Please, let's wait with the v2 until I go through the whole thing again, which I expected to have done already, but had some other "IRL stuff" that introduced a delay. _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip