From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Heiko Stübner" <heiko@sntech.de>,
long.yunjian@zte.com.cn, hjc@rock-chips.com
Cc: andy.yan@rock-chips.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
simona@ffwll.ch, dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
fang.yumeng@zte.com.cn, mou.yi@zte.com.cn, xu.lifeng1@zte.com.cn,
ouyang.maochun@zte.com.cn
Subject: Re: [PATCH] drm/rockchip: Use dev_err_probe() to simplify code
Date: Thu, 22 May 2025 10:45:08 +0200 [thread overview]
Message-ID: <ba9a49d5-132f-4be8-9f64-4904c91e26be@kernel.org> (raw)
In-Reply-To: <2022996.jZfb76A358@diego>
On 16/05/2025 11:58, Heiko Stübner wrote:
> Am Donnerstag, 15. Mai 2025, 17:54:20 Mitteleuropäische Sommerzeit schrieb Krzysztof Kozlowski:
>> On 15/05/2025 14:35, long.yunjian@zte.com.cn wrote:
>>> From: Yumeng Fang <fang.yumeng@zte.com.cn>
>>>
>>> In the probe path, dev_err() can be replaced with dev_err_probe()
>>
>> That's not probe path. I am not sure if you really understand this code.
>
> I think that is somewhat debateable.
>
> dw_hdmi_rockchip_bind() is part of the rockchip-drm component device,
> so part of its probe-path. Also I think just the presence of EPROBE_DEFER
> which causes the device to re-try probing later is a nice indicator that the
No, that's not true. You can call every API like regulator_get from any
context and you will get EPROBE_DEFER. This will not be a probe path.
There are multiple cases of such drivers, I saw such patch even day ago.
> code in question is _a_ probe path. (and usage of EPROBE_DEFER is an
> established pattern to make that component device re-try probing later)
>
> And the parse_dt function itself is part of that path too.
I quickly glanced and this was not obvious. The commit msg is poor here
and does not explain that component_bind is ALWAYS probe path (unless it
is clear for DRM folks).
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-05-22 8:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 12:35 [PATCH] drm/rockchip: Use dev_err_probe() to simplify code long.yunjian
2025-05-15 15:54 ` Krzysztof Kozlowski
2025-05-16 9:58 ` Heiko Stübner
2025-05-22 8:45 ` Krzysztof Kozlowski [this message]
2025-05-23 9:36 ` Andy Yan
2025-07-08 17:35 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba9a49d5-132f-4be8-9f64-4904c91e26be@kernel.org \
--to=krzk@kernel.org \
--cc=airlied@gmail.com \
--cc=andy.yan@rock-chips.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fang.yumeng@zte.com.cn \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=long.yunjian@zte.com.cn \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mou.yi@zte.com.cn \
--cc=mripard@kernel.org \
--cc=ouyang.maochun@zte.com.cn \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=xu.lifeng1@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox