From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13AFCC88E4D for ; Fri, 11 Sep 2026 12:19:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Kf/2rJ7GEU726VgX2Klzyj+Wp/ohWraCi8ZKyCdptvk=; b=JSqJwbxEe33EXI 6QemHeHP+MZ+AlTovd82dKtLzirQczRfhQkmTvCyY6kjIjulhu7qLY8gYxxdW3UYRHYBWpEjHnawc oFGjUK6JLFUu0D5odTpB6NWLmcHkUC2qH1H36aF908qf87LCUTKG7u010in+Lw6AxMO7QikLNFjgZ CR9HDD79IC6jv4v6OufE7TUP4+Njru7cEkPTolnEJ9Z4V8+Vz9X+aSbyrsgiUkkjmGD9uLCb+LaaO PIrVvj6ZN8PfZEToMwZTLL58eMRqennB96T1eWEN5ICMIwDqv+TqrjSQRopFs8NIYDwBJg7U4vdJB 3/7KvCTI5N10x/tAEzpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x50E1-0000000GcPU-1iLq; Fri, 11 Sep 2026 12:19:25 +0000 Received: from mail-ed2-x10.google.com ([2a00:1450:4864:33::10]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x50Dy-0000000GcNw-2Amu for linux-rockchip@lists.infradead.org; Fri, 11 Sep 2026 12:19:23 +0000 Received: by mail-ed2-x10.google.com with SMTP id 4fb4d7f45d1cf-6a6249b76a8so1407322a12.2 for ; Fri, 11 Sep 2026 05:19:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pardini.net; s=google; t=1789129161; x=1789733961; darn=lists.infradead.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=PL874DxmWdEEz+/Ho1XLM1gCTFYGrhEvvkDpUQlsjxY=; b=L1DZh2m19zt1Qjzyro3edmhrcSqkENc1d7TZ9vGgQLANtpGLCeolnDPW/TdhMl504u QiP718mwSuBKSL9mao0JfqWP1pXfjJIIXsF4S+XH20+awWmtdJWQCGdtMYCueWOuaoBi BKL/xQyzqM4Lfs1TCMqTyDR+3n7rEIIE4PvYkG8eZ4CqTck31p6Kyal8KCUjMOyHNQlU AEzS4fAEIlqT4r+Sv/XQ03RwPoPICZuoGjWFsqw0NU5hKAPyK9YEOUu3P+Mt7jXzWhyt XjqIEKhs9di5EC9epff5peSkftp+jONejcAU8kMArv0jw0MmkZ5vM3Q8u9KaUsdGEzOb 4U1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789129161; x=1789733961; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PL874DxmWdEEz+/Ho1XLM1gCTFYGrhEvvkDpUQlsjxY=; b=RipOzCk/3ODjZy/DWo89hhJWGFDoPQLdsBgrD2oVFsRP6qggixmWruLlxV/oc95OKb ikQY5rhnidhbsAkhWF6ya3h2gTv85AynPrT8xnl5yiNFz9UGpdBp6KeYANAiwOuA/gxj 7l+gysC5aXx8rcHJsYrlvttDom7cIgJBgqxQAuV7O5d9PmQUE8k9ex9sDqqkWGk8WyAY EoBgK2b6UmpUPUmtD6uRlAYpmDVFWkfAw42e1qMlKFQ3dyo2875TQUOuWQW5fUiqDelV FRBfH+MRPvWBTyDA9hv4twg0250VbNi0SQKcQlP8LeFH6dVqIuIjWxczz+pbZvOUPbsZ 0X2w== X-Forwarded-Encrypted: i=1; AKwUvBxteU3/Z2s/TFuok1CZb7H/91A77APBYFxqjWuqTOuGw5H78zI1S03w0RIS8l+SrCQ1d3yG+sO/qxNeZrA7Jw==@lists.infradead.org X-Gm-Message-State: AFuF++mVgENS93e/VFkoI0U+sFFgjWcJFbmZTAdsYRG8mP+Ou23uxzLd 9cN1bFqEwKtC4QjH+t8BBwZJJlVsGeC0/LcEylTXLqkEzT5QoVLdxCu9pX8RgvtLSA== X-Gm-Gg: AYBFou2Zc7Al2kTsd+CYMLccbwJToGT/4yuCZE/2DnYIdFjYvifxrz9S783z9NMgB63 Ipp8LS/GQtQ45WuLjsJOPUfOKovDva9mlqvUF+4RVQKhpd/Yszj5hytHzesjskd3/p9h1IvlPfB K9zgjUl2Ew85AXwFTnUV0XgmMou58uFFH05KQrQrZBnf/hgQbhaw4Hf/LGw0Tm78jEqWt1N2ZgV Eb1f7Uv7Y7WOwNwahIimZwZVtAvlQmCprxH5uwdWm8nV05pDpwp3blVAJ1jyPA757/1GT0VBj+u x/mBP7m3KD6zibVxQGrSLtQdwgG8tSSI4KFMC4apDOlgecJCY5kYhLONDk8aNpEqY5Dbtu4UYvN 1rZkSjinAq7YYps04s4AzrmUBYykRj6aqMmjoY+Ek7q/KQbCmt9VYM1+X8IJm/9au4ckDkIDIRi 7z1KoIVFMMoFXR5tMD6q0r9DhjTLwJZ5fUTE4JPEmORaG2byyxFG0tjvqxUgzfqrKH8g2gor9sh fwHlrPxYd582WZBU7Y7cd34VvhQoDe4Nq2E58PG2Hs+e7gT7AeNtSeI96mEkpfYyBZ73YSVjbdF 6ijLyZHCgbrDFIf63A1Nrpib9ArXv4vBGB2LvjqFCa3TiI8= X-Received: by 2002:a05:6402:42d2:b0:6a9:b203:f410 with SMTP id 4fb4d7f45d1cf-6a9b5694f10mr1718054a12.21.1789129160539; Fri, 11 Sep 2026 05:19:20 -0700 (PDT) Received: from ?IPV6:2a02:a466:4d7a:0:d90f:783f:2e2e:893d? (2a02-a466-4d7a-0-d90f-783f-2e2e-893d.fixed6.kpn.net. [2a02:a466:4d7a:0:d90f:783f:2e2e:893d]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a9b594f0fasm778079a12.25.2026.09.11.05.19.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Sep 2026 05:19:20 -0700 (PDT) Message-ID: Date: Fri, 11 Sep 2026 14:19:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/7] arm64: dts: rockchip: describe PCIe RTL8125 Ethernet on NanoPC-T6 To: Diederik de Haas , Heiner Kallweit , nic_swsd@realtek.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Sebastian Reichel , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org References: <20260910-rk3588-dts-rtl-eth-describe-dt-alias-v5-0-c1b9e5f10cd6@pardini.net> <20260910-rk3588-dts-rtl-eth-describe-dt-alias-v5-2-c1b9e5f10cd6@pardini.net> Content-Language: en-US From: Ricardo Pardini In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260911_051922_601376_19A826A9 X-CRM114-Status: GOOD ( 22.86 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 11/09/2026 11:52, Diederik de Haas wrote: > On Thu Sep 10, 2026 at 10:07 PM CEST, Ricardo Pardini via B4 Relay wrote: >> From: Ricardo Pardini >> >> The FriendlyElec NanoPC-T6 carries two on-board Realtek RTL8125 NICs >> behind pcie2x1l0 and pcie2x1l2. >> >> Describe the fixed function nodes and attach ethernet0/ethernet1 >> aliases, so that U-Boot's fdt_fixup_ethernet() can fill in the MAC >> from its ethaddr/eth1addr env. The on-NIC EEPROMs on this board are >> not pre-programmed with a unique MAC, so this gives a stable MAC >> across boots that both U-Boot and the kernel agree on. >> >> Signed-off-by: Ricardo Pardini >> --- >> arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtsi | 30 ++++++++++++++++++++++ >> 1 file changed, 30 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtsi >> index cfdb5c13f8606..550358a756618 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtsi >> @@ -20,6 +20,8 @@ / { >> compatible = "friendlyarm,nanopc-t6", "rockchip,rk3588"; >> >> aliases { >> + ethernet0 = &rtl_eth0; >> + ethernet1 = &rtl_eth1; >> mmc0 = &sdhci; >> mmc1 = &sdmmc; >> }; >> @@ -644,6 +646,20 @@ &pcie2x1l0 { >> pinctrl-names = "default"; >> pinctrl-0 = <&pcie2_0_rst>; > > The new pinctrl reference is ``pcie_25glan_perstb_b_pin``, so this patch needs > to be rebased. Indeed; I sent v5 vs v7.3-rc2 which doesn't have your recent series fixing those. I've rebased onto next-20260910 which does, will send in a v6 - but it's really just fuzz/context changes. I'll wait a bit until Heiner/Krysztof/Heiko chime in ref the binding and its wording as that has been contentious in the previous versions. And who knows what Sashiko will find this time. > >> status = "okay"; >> + >> + pcie@0,0 { >> + reg = <0x200000 0 0 0 0>; >> + #address-cells = <3>; >> + #size-cells = <2>; >> + ranges; >> + device_type = "pci"; >> + bus-range = <0x21 0x2f>; >> + >> + rtl_eth0: ethernet@0,0 { >> + compatible = "pci10ec,8125"; >> + reg = <0x210000 0 0 0 0>; >> + }; > > Described on page 23 of the schematic titled '2.5G Ethernet B' and ``U12`` > (ie RTL8125BG) is connected to LAN2 which has ``ETH2`` as label on the case. Confirmed. > >> + }; >> }; >> >> &pcie2x1l1 { >> @@ -660,6 +676,20 @@ &pcie2x1l2 { >> pinctrl-names = "default"; >> pinctrl-0 = <&pcie2_2_rst>; > > The new pinctrl reference is ``pcie_25glan_perstb_pin``. Will also be fixed by rebasing onto linux-next. > >> status = "okay"; >> + >> + pcie@0,0 { >> + reg = <0x400000 0 0 0 0>; >> + #address-cells = <3>; >> + #size-cells = <2>; >> + ranges; >> + device_type = "pci"; >> + bus-range = <0x41 0x4f>; >> + >> + rtl_eth1: ethernet@0,0 { >> + compatible = "pci10ec,8125"; >> + reg = <0x410000 0 0 0 0>; >> + }; > > Described on page 22 of the schematic titled '2.5G Ethernet A' and ``U10`` > (ie RTL8125BG) is connected to LAN1 which has ``ETH1`` as label on the case. > > So this results in: > ETH1 -> rtl_eth1 > ETH2 -> rtl_eth0 > > This sounds like a recipe for confusion and/or potential future mistakes. > I think using ``rtl_eth1`` and ``rtl_eth2`` would be less confusing, but > I'm fine with another construct which achieves a similar thing. Yeah, that will result in aliases `ethernet0 = &rtl_eth1;` and `ethernet1 = &rtl_eth2;`. It could also be `rtl_lan1`/`rtl_lan2`, or as the schematics seems to to use the `_b` suffix, just `rtl_lan` and `rtl_lan_b`, I don't mind. Raise if you do, otherwise I'll send v6 as you suggested. Userspace will be off-by-one vs the printed case labels, thus _some_ confusion will remain, but it's already better than the current enP2p33s0/enP4p65s0. > > Cheers, > Diederik > >> + }; >> }; >> >> &pcie30phy { > Thanks, Ricardo _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip