From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Yan <andyshrk@163.com>, heiko@sntech.de
Cc: krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/5] dt-bindings: arm: rockchip: Add Cool Pi 4B
Date: Sat, 9 Dec 2023 15:00:09 +0100 [thread overview]
Message-ID: <bd62fe7b-3d66-4ade-9aaf-37af449b08c2@linaro.org> (raw)
In-Reply-To: <20231209103748.1568462-1-andyshrk@163.com>
On 09/12/2023 11:37, Andy Yan wrote:
> Add Cool Pi 4B, a SBC powered by RK3588S
>
> Signed-off-by: Andy Yan <andyshrk@163.com>
> ---
>
> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 5deb66a5c7d9..5de9f3090be1 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -95,6 +95,11 @@ properties:
> - const: chipspark,rayeager-px2
> - const: rockchip,rk3066a
>
> + - description: Cool Pi 4 Model B
> + items:
> + - const: CoolPi 4 Model B
That's not a correct compatible.
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2023-12-09 14:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 10:36 [PATCH 0/5] Add 2 rk3588 based boards from Cool Pi Andy Yan
2023-12-09 10:37 ` [PATCH 1/5] dt-bindings: vendor-prefixes: Add " Andy Yan
2023-12-09 14:00 ` Krzysztof Kozlowski
2023-12-09 10:37 ` [PATCH 2/5] dt-bindings: arm: rockchip: Add Cool Pi 4B Andy Yan
2023-12-09 14:00 ` Krzysztof Kozlowski [this message]
2023-12-09 14:00 ` Heiko Stübner
2023-12-09 10:38 ` [PATCH 3/5] arm64: dts: rockchip: Add support for rk3588s based board CoolPi 4B Andy Yan
2023-12-09 14:03 ` Krzysztof Kozlowski
2023-12-10 7:18 ` kernel test robot
2023-12-09 10:38 ` [PATCH 4/5] dt-bindings: arm: rockchip: Add Cool Pi CM5 EVB Andy Yan
2023-12-09 14:01 ` Heiko Stübner
2023-12-09 10:38 ` [PATCH 5/5] arm64: dts: rockchip: Add support for rk3588 based board " Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd62fe7b-3d66-4ade-9aaf-37af449b08c2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andyshrk@163.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox