From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71B39CA0FED for ; Fri, 5 Sep 2025 18:30:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J6SHlR+jyI769HSRWS6K3BOvnf5W+4baZUjaHyAMmaE=; b=0CSrDijQWO5dratm+iuujjkuIM cj10kUj6OhxOau+BHEKviXwBVfRONiL5Hm8fmrp/wT4719LWxpKe3+BSuk7D6gkK9AIjDwFKeNQKi a/eG2PDdbQ3i9wq0PhPbmZrDNpvA89HgkIkZ9/iReHjtGBTZET33n7+cUFRwsyTq4i96+z3VpHIKK FvMGkXG6m1q8e5wHd8YAgz+mf3/7u7kSLfI3vbHSTnpQ/GVa5uaAemnCuoD8f9zLM8E7sDsFrPFn2 Yip44tWzY3TUUMNuZnGkaYlFRnruZXip2LFVIQZ+RPEzr4/lPQLSzg7ZU7rJdz4omt98guX5K7mIM PzoVgWkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uubD3-00000003nsk-0Ggf; Fri, 05 Sep 2025 18:30:53 +0000 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uuXTV-00000002J5J-3yEY; Fri, 05 Sep 2025 14:31:39 +0000 Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-32bae4bcd63so901694a91.2; Fri, 05 Sep 2025 07:31:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757082697; x=1757687497; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=3vIXH9G8eZJ7ix/XNHz4bvSACtWtZGWHKqaN5lng6nE=; b=d+ntNr69fRbDtnyilIuNGE0EyGdBD+6WD0bVkTf4i5m5jTPDCo7y3KdFx3JokwrkkJ keIgrwFMdIpIyYIpKPboCRc9zMTYGE9hIbKw14TEJXC6EYvHhYO2WbgeyZS/zXrTMaEg H8i7d4qOjD3DWJOYL5gaPxlJO5NJje6HfJTSKLSRs9mrNoVYw5/VZI2Oy6DJwCtKMFn7 tG/XEo+EBymHEwMT5BPFdYFpy9BHaKo54/mEss/0GHRRGGr1f34UJ4pbo9Q9bwYqSFn6 zpTfC94yfYhoBdS77ZUKi7K2GA9hFV1e53JT+Lbl64hnFxd9+dDoiS/tE6w28IIIcWmy 6exw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757082697; x=1757687497; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3vIXH9G8eZJ7ix/XNHz4bvSACtWtZGWHKqaN5lng6nE=; b=j3NvJk0oFgslo7D+1nAmncj2XIy/jkh1oImZ9nbbjiPk+pS7SOioYhh8j6sTWY6DNF no5BCS29XoOg1vvB2Gn3ntkU8mv5+3lX6ZW99HserV08B34T2mt0imRGeWKBzU75Oy4o WFpuB84UGTu9b2EiGOA8YMU8EMV3DYIIeZsu56F6xOZJDqGL5YfMZ1FjbUlqCHD3pqTu ZABOYYysWgwyUnlBl5dco+I2NkY/TWoyVp3jSWSFhgIIT6K1a8Sq0A5wvcPDR2JxjXxg tYYQtVQiTYlJUZ6+KwNpkqJThzAP0wKJhYEcvm4t5cG1755rQuVoc6z0JDWeZX+mcT8p IDkg== X-Forwarded-Encrypted: i=1; AJvYcCUjpf6mE+tkdVImny5bh95iWfZuOXbBybHMHotizJli5ax9pyD5FQ1n4OoJjz3sTqTGkiAlqEAL79UxZ9LbM0s=@lists.infradead.org, AJvYcCWKzMB8wxGOHeDUbK4tZ1pXGBVx2RAjRKRV5Nv1a8h/JRm4nHkmqBGsNAEHoFAenFp0uGbKWGnLnt4PDD1LDRkvKw==@lists.infradead.org, AJvYcCWRfWPnKjoUXdODeZ7Wt/7QAjmUJSH0emHIQP8P+98lLWICzzAD4HAYah/t9sD0kR+c5hPCzrtcmQGihN1slpTmdA==@lists.infradead.org, AJvYcCX179rWMevFsc0aTdWCt8djU8oPjeKvIwZ2KP/WWTzrDznceU79FJ6DMH04tdaNN8t2aLuzNADLrMsDqNOF@lists.infradead.org X-Gm-Message-State: AOJu0YwtGjogepp1KLcVPJeiCXNbfEYGsDZ+424W+t73tWi9m0sPJwoO sbLLFhJNjqUzQVgPnqA0AFhzhQwwlF8KOUMps4T1KhN+Df3LffT6JyNb X-Gm-Gg: ASbGncsMb4oVdlgIOWoFbAuno4lYaRBzBLHPbBBIWEHTfBzktvtLCHxTM/SoPB4+IL6 R5I6gScxbkqCkPbAuFwuWTLAko4qvbsRbTcRQzB8DhMA1h4M40YdZspysPVzu2KQWZAJaUXW3Jn gHuenscrUFebogNsFFVUb3VOJlE6iEK0ZQJWI4pucWGIy63StIvEGFz8fbIK1YtCbiV7LCrou3t wI5tfl4GwyNui9LAgdU5DTQMa5JpPsgXdT3BCIisG96muCo8+0+zuUku0i6mQwAgK6FJ0rQ5rqh 9sjmllUwqf0PC6GjhOtOOHcaNJ+blqROnAH2lXIf4AJ+vMt2phV4iEaGQvrPrYxOkPHEKXQDH/9 xREZ7eYYwEIYa1xlOMvo57rSC9UYnDKuN3LrEzf9Rj3WGA1pJbmZw09OFWAHoeniiq9itb5P0q8 qfhTPYcw== X-Google-Smtp-Source: AGHT+IGsUGu45MQwt+NZPV5mLr8VYLLqfRHTzbjIcd42cuNIOrbj6li3sVxyZFvsqM7RMTuhEoyH4A== X-Received: by 2002:a17:90b:4c4b:b0:32b:94a2:b0d6 with SMTP id 98e67ed59e1d1-32b94a2b221mr8959418a91.3.1757082696826; Fri, 05 Sep 2025 07:31:36 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-77267a225e6sm12382015b3a.94.2025.09.05.07.31.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Sep 2025 07:31:36 -0700 (PDT) Message-ID: Date: Fri, 5 Sep 2025 07:31:31 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/12] hwmon: Remove redundant error log prints To: Xichao Zhao , Jean Delvare , Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Liam Girdwood , Mark Brown , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Guillaume La Roque , Miquel Raynal , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , Markus Mayer , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , zhanghongchen , Yinbo Zhu , Amit Kucheria , Thara Gopinath , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Alim Akhtar , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Thierry Reding , Jonathan Hunter , Talel Shenhar , Eduardo Valentin , Keerthy , Kunihiko Hayashi , Masami Hiramatsu , "open list:HARDWARE MONITORING" , open list , "open list:IIO SUBSYSTEM AND DRIVERS" , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:ARM/Allwinner sunXi SoC support" , "open list:THERMAL" , "open list:THERMAL DRIVER FOR AMLOGIC SOCS" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:QUALCOMM TSENS THERMAL DRIVER" , "open list:RENESAS R-CAR THERMAL DRIVERS" , "open list:ARM/Rockchip SoC support" , "open list:SAMSUNG THERMAL DRIVER" , "moderated list:ARM/STM32 ARCHITECTURE" , "open list:TEGRA ARCHITECTURE SUPPORT" , "open list:TI BANDGAP AND THERMAL DRIVER" References: <20250905072423.368123-1-zhao.xichao@vivo.com> <20250905072423.368123-3-zhao.xichao@vivo.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20250905072423.368123-3-zhao.xichao@vivo.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250905_073137_993010_4EB698DD X-CRM114-Status: GOOD ( 18.13 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 9/5/25 00:23, Xichao Zhao wrote: > devm_thermal_of_zone_register() prints error log messages when > it fails, so there is no need to print error log messages again. > > Signed-off-by: Xichao Zhao > --- > drivers/hwmon/hwmon.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon/hwmon.c > index 1688c210888a..0514e4bc5e71 100644 > --- a/drivers/hwmon/hwmon.c > +++ b/drivers/hwmon/hwmon.c > @@ -239,8 +239,7 @@ static int hwmon_thermal_add_sensor(struct device *dev, int index) > if (IS_ERR(tzd)) { > if (PTR_ERR(tzd) != -ENODEV) > return PTR_ERR(tzd); > - dev_info(dev, "temp%d_input not attached to any thermal zone\n", > - index + 1); > + This series moves the message from an informational message here to an error message in the thermal core, even though it is (for hwmon) not an error. I personally think this is a bad idea. Can we get another API that lets me suppress that error message ? Guenter > devm_kfree(dev, tdata); > return 0; > } _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip