From: Dragan Simic <dsimic@manjaro.org>
To: Diederik de Haas <didi.debian@cknow.org>
Cc: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>,
Peter Robinson <pbrobinson@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: enable rng on all rk356x
Date: Mon, 02 Dec 2024 15:50:07 +0100 [thread overview]
Message-ID: <c50f603a9e1a819f17f72e97e92aeebd@manjaro.org> (raw)
In-Reply-To: <D6175VTSP13T.200HWIIHOIDQQ@cknow.org>
Hello Diederik and Marcin,
On 2024-12-02 13:01, Diederik de Haas wrote:
> On Mon Dec 2, 2024 at 11:40 AM CET, Marcin Juszkiewicz wrote:
>> W dniu 2.12.2024 o 04:55, Dragan Simic pisze:
>> > On 2024-12-02 00:46, Peter Robinson wrote:
>> >> The rk356x rng is available on both the rk3566 and rk3568
>> >> parts, the IP is all self contained within the SoCs so
>> >> it's enabled already by default on rk3568 so let's enable
>> >> it in the base rk356x.dtsi so it's enabled consistently
>> >> everywhere.
>> >
>> > Please, go through the mailing list threads [1][2] that have led us
>> > to the current state. To sum it up, it isn't about what's
>> supported
>> > in the two RK356x SoC variants, but about the RK3566's HWRNG being
>> > disabled because the testing showed that it produces unacceptably
>> > low quality of random data, for some yet unknown reason.
>>
>> So maybe there should be a comment in rockchip/rk3568.dtsi so we would
>> not get back to it again.
>
> I suggested to put that in the (original) commit message:
> https://lore.kernel.org/linux-rockchip/6690040.iosknibmi9@bagend/
> precisely because this was quite predictable to happen.
>
> So a +1 on a comment in the dtsi with a link to the discussion in the
> commit message.
Totally agreed on adding a brief summary to the RK356x base SoC dtsi,
so I went ahead and sent a patch that adds it. [1] I also expected
that to be described in the base dtsi back when the HWRNG support was
added, but it somehow went in without the description.
[1]
https://lore.kernel.org/linux-rockchip/6b272e2f8f916c04b05db50df621659a5a7f29ab.1733149874.git.dsimic@manjaro.org/
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-12-02 14:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a>
2024-12-01 23:46 ` [PATCH] arm64: dts: rockchip: enable rng on all rk356x Peter Robinson
2024-12-02 3:55 ` Dragan Simic
2024-12-02 10:40 ` Marcin Juszkiewicz
2024-12-02 12:01 ` Diederik de Haas
2024-12-02 14:50 ` Dragan Simic [this message]
2024-12-02 15:32 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c50f603a9e1a819f17f72e97e92aeebd@manjaro.org \
--to=dsimic@manjaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=didi.debian@cknow.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=pbrobinson@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox