Linux-Rockchip Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: David Wu <david.wu@rock-chips.com>
To: Ezequiel Garcia <ezequiel@collabora.com>,
	netdev@vger.kernel.org, linux-rockchip@lists.infradead.org,
	devicetree@vger.kernel.org
Cc: Jose Abreu <joabreu@synopsys.com>,
	Heiko Stuebner <heiko@sntech.de>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Peter Geis <pgwipeout@gmail.com>,
	Kever Yang <kever.yang@rock-chips.com>,
	Rob Herring <robh+dt@kernel.org>,
	Johan Jonker <jbx6244@gmail.com>,
	kernel@collabora.com
Subject: Re: [PATCH 2/3] dt-bindings: net: dwmac: Add Rockchip DWMAC support
Date: Mon, 26 Apr 2021 17:49:47 +0800	[thread overview]
Message-ID: <c82d5147-3545-03d5-47cc-cc93161d3414@rock-chips.com> (raw)
In-Reply-To: <20210426024118.18717-2-ezequiel@collabora.com>

Hi Ezequiel,

Good work,  this is what I plan to do.
Thank you.

Reviewed-by: David Wu <david.wu@rock-chips.com>

在 2021/4/26 上午10:41, Ezequiel Garcia 写道:
> Add Rockchip DWMAC controllers, which are based on snps,dwmac.
> Some of the SoCs require up to eight clocks, so maxItems
> for clocks and clock-names need to be increased.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> ---
>   .../devicetree/bindings/net/snps,dwmac.yaml         | 13 +++++++++++--
>   1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 0642b0f59491..2edd8bea993e 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -56,6 +56,15 @@ properties:
>           - amlogic,meson8m2-dwmac
>           - amlogic,meson-gxbb-dwmac
>           - amlogic,meson-axg-dwmac
> +        - rockchip,px30-gmac
> +        - rockchip,rk3128-gmac
> +        - rockchip,rk3228-gmac
> +        - rockchip,rk3288-gmac
> +        - rockchip,rk3328-gmac
> +        - rockchip,rk3366-gmac
> +        - rockchip,rk3368-gmac
> +        - rockchip,rk3399-gmac
> +        - rockchip,rv1108-gmac
>           - snps,dwmac
>           - snps,dwmac-3.50a
>           - snps,dwmac-3.610
> @@ -89,7 +98,7 @@ properties:
>   
>     clocks:
>       minItems: 1
> -    maxItems: 5
> +    maxItems: 8
>       additionalItems: true
>       items:
>         - description: GMAC main clock
> @@ -101,7 +110,7 @@ properties:
>   
>     clock-names:
>       minItems: 1
> -    maxItems: 5
> +    maxItems: 8
>       additionalItems: true
>       contains:
>         enum:
> 



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2021-04-26  9:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26  2:41 [PATCH 1/3] arm64: dts: rockchip: Remove unnecessary reset in rk3328.dtsi Ezequiel Garcia
2021-04-26  2:41 ` [PATCH 2/3] dt-bindings: net: dwmac: Add Rockchip DWMAC support Ezequiel Garcia
2021-04-26  9:49   ` David Wu [this message]
2021-04-29 21:39   ` Rob Herring
2021-04-26  2:41 ` [PATCH 3/3] dt-bindings: net: convert rockchip-dwmac to json-schema Ezequiel Garcia
2021-04-26  9:50   ` David Wu
2021-04-29 21:36   ` Rob Herring
2021-04-26  9:43 ` [PATCH 1/3] arm64: dts: rockchip: Remove unnecessary reset in rk3328.dtsi David Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c82d5147-3545-03d5-47cc-cc93161d3414@rock-chips.com \
    --to=david.wu@rock-chips.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=ezequiel@collabora.com \
    --cc=heiko@sntech.de \
    --cc=jbx6244@gmail.com \
    --cc=joabreu@synopsys.com \
    --cc=kernel@collabora.com \
    --cc=kever.yang@rock-chips.com \
    --cc=kuba@kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=pgwipeout@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox