From: Quentin Schulz <quentin.schulz@cherry.de>
To: Heiko Stuebner <heiko@sntech.de>
Cc: andy.yan@rock-chips.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Heiko Stuebner <heiko.stuebner@cherry.de>
Subject: Re: [PATCH v3 2/3] drm/rockchip: lvds: Hide scary error messages on probe deferral
Date: Tue, 4 Mar 2025 15:59:09 +0100 [thread overview]
Message-ID: <cd001ccb-41a8-4204-8945-8ea00006ef0c@cherry.de> (raw)
In-Reply-To: <20250304124418.111061-3-heiko@sntech.de>
Hi Heiko,
On 3/4/25 1:44 PM, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
>
> Commit 52d11c863ac9 ("drm/rockchip: lvds: do not print scary message when
> probing defer") already started hiding scary messages that are not relevant
> if the requested supply just returned EPROBE_DEFER, but there are more
> possible sources - like the phy.
>
> So modernize the whole logging in the probe path by replacing the
> remaining deprecated DRM_DEV_ERROR with appropriate dev_err(_probe)
> and drm_err calls.
>
> The distinction here is that all messages talking about mishaps of the
> lvds element use dev_err(_probe) while messages caused by interaction
> with the main Rockchip drm-device use drm_err.
>
> Reviewed-by: Andy Yan <andy.yan@rock-chips.com>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Thanks!
Quentin
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-03-04 15:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 12:44 [PATCH v3 0/3] drm/rockchip: lvds: probe logging improvements Heiko Stuebner
2025-03-04 12:44 ` [PATCH v3 1/3] drm/rockchip: lvds: move pclk preparation in with clk_get Heiko Stuebner
2025-03-04 20:30 ` Dragan Simic
2025-03-04 21:11 ` Heiko Stübner
2025-03-04 12:44 ` [PATCH v3 2/3] drm/rockchip: lvds: Hide scary error messages on probe deferral Heiko Stuebner
2025-03-04 14:59 ` Quentin Schulz [this message]
2025-03-04 12:44 ` [PATCH v3 3/3] drm/rockchip: lvds: lower log severity for missing pinctrl settings Heiko Stuebner
2025-03-04 15:00 ` Quentin Schulz
2025-03-04 21:12 ` [PATCH v3 0/3] drm/rockchip: lvds: probe logging improvements Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd001ccb-41a8-4204-8945-8ea00006ef0c@cherry.de \
--to=quentin.schulz@cherry.de \
--cc=andy.yan@rock-chips.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko.stuebner@cherry.de \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox