From: Helen Koike <helen.koike@collabora.com>
To: Heiko Stuebner <heiko@sntech.de>,
dafna.hirschfeld@collabora.com, linux-media@vger.kernel.org,
mchehab@kernel.org, Laurent.pinchart@ideasonboard.com,
hverkuil@xs4all.nl
Cc: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>,
linux-rockchip@lists.infradead.org, tfiga@chromium.org,
ezequiel@collabora.com, christoph.muellner@theobroma-systems.com
Subject: Re: [PATCH v6 1/4] media: rockchip: rkisp1: fix comment about number of histogram sub-windows
Date: Mon, 18 Jan 2021 15:03:51 -0300 [thread overview]
Message-ID: <ce91ca03-211c-0c27-1204-4bafc815ffca@collabora.com> (raw)
In-Reply-To: <20210118110448.275389-2-heiko@sntech.de>
On 1/18/21 8:04 AM, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> The histogram data is divided into 16 sub-windows, not 25.
> See RKISP1_CIF_ISP_HIST_BIN_N_MAX being defined as 16 for reference
> and this also matches the datasheet.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Acked-by: Helen Koike <helen.koike@collabora.com>
> ---
> include/uapi/linux/rkisp1-config.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/rkisp1-config.h b/include/uapi/linux/rkisp1-config.h
> index 6e449e784260..ba443771cc0b 100644
> --- a/include/uapi/linux/rkisp1-config.h
> +++ b/include/uapi/linux/rkisp1-config.h
> @@ -846,7 +846,7 @@ struct rkisp1_cif_isp_af_stat {
> *
> * @hist_bins: measured bin counters
> *
> - * Measurement window divided into 25 sub-windows, set
> + * Measurement window divided into 16 sub-windows, set
> * with ISP_HIST_XXX
> */
> struct rkisp1_cif_isp_hist_stat {
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2021-01-18 18:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 11:04 [PATCH v6 0/4] Fix the rkisp1 userspace API for later IP versions Heiko Stuebner
2021-01-18 11:04 ` [PATCH v6 1/4] media: rockchip: rkisp1: fix comment about number of histogram sub-windows Heiko Stuebner
2021-01-18 18:03 ` Helen Koike [this message]
2021-01-18 11:04 ` [PATCH v6 2/4] media: rockchip: rkisp1: reduce number of histogram grid elements in uapi Heiko Stuebner
2021-01-18 18:04 ` Helen Koike
2021-01-18 11:04 ` [PATCH v6 3/4] media: rockchip: rkisp1: carry ip version information Heiko Stuebner
2021-01-18 18:04 ` Helen Koike
2021-01-18 11:04 ` [PATCH v6 4/4] media: rockchip: rkisp1: extend uapi array sizes Heiko Stuebner
2021-01-18 18:04 ` Helen Koike
2021-01-18 11:08 ` [PATCH v6 0/4] Fix the rkisp1 userspace API for later IP versions Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce91ca03-211c-0c27-1204-4bafc815ffca@collabora.com \
--to=helen.koike@collabora.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=ezequiel@collabora.com \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=heiko@sntech.de \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox