Re: [PATCH v5 1/4] dt-bindings: can: rockchip_canfd: add rk3576 CAN-FD controller

Krzysztof Kozlowski
2025-05-23T08:17:37Z

On 23/05/2025 09:54, Elaine Zhang wrote:
> - items:
> - const: rockchip,rk3568v3-canfd
> - const: rockchip,rk3568v2-canfd
> @@ -43,6 +44,13 @@ properties:
> - const: core
> - const: apb
>
> + dmas:
> + maxItems: 1
> +
> + dma-names:
> + items:
> + - const: rx

All devices support DMA? If so, explain this in commit msg. If not, this
needs constraints per variant. See example-schema and other bindings.

> +
> required:
> - compatible
> - reg
> @@ -72,3 +80,19 @@ examples:
> reset-names = "core", "apb";
> };
> };
> +
> + - |
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + can@2ac00000 {
> + compatible = "rockchip,rk3576-canfd";

That's the same example. Drop.

Best regards,
Krzysztof